From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?
Date: Mon, 16 Feb 2015 08:57:04 +0100 [thread overview]
Message-ID: <87sie6qofj.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA9vRNuuUohokg4b1Pc_5g0NLJuj2BwC66=cJWC5fT53HA@mail.gmail.com> (Peter Maydell's message of "Sun, 15 Feb 2015 11:12:06 +0000")
Peter Maydell <peter.maydell@linaro.org> writes:
> On 15 February 2015 at 03:02, David Gibson <david@gibson.dropbear.id.au> wrote:
>> Godammit. Have I mentioned lately how much it pisses me off that we
>> have various config symbols and it's never clear which ones make it
>> into C and which are only in make.
>
> That does seem confusing. Is there a reason we can't have a
> config-devices.h which gets created from config-devices.mak?
Newsflash: homespun configuration system confusing, film at eleven.
(Autoconf is also confusing, but at least it's the same confusion
everywhere)
Back to serious: patching configure to make sure all the CONFIG_ make
variables make it into header files sounds good to me.
With #ifdef tests, forgetting to include the header switches things off.
A single header makes guarding against that mistake easier: every .c
needs to include it first, check with grep.
next prev parent reply other threads:[~2015-02-16 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 16:51 [Qemu-devel] Did we lose monitor commands pci_add, pci_del? Markus Armbruster
2015-02-13 22:54 ` David Gibson
2015-02-14 13:19 ` Paolo Bonzini
2015-02-15 3:02 ` David Gibson
2015-02-15 11:12 ` Peter Maydell
2015-02-16 7:57 ` Markus Armbruster [this message]
2015-02-16 10:06 ` Michael Tokarev
2015-02-16 8:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sie6qofj.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.