All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jason Wang <jasowang@redhat.com>,
	mst@redhat.com, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] virito: introduce methods of fixing device features
Date: Mon, 24 Nov 2014 11:38:13 +1030	[thread overview]
Message-ID: <87sih9xv5u.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1415857974-23326-1-git-send-email-jasowang@redhat.com>

Jason Wang <jasowang@redhat.com> writes:
> Buggy host may advertised buggy host features (a usual case is that host
> advertise a feature whose dependencies were missed). In this case, driver
> should detect and disable the buggy features by itself.

Sorry, I've been focussing elsewhere.

I would really prefer that drivers offer a "feature_depends" table,
which can indicate that feature A depends on feature B, and have the
core iterate, complain and fixup as necessary.

Is that expressive enough, or do we need more?

Thanks,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jason Wang <jasowang@redhat.com>,
	mst@redhat.com, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH 1/2] virito: introduce methods of fixing device features
Date: Mon, 24 Nov 2014 11:38:13 +1030	[thread overview]
Message-ID: <87sih9xv5u.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1415857974-23326-1-git-send-email-jasowang@redhat.com>

Jason Wang <jasowang@redhat.com> writes:
> Buggy host may advertised buggy host features (a usual case is that host
> advertise a feature whose dependencies were missed). In this case, driver
> should detect and disable the buggy features by itself.

Sorry, I've been focussing elsewhere.

I would really prefer that drivers offer a "feature_depends" table,
which can indicate that feature A depends on feature B, and have the
core iterate, complain and fixup as necessary.

Is that expressive enough, or do we need more?

Thanks,
Rusty.

  parent reply	other threads:[~2014-11-24  1:08 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13  5:52 [PATCH 1/2] virito: introduce methods of fixing device features Jason Wang
2014-11-13  5:52 ` Jason Wang
2014-11-13  5:52 ` [PATCH 2/2] virtio-net: fix buggy features advertised by host Jason Wang
2014-11-13  5:52   ` Jason Wang
2014-11-13  6:06   ` Wanlong Gao
2014-11-13  6:06     ` Wanlong Gao
2014-11-13  6:06     ` Wanlong Gao
2014-11-13  6:45     ` Jason Wang
2014-11-13  6:45       ` Jason Wang
2014-11-13  8:53   ` Cornelia Huck
2014-11-13  8:53     ` Cornelia Huck
2014-11-13  9:12     ` Jason Wang
2014-11-13  9:12       ` Jason Wang
2014-11-13  8:46 ` [PATCH 1/2] virito: introduce methods of fixing device features Cornelia Huck
2014-11-13  8:46   ` Cornelia Huck
2014-11-13  9:11   ` Jason Wang
2014-11-13  9:11     ` Jason Wang
2014-11-13  9:14     ` Cornelia Huck
2014-11-13  9:14       ` Cornelia Huck
2014-11-13  9:49       ` Jason Wang
2014-11-13  9:49         ` Jason Wang
2014-11-24  1:08 ` Rusty Russell [this message]
2014-11-24  1:08   ` Rusty Russell
2014-11-26  7:09   ` Jason Wang
2014-11-26  7:09     ` Jason Wang
  -- strict thread matches above, loose matches on Subject: below --
2014-11-13  5:24 Jason Wang
2014-11-13  5:24 ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sih9xv5u.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.