All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
Date: Thu, 23 Oct 2014 16:31:59 +0300	[thread overview]
Message-ID: <87siieq5dc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <5448DF0B.2090906@openwrt.org> (Felix Fietkau's message of "Thu,  23 Oct 2014 12:57:15 +0200")

Felix Fietkau <nbd@openwrt.org> writes:

> On 2014-10-23 09:13, Kalle Valo wrote:
>> Felix Fietkau <nbd@openwrt.org> writes:
>> 
>>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>>> ---
>>>  drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>>> index 4670930..bc440dc 100644
>>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>>  
>>>  	survey->channel = &sband->channels[idx];
>>>  
>>> +	if (ar->rx_channel == survey->channel)
>>> +		survey->filled |= SURVEY_INFO_IN_USE;
>>> +
>> 
>> Why? Does this fix a visible bug? What changes from user space point of
>> view? I'm asking because I want to add something to the commit log.
>
> When user space requests survey info, it is useful to know which of the
> survey data refers to the channel that is currently actively being used.
> One of the use cases is getting the current channel noise for status output.
> Without this flag you would have to look up the channel separately and
> then compare it against the frequency in the survey output in user space.

Perfect, thanks. I added this to the commit log in ath-next-test:

commit f7528c6fca1b2ee1899069f1066012f47586a0c8
Author: Felix Fietkau <nbd@openwrt.org>
Date:   Wed Oct 22 18:46:02 2014 +0200

    ath10k: add SURVEY_INFO_IN_USE for current channel on survey
    
    When user space requests survey info, it is useful to know which of the survey
    data refers to the channel that is currently actively being used.  One of the
    use cases is getting the current channel noise for status output.  Without this
    flag you would have to look up the channel separately and then compare it
    against the frequency in the survey output in user space.
    
    Signed-off-by: Felix Fietkau <nbd@openwrt.org>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey
Date: Thu, 23 Oct 2014 16:31:59 +0300	[thread overview]
Message-ID: <87siieq5dc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <5448DF0B.2090906@openwrt.org> (Felix Fietkau's message of "Thu, 23 Oct 2014 12:57:15 +0200")

Felix Fietkau <nbd@openwrt.org> writes:

> On 2014-10-23 09:13, Kalle Valo wrote:
>> Felix Fietkau <nbd@openwrt.org> writes:
>> 
>>> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>>> ---
>>>  drivers/net/wireless/ath/ath10k/mac.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>>> index 4670930..bc440dc 100644
>>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>>> @@ -3975,6 +3975,9 @@ static int ath10k_get_survey(struct ieee80211_hw *hw, int idx,
>>>  
>>>  	survey->channel = &sband->channels[idx];
>>>  
>>> +	if (ar->rx_channel == survey->channel)
>>> +		survey->filled |= SURVEY_INFO_IN_USE;
>>> +
>> 
>> Why? Does this fix a visible bug? What changes from user space point of
>> view? I'm asking because I want to add something to the commit log.
>
> When user space requests survey info, it is useful to know which of the
> survey data refers to the channel that is currently actively being used.
> One of the use cases is getting the current channel noise for status output.
> Without this flag you would have to look up the channel separately and
> then compare it against the frequency in the survey output in user space.

Perfect, thanks. I added this to the commit log in ath-next-test:

commit f7528c6fca1b2ee1899069f1066012f47586a0c8
Author: Felix Fietkau <nbd@openwrt.org>
Date:   Wed Oct 22 18:46:02 2014 +0200

    ath10k: add SURVEY_INFO_IN_USE for current channel on survey
    
    When user space requests survey info, it is useful to know which of the survey
    data refers to the channel that is currently actively being used.  One of the
    use cases is getting the current channel noise for status output.  Without this
    flag you would have to look up the channel separately and then compare it
    against the frequency in the survey output in user space.
    
    Signed-off-by: Felix Fietkau <nbd@openwrt.org>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

-- 
Kalle Valo

  reply	other threads:[~2014-10-23 13:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 16:46 [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey Felix Fietkau
2014-10-22 16:46 ` Felix Fietkau
2014-10-23  7:13 ` Kalle Valo
2014-10-23  7:13   ` Kalle Valo
2014-10-23 10:57   ` Felix Fietkau
2014-10-23 10:57     ` Felix Fietkau
2014-10-23 13:31     ` Kalle Valo [this message]
2014-10-23 13:31       ` Kalle Valo
2014-10-24 13:35 ` Kalle Valo
2014-10-24 13:35   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87siieq5dc.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.