From: Kevin Hilman <khilman@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Tero Kristo <t-kristo@ti.com>,
"Mark A. Greer" <mgreer@animalcreek.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] arm: omap3: pm34xx.c: Fix omap3_pm_init() error out paths
Date: Tue, 20 Mar 2012 07:02:40 -0700 [thread overview]
Message-ID: <87sjh32wvz.fsf@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203200316300.22974@utopia.booyaka.com> (Paul Walmsley's message of "Tue, 20 Mar 2012 03:17:16 -0600 (MDT)")
Paul Walmsley <paul@pwsan.com> writes:
> + Kevin
>
> On Mon, 19 Mar 2012, Tero Kristo wrote:
>
>> On Sat, 2012-03-17 at 18:22 -0700, Mark A. Greer wrote:
>> > From: "Mark A. Greer" <mgreer@animalcreek.com>
>> >
>> > It appears that the error paths were overlooked when the
>> > omap3_pm_init() routine had the prcm chain handler code
>> > added. Fix this by adding a goto target and reordering
>> > the error handling code. Also fix how the irq argument
>> > for free_irq() is determined.
>>
>> You are right, it looks like the error handling part was accidentally
>> dropped from version 7 of the prcm patch set.
>>
>> Acked-by: Tero Kristo <t-kristo@ti.com>
>>
>> Paul, you going to grab this?
>
> Kevin is the pm34xx.c maintainer, so unless he wants me to queue it, it's
> probably best for him to take it.
Yeah, I've already queued these for v3.4. (branch: for_3.4/fixes/pm)
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] arm: omap3: pm34xx.c: Fix omap3_pm_init() error out paths
Date: Tue, 20 Mar 2012 07:02:40 -0700 [thread overview]
Message-ID: <87sjh32wvz.fsf@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203200316300.22974@utopia.booyaka.com> (Paul Walmsley's message of "Tue, 20 Mar 2012 03:17:16 -0600 (MDT)")
Paul Walmsley <paul@pwsan.com> writes:
> + Kevin
>
> On Mon, 19 Mar 2012, Tero Kristo wrote:
>
>> On Sat, 2012-03-17 at 18:22 -0700, Mark A. Greer wrote:
>> > From: "Mark A. Greer" <mgreer@animalcreek.com>
>> >
>> > It appears that the error paths were overlooked when the
>> > omap3_pm_init() routine had the prcm chain handler code
>> > added. Fix this by adding a goto target and reordering
>> > the error handling code. Also fix how the irq argument
>> > for free_irq() is determined.
>>
>> You are right, it looks like the error handling part was accidentally
>> dropped from version 7 of the prcm patch set.
>>
>> Acked-by: Tero Kristo <t-kristo@ti.com>
>>
>> Paul, you going to grab this?
>
> Kevin is the pm34xx.c maintainer, so unless he wants me to queue it, it's
> probably best for him to take it.
Yeah, I've already queued these for v3.4. (branch: for_3.4/fixes/pm)
Kevin
next prev parent reply other threads:[~2012-03-20 14:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 1:22 [PATCH v3 0/2] arm: omap3: pm34xx.c: Some minor fixups Mark A. Greer
2012-03-18 1:22 ` Mark A. Greer
2012-03-18 1:22 ` [PATCH v3 1/2] arm: omap3: pm34xx.c: Fix omap3_pm_init() error out paths Mark A. Greer
2012-03-18 1:22 ` Mark A. Greer
2012-03-19 9:48 ` Tero Kristo
2012-03-19 9:48 ` Tero Kristo
2012-03-20 9:17 ` Paul Walmsley
2012-03-20 9:17 ` Paul Walmsley
2012-03-20 14:02 ` Kevin Hilman [this message]
2012-03-20 14:02 ` Kevin Hilman
2012-03-18 1:22 ` [PATCH v3 2/2] arm: omap3: pm34xx.c: Replace printk() with appropriate pr_*() Mark A. Greer
2012-03-18 1:22 ` Mark A. Greer
2012-03-19 21:43 ` [PATCH v3 0/2] arm: omap3: pm34xx.c: Some minor fixups Kevin Hilman
2012-03-19 21:43 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjh32wvz.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.