All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Omar Ramirez Luna <omar.ramirez@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Benoit Cousson <b-cousson@ti.com>,
	Russell King <linux@arm.linux.org.uk>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Ohad Ben-Cohen <ohad@wizery.com>, lo <linux-omap@vger.kernel.org>,
	lak <linux-arm-kernel@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	lm <linux-media@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp
Date: Fri, 04 Nov 2011 16:23:24 -0700	[thread overview]
Message-ID: <87sjm31ngz.fsf@ti.com> (raw)
In-Reply-To: <1320185752-568-3-git-send-email-omar.ramirez@ti.com> (Omar Ramirez Luna's message of "Tue, 1 Nov 2011 17:15:50 -0500")

Omar Ramirez Luna <omar.ramirez@ti.com> writes:

> Add mmu hwmod data for ipu and dsp.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>

[...]

> +static struct omap_hwmod omap44xx_ipu_mmu_hwmod = {
> +	.name		= "ipu_mmu",
> +	.class		= &omap44xx_mmu_hwmod_class,
> +	.mpu_irqs	= omap44xx_ipu_mmu_irqs,
> +	.rst_lines	= omap44xx_ipu_mmu_resets,
> +	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_ipu_mmu_resets),
> +	.main_clk	= "ipu_fck",
> +	.prcm = {
> +		.omap4 = {
> +			.rstctrl_offs = OMAP4_RM_DUCATI_RSTCTRL_OFFSET,
> +		},
> +	},
> +	.dev_attr	= &ipu_mmu_dev_attr,
> +	.slaves		= omap44xx_ipu_mmu_slaves,
> +	.slaves_cnt	= ARRAY_SIZE(omap44xx_ipu_mmu_slaves),
> +	.flags		= HWMOD_INIT_NO_RESET,

Why is this needed?

[...]

> +static struct omap_hwmod omap44xx_dsp_mmu_hwmod = {
> +	.name		= "dsp_mmu",
> +	.class		= &omap44xx_mmu_hwmod_class,
> +	.mpu_irqs	= omap44xx_dsp_mmu_irqs,
> +	.rst_lines	= omap44xx_dsp_mmu_resets,
> +	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_dsp_mmu_resets),
> +	.main_clk	= "dsp_fck",
> +	.prcm = {
> +		.omap4 = {
> +			.rstctrl_offs = OMAP4_RM_TESLA_RSTCTRL_OFFSET,
> +		},
> +	},
> +	.dev_attr	= &dsp_mmu_dev_attr,
> +	.slaves		= omap44xx_dsp_mmu_slaves,
> +	.slaves_cnt	= ARRAY_SIZE(omap44xx_dsp_mmu_slaves),
> +	.flags		= HWMOD_INIT_NO_RESET,

And this?

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp
Date: Fri, 04 Nov 2011 16:23:24 -0700	[thread overview]
Message-ID: <87sjm31ngz.fsf@ti.com> (raw)
In-Reply-To: <1320185752-568-3-git-send-email-omar.ramirez@ti.com> (Omar Ramirez Luna's message of "Tue, 1 Nov 2011 17:15:50 -0500")

Omar Ramirez Luna <omar.ramirez@ti.com> writes:

> Add mmu hwmod data for ipu and dsp.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>

[...]

> +static struct omap_hwmod omap44xx_ipu_mmu_hwmod = {
> +	.name		= "ipu_mmu",
> +	.class		= &omap44xx_mmu_hwmod_class,
> +	.mpu_irqs	= omap44xx_ipu_mmu_irqs,
> +	.rst_lines	= omap44xx_ipu_mmu_resets,
> +	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_ipu_mmu_resets),
> +	.main_clk	= "ipu_fck",
> +	.prcm = {
> +		.omap4 = {
> +			.rstctrl_offs = OMAP4_RM_DUCATI_RSTCTRL_OFFSET,
> +		},
> +	},
> +	.dev_attr	= &ipu_mmu_dev_attr,
> +	.slaves		= omap44xx_ipu_mmu_slaves,
> +	.slaves_cnt	= ARRAY_SIZE(omap44xx_ipu_mmu_slaves),
> +	.flags		= HWMOD_INIT_NO_RESET,

Why is this needed?

[...]

> +static struct omap_hwmod omap44xx_dsp_mmu_hwmod = {
> +	.name		= "dsp_mmu",
> +	.class		= &omap44xx_mmu_hwmod_class,
> +	.mpu_irqs	= omap44xx_dsp_mmu_irqs,
> +	.rst_lines	= omap44xx_dsp_mmu_resets,
> +	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_dsp_mmu_resets),
> +	.main_clk	= "dsp_fck",
> +	.prcm = {
> +		.omap4 = {
> +			.rstctrl_offs = OMAP4_RM_TESLA_RSTCTRL_OFFSET,
> +		},
> +	},
> +	.dev_attr	= &dsp_mmu_dev_attr,
> +	.slaves		= omap44xx_dsp_mmu_slaves,
> +	.slaves_cnt	= ARRAY_SIZE(omap44xx_dsp_mmu_slaves),
> +	.flags		= HWMOD_INIT_NO_RESET,

And this?

Kevin

  reply	other threads:[~2011-11-04 23:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 22:15 [PATCH v3 0/4] OMAP: iommu: hwmod support and runtime PM Omar Ramirez Luna
2011-11-01 22:15 ` Omar Ramirez Luna
2011-11-01 22:15 ` [PATCH v3 1/4] OMAP3: hwmod data: add mmu data for iva and isp Omar Ramirez Luna
2011-11-01 22:15   ` Omar Ramirez Luna
2011-11-01 22:15 ` [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp Omar Ramirez Luna
2011-11-01 22:15   ` Omar Ramirez Luna
2011-11-04 23:23   ` Kevin Hilman [this message]
2011-11-04 23:23     ` Kevin Hilman
2011-11-08 16:21     ` Ramirez Luna, Omar
2011-11-08 16:21       ` Ramirez Luna, Omar
2011-11-08 17:41       ` Kevin Hilman
2011-11-08 17:41         ` Kevin Hilman
2011-11-08 17:41         ` Kevin Hilman
2011-11-01 22:15 ` [PATCH v3 3/4] OMAP3/4: iommu: migrate to hwmod framework Omar Ramirez Luna
2011-11-01 22:15   ` Omar Ramirez Luna
2011-11-01 22:15 ` [PATCH v3 4/4] OMAP3/4: iommu: adapt to runtime pm Omar Ramirez Luna
2011-11-01 22:15   ` Omar Ramirez Luna
2011-11-02 10:16   ` MyungJoo Ham
2011-11-02 10:16     ` MyungJoo Ham
2011-11-02 10:16     ` MyungJoo Ham
2011-11-02 15:22     ` Ramirez Luna, Omar
2011-11-02 15:22       ` Ramirez Luna, Omar
2011-11-02 15:22       ` Ramirez Luna, Omar
2011-11-02 15:21   ` Russell King - ARM Linux
2011-11-02 15:21     ` Russell King - ARM Linux
2011-11-02 15:24     ` Ramirez Luna, Omar
2011-11-02 15:24       ` Ramirez Luna, Omar
2011-11-04 23:27   ` Kevin Hilman
2011-11-04 23:27     ` Kevin Hilman
2011-11-04 23:27     ` Kevin Hilman
2011-11-07 18:21     ` Ramirez Luna, Omar
2011-11-07 18:21       ` Ramirez Luna, Omar
2011-11-02 14:56 ` [PATCH v3 0/4] OMAP: iommu: hwmod support and runtime PM Ramirez Luna, Omar
2011-11-02 14:56   ` Ramirez Luna, Omar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjm31ngz.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=b-cousson@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=ohad@wizery.com \
    --cc=omar.ramirez@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.