From: Ben Gamari <bgamari.foss@gmail.com>
To: tony@atomide.com
Cc: linux-omap@vger.kernel.org, manjugk@ti.com,
santosh.shilimkar@ti.com, khilman@deeprootsystems.com,
linux-arm-kernel@vger.kernel.org
Subject: Re: [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER
Date: Thu, 23 Dec 2010 21:43:18 -0500 [thread overview]
Message-ID: <87sjxnx54p.fsf@gmail.com> (raw)
In-Reply-To: <1293127631-764-2-git-send-email-bgamari.foss@gmail.com>
It appears that arch/arm/mach-omap2/timer-gp.o is needed by OMAP2PLUS.
Since timer-gp.o has direct dependencies on omap_dm_timer_*, it seems
correct for the architecture to depend upon OMAP_DM_TIMER, otherwise
unsuspecting integrators will be faced with a whole bunch of linker
errors at the end of their kernel build:
arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to `omap_dm_timer_stop'
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to `omap_dm_timer_get_fclk'
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
...
---
arch/arm/plat-omap/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index 92c5bb7..784c06c 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -18,6 +18,7 @@ config ARCH_OMAP1
config ARCH_OMAP2PLUS
bool "TI OMAP2/3/4"
select COMMON_CLKDEV
+ select OMAP_DM_TIMER
help
"Systems based on OMAP2, OMAP3 or OMAP4"
--
1.7.0.4
next prev parent reply other threads:[~2010-12-24 2:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 18:07 Status of CONFIG_OMAP_DM_TIMER Ben Gamari
2010-12-23 18:07 ` [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER Ben Gamari
2010-12-23 20:49 ` Tony Lindgren
2010-12-24 2:53 ` Ben Gamari
2010-12-24 2:43 ` Ben Gamari [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-24 2:48 Ben Gamari
2010-12-24 2:48 ` Ben Gamari
2010-12-24 17:39 ` Tony Lindgren
2010-12-24 17:39 ` Tony Lindgren
2010-12-24 17:53 ` Ben Gamari
2010-12-24 17:53 ` Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjxnx54p.fsf@gmail.com \
--to=bgamari.foss@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.