All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Ben Gamari <bgamari.foss@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER
Date: Fri, 24 Dec 2010 09:39:13 -0800	[thread overview]
Message-ID: <20101224173912.GV7771@atomide.com> (raw)
In-Reply-To: <1293158889-9708-1-git-send-email-bgamari.foss@gmail.com>

* Ben Gamari <bgamari.foss@gmail.com> [101223 18:48]:
> It appears that arch/arm/mach-omap2/timer-gp.o is needed by OMAP2PLUS.
> Since timer-gp.o has direct dependencies on omap_dm_timer_*, it seems
> correct for the architecture to depend upon OMAP_DM_TIMER, otherwise
> unsuspecting integrators will be faced with a whole bunch of linker
> errors at the end of their kernel build:
> 
> arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to `omap_dm_timer_stop'
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to `omap_dm_timer_get_fclk'
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
> ...

One more thing.. Can you please reply with your
Signed-off-by: line so this can be applied?

Thanks

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER
Date: Fri, 24 Dec 2010 09:39:13 -0800	[thread overview]
Message-ID: <20101224173912.GV7771@atomide.com> (raw)
In-Reply-To: <1293158889-9708-1-git-send-email-bgamari.foss@gmail.com>

* Ben Gamari <bgamari.foss@gmail.com> [101223 18:48]:
> It appears that arch/arm/mach-omap2/timer-gp.o is needed by OMAP2PLUS.
> Since timer-gp.o has direct dependencies on omap_dm_timer_*, it seems
> correct for the architecture to depend upon OMAP_DM_TIMER, otherwise
> unsuspecting integrators will be faced with a whole bunch of linker
> errors at the end of their kernel build:
> 
> arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to `omap_dm_timer_stop'
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to `omap_dm_timer_get_fclk'
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
> ...

One more thing.. Can you please reply with your
Signed-off-by: line so this can be applied?

Thanks

Tony

  reply	other threads:[~2010-12-24 17:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-24  2:48 [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER Ben Gamari
2010-12-24  2:48 ` Ben Gamari
2010-12-24 17:39 ` Tony Lindgren [this message]
2010-12-24 17:39   ` Tony Lindgren
2010-12-24 17:53   ` Ben Gamari
2010-12-24 17:53     ` Ben Gamari
  -- strict thread matches above, loose matches on Subject: below --
2010-12-23 18:07 Status of CONFIG_OMAP_DM_TIMER Ben Gamari
2010-12-23 18:07 ` [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER Ben Gamari
2010-12-23 20:49   ` Tony Lindgren
2010-12-24  2:53     ` Ben Gamari
2010-12-24  2:43   ` Ben Gamari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101224173912.GV7771@atomide.com \
    --to=tony@atomide.com \
    --cc=bgamari.foss@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.