From: Kevin Hilman <khilman@deeprootsystems.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tom.leiming@gmail.com, pramod.gurav@ti.com,
thomas.petazzoni@free-electrons.com, jean.pihet@newoldbits.com,
govindraj.raja@ti.com
Subject: Re: OMAP2+: PM/serial: hold console semaphore while OMAP UARTs are disabled
Date: Tue, 07 Dec 2010 12:59:51 -0800 [thread overview]
Message-ID: <87sjy9l2ns.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20101125005923.GE31536@atomide.com> (Tony Lindgren's message of "Wed, 24 Nov 2010 16:59:23 -0800")
Tony Lindgren <tony@atomide.com> writes:
> * Kevin Hilman <khilman@deeprootsystems.com> [101124 16:32]:
>> Paul Walmsley <paul@pwsan.com> writes:
>
> <snip>
>
>> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
>>
>> Very nice. I've been exploring various solutions to this problem as
>> well, but this one is much cleaner. Also, I hadn't discovered the 'try'
>> version of the console semaphore, so was running into recursive locking.
>>
>> Anyways, tested on omap35xx: omap3evm (uart1/core console) and beagle
>> (uart3/per console) and omap34xx/n900 (uart3/per console) using both
>> retention-idle and off-idle.
>
> Thanks, queuing this as fix for the -rc cycle.
FYI.. just found a regression caused by this patch. It prevented
suspend from ever happening since the console semaphore is already held
during suspend.
Just posted a fix for this:
Date: Tue, 7 Dec 2010 12:24:13 -0800
Subject: [PATCH] OMAP2+: PM/serial: fix console semaphore acquire during suspend
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP2+: PM/serial: hold console semaphore while OMAP UARTs are disabled
Date: Tue, 07 Dec 2010 12:59:51 -0800 [thread overview]
Message-ID: <87sjy9l2ns.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20101125005923.GE31536@atomide.com> (Tony Lindgren's message of "Wed, 24 Nov 2010 16:59:23 -0800")
Tony Lindgren <tony@atomide.com> writes:
> * Kevin Hilman <khilman@deeprootsystems.com> [101124 16:32]:
>> Paul Walmsley <paul@pwsan.com> writes:
>
> <snip>
>
>> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
>>
>> Very nice. I've been exploring various solutions to this problem as
>> well, but this one is much cleaner. Also, I hadn't discovered the 'try'
>> version of the console semaphore, so was running into recursive locking.
>>
>> Anyways, tested on omap35xx: omap3evm (uart1/core console) and beagle
>> (uart3/per console) and omap34xx/n900 (uart3/per console) using both
>> retention-idle and off-idle.
>
> Thanks, queuing this as fix for the -rc cycle.
FYI.. just found a regression caused by this patch. It prevented
suspend from ever happening since the console semaphore is already held
during suspend.
Just posted a fix for this:
Date: Tue, 7 Dec 2010 12:24:13 -0800
Subject: [PATCH] OMAP2+: PM/serial: fix console semaphore acquire during suspend
Kevin
next prev parent reply other threads:[~2010-12-07 20:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 23:49 OMAP2+: PM/serial: hold console semaphore while OMAP UARTs are disabled Paul Walmsley
2010-11-24 23:49 ` Paul Walmsley
2010-11-25 0:42 ` Kevin Hilman
2010-11-25 0:42 ` Kevin Hilman
2010-11-25 0:59 ` Tony Lindgren
2010-11-25 0:59 ` Tony Lindgren
2010-12-07 20:59 ` Kevin Hilman [this message]
2010-12-07 20:59 ` Kevin Hilman
2010-11-25 16:47 ` Jean Pihet
2010-11-25 16:47 ` Jean Pihet
2010-11-25 17:35 ` Paul Walmsley
2010-11-25 17:35 ` Paul Walmsley
2010-11-25 18:38 ` Jean Pihet
2010-11-25 18:38 ` Jean Pihet
2010-12-02 7:23 ` Paul Walmsley
2010-12-02 7:23 ` Paul Walmsley
2010-12-02 15:12 ` Jean Pihet
2010-12-02 15:12 ` Jean Pihet
2010-12-04 1:10 ` Paul Walmsley
2010-12-04 1:10 ` Paul Walmsley
2010-11-25 18:15 ` Paul Walmsley
2010-11-25 18:15 ` Paul Walmsley
2010-11-25 18:38 ` Jean Pihet
2010-11-25 18:38 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjy9l2ns.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=govindraj.raja@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=pramod.gurav@ti.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tom.leiming@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.