From: Eric Anholt <eric@anholt.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix errata for sync flush enable on 845G/830M
Date: Mon, 09 Aug 2010 14:10:20 -0700 [thread overview]
Message-ID: <87sk2nlcg3.fsf@pollan.anholt.net> (raw)
In-Reply-To: <89k77n$ojogje@fmsmga001.fm.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 707 bytes --]
On Mon, 09 Aug 2010 18:04:50 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Mon, 9 Aug 2010 09:45:38 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Is this hack even needed? I noticed on my 945GM that INSTDONE has a
> > stuck bit when I use this code, removing it didn't seem to have any
> > negative effects...
>
> I'm not sure why we need to trigger a Sync on the GPU at this point, I
> just assumed it was one of those magic bits of code required to bring up
> the hardware.
Beginning a sync flush and continuing without waiting for the sync flush
to actually complete looks awfully bogus to me. In the absence of
justification, I'd lean towards nuking this code.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2010-08-09 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 18:39 [PATCH] drm/i915: fix errata for sync flush enable on 845G/830M Chris Wilson
2010-08-09 16:45 ` Jesse Barnes
2010-08-09 17:04 ` Chris Wilson
2010-08-09 21:10 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sk2nlcg3.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.