All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miles Bader <miles@gnu.org>
To: git@vger.kernel.org
Subject: Re: [PATCH 4/5 v4] log: parse detached options like git log --grep foo
Date: Wed, 04 Aug 2010 11:41:03 +0900	[thread overview]
Message-ID: <87sk2v14n4.fsf@catnip.gol.com> (raw)
In-Reply-To: 7vlj8nipl9.fsf@alter.siamese.dyndns.org

Junio C Hamano <gitster@pobox.com> writes:
> this---the users won't miss the "--opt <string>" feature because that is
> not a common practice.
>
> And I was agreeing to that.

No, that would be not good -- GNU getopt_long supports that form, and
AFAICT, both the "--foo=bar" and "--foo bar" forms are widely used (I
certainly use both all the time), for roughly the same reasons both
"-Oarg" and "-O arg" are both common[*].

In the case of "optional-argument options", the "--foo bar" (and "-O
bar") form doesn't work, which is an unfortunate (but apparently
unavoidable) inconsistency, but optional-argument options are rare
enough that this doesn't really effect the usage patterns of more
conventional options.

[*] both forms are useful -- sometimes it's handy to bundle up the
option-argument with the option, e.g., when writing a throw-away script,
to avoid whitespace issues, but sometimes it's useful to keep it
separate, e.g. so that shell filename completion works on the
option-argument.

-Miles

-- 
Justice, n. A commodity which in a more or less adulterated condition the
State sells to the citizen as a reward for his allegiance, taxes and personal
service.

  parent reply	other threads:[~2010-08-04  2:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29  8:20 [PATCH 0/5 v3] log and diff: accept detached forms (--option value) Matthieu Moy
2010-07-29  8:20 ` [PATCH 1/5] diff: parse detached options like -S foo Matthieu Moy
2010-07-29  8:20 ` [PATCH 2/5] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-29  8:20 ` [PATCH 3/5] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-07-29  8:20 ` [PATCH 4/5] log: parse detached options like git log --grep foo Matthieu Moy
2010-07-29 22:25   ` Jonathan Nieder
2010-07-30  8:27     ` Matthieu Moy
2010-07-30  8:31       ` [PATCH 1/5 v4] diff: parse detached options like -S foo Matthieu Moy
2010-08-02 16:46         ` Junio C Hamano
2010-08-02 19:43           ` Matthieu Moy
2010-08-02 19:47           ` Jonathan Nieder
2010-07-30  8:31       ` [PATCH 2/5 v4] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-30  8:31       ` [PATCH 3/5 v4] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-08-02 16:56         ` Junio C Hamano
2010-08-02 18:47           ` Matthieu Moy
2010-07-30  8:31       ` [PATCH 4/5 v4] log: parse detached options like git log --grep foo Matthieu Moy
2010-08-02 17:03         ` Junio C Hamano
2010-08-02 18:55           ` Matthieu Moy
2010-08-02 21:28             ` Junio C Hamano
2010-08-03  6:33               ` Matthieu Moy
2010-08-03 17:16                 ` Junio C Hamano
2010-08-03 19:52                   ` Matthieu Moy
2010-08-04  2:41                   ` Miles Bader [this message]
2010-07-30  8:31       ` [PATCH 5/5 v4] log: parse detached option for --glob Matthieu Moy
2010-07-29  8:20 ` [PATCH 5/5] " Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sk2v14n4.fsf@catnip.gol.com \
    --to=miles@gnu.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.