From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/5 v4] log: parse detached options like git log --grep foo
Date: Mon, 02 Aug 2010 20:55:23 +0200 [thread overview]
Message-ID: <vpqtyncdeuc.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vvd7tlzfu.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon\, 02 Aug 2010 10\:03\:17 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> The patch overall looks good, and this comments illustrates the issue
> rather well. When the user wants to use "--longopt val" syntax, s/he
> needs to know that "--longopt" will always take a value. Arguably
> majority of options that can take value will, but like "--stat X,Y" this
> leaves things inconsistent. Without "--longopt value" patch there won't
> be such an inconsistency, but I think this patch series is lessor of two
> evils.
... especially when parse-option already does this:
git commit --message foo => works
git gc --prune 'last week' => doesn't
Just like most GNU tools:
grep --regexp foo => works
grep --color auto => doesn't
> Don't you by the way regret the naming of the parsing function by now?
> There is nothing "diff" about it anymore.
Right. I'll rename them to "parse_long_opt".
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-08-02 18:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 8:20 [PATCH 0/5 v3] log and diff: accept detached forms (--option value) Matthieu Moy
2010-07-29 8:20 ` [PATCH 1/5] diff: parse detached options like -S foo Matthieu Moy
2010-07-29 8:20 ` [PATCH 2/5] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-29 8:20 ` [PATCH 3/5] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-07-29 8:20 ` [PATCH 4/5] log: parse detached options like git log --grep foo Matthieu Moy
2010-07-29 22:25 ` Jonathan Nieder
2010-07-30 8:27 ` Matthieu Moy
2010-07-30 8:31 ` [PATCH 1/5 v4] diff: parse detached options like -S foo Matthieu Moy
2010-08-02 16:46 ` Junio C Hamano
2010-08-02 19:43 ` Matthieu Moy
2010-08-02 19:47 ` Jonathan Nieder
2010-07-30 8:31 ` [PATCH 2/5 v4] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-30 8:31 ` [PATCH 3/5 v4] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-08-02 16:56 ` Junio C Hamano
2010-08-02 18:47 ` Matthieu Moy
2010-07-30 8:31 ` [PATCH 4/5 v4] log: parse detached options like git log --grep foo Matthieu Moy
2010-08-02 17:03 ` Junio C Hamano
2010-08-02 18:55 ` Matthieu Moy [this message]
2010-08-02 21:28 ` Junio C Hamano
2010-08-03 6:33 ` Matthieu Moy
2010-08-03 17:16 ` Junio C Hamano
2010-08-03 19:52 ` Matthieu Moy
2010-08-04 2:41 ` Miles Bader
2010-07-30 8:31 ` [PATCH 5/5 v4] log: parse detached option for --glob Matthieu Moy
2010-07-29 8:20 ` [PATCH 5/5] " Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqtyncdeuc.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.