* [StGit PATCH] Don't print unnecessary backtraces when testing
@ 2007-08-17 11:36 David Kågedal
0 siblings, 0 replies; only message in thread
From: David Kågedal @ 2007-08-17 11:36 UTC (permalink / raw)
To: git; +Cc: Catalin Marinas
When stg fails, and handles it properly, no backtrace should be printed,
even when running tests with -v. Getting a backtrace in the output signals
some kind of bug, but in this case there is no bug.
---
I was running tests with -v and saw python backtraces, and assumed
that there was a bug somewhere. But apparently this backtrace only
appeared when running tests.
I think it's better if you only get backtraces when something actually
went wrong. The test driver sets the debug level to -1, so I changed
the check to check for positive instead.
stgit/main.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/stgit/main.py b/stgit/main.py
index 294b703..2390110 100644
--- a/stgit/main.py
+++ b/stgit/main.py
@@ -286,7 +286,7 @@ def main():
StackException, GitException, GitMergeException,
EditorException), err:
print >> sys.stderr, '%s %s: %s' % (prog, cmd, err)
- if debug_level:
+ if debug_level > 0:
raise
else:
sys.exit(2)
--
1.5.3.rc3.119.g1812
--
David Kågedal
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-17 11:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-17 11:36 [StGit PATCH] Don't print unnecessary backtraces when testing David Kågedal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.