* [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target()
2026-08-27 11:20 [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin() Muhammad Falak R Wani
@ 2026-08-27 11:20 ` Muhammad Falak R Wani
2026-08-27 14:09 ` Dave Marquardt
2026-08-27 19:29 ` Tyrel Datwyler
2026-08-27 14:08 ` [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin() Dave Marquardt
` (3 subsequent siblings)
4 siblings, 2 replies; 8+ messages in thread
From: Muhammad Falak R Wani @ 2026-08-27 11:20 UTC (permalink / raw)
To: Tyrel Datwyler, Martin K. Petersen, James E.J. Bottomley
Cc: linux-scsi, linux-kernel, kernel test robot, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy, linuxppc-dev
Commit 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol")
added a protocol parameter to ibmvfc_alloc_target() but did not describe
it in the function's kernel-doc comment, so a W=1 build warns:
drivers/scsi/ibmvscsi/ibmvfc-core.c:4996: warning: Function parameter
or struct member 'protocol' not described in 'ibmvfc_alloc_target'
Add the missing parameter description.
Fixes: 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202608270829.lHI1FAdO-lkp@intel.com/
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/scsi/ibmvscsi/ibmvfc-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c
index d1956552698e0..6fd4c601f978c 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc-core.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c
@@ -4987,6 +4987,7 @@ static void ibmvfc_tgt_query_target(struct ibmvfc_target *tgt)
* ibmvfc_alloc_target - Allocate and initialize an ibmvfc target
* @vhost: ibmvfc host struct
* @target: Holds SCSI ID to allocate target forand the WWPN
+ * @protocol: protocol of the target to allocate
*
* Returns:
* 0 on success / other on failure
--
2.55.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target()
2026-08-27 11:20 ` [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target() Muhammad Falak R Wani
@ 2026-08-27 14:09 ` Dave Marquardt
2026-08-27 19:29 ` Tyrel Datwyler
1 sibling, 0 replies; 8+ messages in thread
From: Dave Marquardt @ 2026-08-27 14:09 UTC (permalink / raw)
To: Muhammad Falak R Wani
Cc: Tyrel Datwyler, Martin K. Petersen, James E.J. Bottomley,
linux-scsi, linux-kernel, kernel test robot, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy, linuxppc-dev
Muhammad Falak R Wani <falakreyaz@gmail.com> writes:
> Commit 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol")
> added a protocol parameter to ibmvfc_alloc_target() but did not describe
> it in the function's kernel-doc comment, so a W=1 build warns:
>
> drivers/scsi/ibmvscsi/ibmvfc-core.c:4996: warning: Function parameter
> or struct member 'protocol' not described in 'ibmvfc_alloc_target'
>
> Add the missing parameter description.
>
> Fixes: 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202608270829.lHI1FAdO-lkp@intel.com/
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/scsi/ibmvscsi/ibmvfc-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> index d1956552698e0..6fd4c601f978c 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> @@ -4987,6 +4987,7 @@ static void ibmvfc_tgt_query_target(struct ibmvfc_target *tgt)
> * ibmvfc_alloc_target - Allocate and initialize an ibmvfc target
> * @vhost: ibmvfc host struct
> * @target: Holds SCSI ID to allocate target forand the WWPN
> + * @protocol: protocol of the target to allocate
> *
> * Returns:
> * 0 on success / other on failure
Reviewed-by: Dave Marquardt <davemarq@linux.ibm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target()
2026-08-27 11:20 ` [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target() Muhammad Falak R Wani
2026-08-27 14:09 ` Dave Marquardt
@ 2026-08-27 19:29 ` Tyrel Datwyler
1 sibling, 0 replies; 8+ messages in thread
From: Tyrel Datwyler @ 2026-08-27 19:29 UTC (permalink / raw)
To: Muhammad Falak R Wani, Martin K. Petersen, James E.J. Bottomley
Cc: linux-scsi, linux-kernel, kernel test robot, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy, linuxppc-dev
On 8/27/26 4:20 AM, Muhammad Falak R Wani wrote:
> Commit 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol")
> added a protocol parameter to ibmvfc_alloc_target() but did not describe
> it in the function's kernel-doc comment, so a W=1 build warns:
>
> drivers/scsi/ibmvscsi/ibmvfc-core.c:4996: warning: Function parameter
> or struct member 'protocol' not described in 'ibmvfc_alloc_target'
>
> Add the missing parameter description.
>
> Fixes: 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202608270829.lHI1FAdO-lkp@intel.com/
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin()
2026-08-27 11:20 [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin() Muhammad Falak R Wani
2026-08-27 11:20 ` [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target() Muhammad Falak R Wani
@ 2026-08-27 14:08 ` Dave Marquardt
2026-08-27 19:28 ` Tyrel Datwyler
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Dave Marquardt @ 2026-08-27 14:08 UTC (permalink / raw)
To: Muhammad Falak R Wani
Cc: Tyrel Datwyler, Martin K. Petersen, James E.J. Bottomley,
linux-scsi, linux-kernel, kernel test robot, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy, linuxppc-dev
Muhammad Falak R Wani <falakreyaz@gmail.com> writes:
> Commit e0fca728a89f ("scsi: ibmvfc: delete NVMe/FC targets as well as
> SCSI") renamed ibmvfc_relogin() to ibmvfc_scsi_relogin() but left the
> kernel-doc comment referring to the old name, so a W=1 build warns:
>
> drivers/scsi/ibmvscsi/ibmvfc-core.c:1901: warning: expecting prototype
> for ibmvfc_relogin(). Prototype was for ibmvfc_scsi_relogin() instead
>
> Update the kernel-doc comment to use the current function name.
>
> Fixes: e0fca728a89f ("scsi: ibmvfc: delete NVMe/FC targets as well as SCSI")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202608271026.iMLmrwz4-lkp@intel.com/
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/scsi/ibmvscsi/ibmvfc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> index 93b9f699c2e53..d1956552698e0 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> @@ -1894,7 +1894,7 @@ static void ibmvfc_log_error(struct ibmvfc_event *evt)
> }
>
> /**
> - * ibmvfc_relogin - Log back into the specified device
> + * ibmvfc_scsi_relogin - Log back into the specified device
> * @sdev: scsi device struct
> *
> **/
Reviewed-by: Dave Marquardt <davemarq@linux.ibm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin()
2026-08-27 11:20 [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin() Muhammad Falak R Wani
2026-08-27 11:20 ` [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target() Muhammad Falak R Wani
2026-08-27 14:08 ` [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin() Dave Marquardt
@ 2026-08-27 19:28 ` Tyrel Datwyler
2026-08-29 1:38 ` Martin K. Petersen (Oracle)
2026-09-03 3:10 ` Martin K. Petersen (Oracle)
4 siblings, 0 replies; 8+ messages in thread
From: Tyrel Datwyler @ 2026-08-27 19:28 UTC (permalink / raw)
To: Muhammad Falak R Wani, Martin K. Petersen, James E.J. Bottomley
Cc: linux-scsi, linux-kernel, kernel test robot, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy, linuxppc-dev
On 8/27/26 4:20 AM, Muhammad Falak R Wani wrote:
> Commit e0fca728a89f ("scsi: ibmvfc: delete NVMe/FC targets as well as
> SCSI") renamed ibmvfc_relogin() to ibmvfc_scsi_relogin() but left the
> kernel-doc comment referring to the old name, so a W=1 build warns:
>
> drivers/scsi/ibmvscsi/ibmvfc-core.c:1901: warning: expecting prototype
> for ibmvfc_relogin(). Prototype was for ibmvfc_scsi_relogin() instead
>
> Update the kernel-doc comment to use the current function name.
>
> Fixes: e0fca728a89f ("scsi: ibmvfc: delete NVMe/FC targets as well as SCSI")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202608271026.iMLmrwz4-lkp@intel.com/
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin()
2026-08-27 11:20 [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin() Muhammad Falak R Wani
` (2 preceding siblings ...)
2026-08-27 19:28 ` Tyrel Datwyler
@ 2026-08-29 1:38 ` Martin K. Petersen (Oracle)
2026-09-03 3:10 ` Martin K. Petersen (Oracle)
4 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen (Oracle) @ 2026-08-29 1:38 UTC (permalink / raw)
To: Muhammad Falak R Wani
Cc: Tyrel Datwyler, Martin K. Petersen, James E.J. Bottomley,
linux-scsi, linux-kernel, kernel test robot, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy, linuxppc-dev
> Commit e0fca728a89f ("scsi: ibmvfc: delete NVMe/FC targets as well as
> SCSI") renamed ibmvfc_relogin() to ibmvfc_scsi_relogin() but left the
> kernel-doc comment referring to the old name, so a W=1 build warns:
Applied to 7.3/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin()
2026-08-27 11:20 [PATCH 1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin() Muhammad Falak R Wani
` (3 preceding siblings ...)
2026-08-29 1:38 ` Martin K. Petersen (Oracle)
@ 2026-09-03 3:10 ` Martin K. Petersen (Oracle)
4 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen (Oracle) @ 2026-09-03 3:10 UTC (permalink / raw)
To: Tyrel Datwyler, James E.J. Bottomley, Martin K. Petersen,
Muhammad Falak R Wani
Cc: linux-scsi, linux-kernel, kernel test robot, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, linuxppc-dev, Christophe Leroy
On Thu, 27 Aug 2026 16:50:37 +0530, Muhammad Falak R Wani wrote:
> Commit e0fca728a89f ("scsi: ibmvfc: delete NVMe/FC targets as well as
> SCSI") renamed ibmvfc_relogin() to ibmvfc_scsi_relogin() but left the
> kernel-doc comment referring to the old name, so a W=1 build warns:
>
> drivers/scsi/ibmvscsi/ibmvfc-core.c:1901: warning: expecting prototype
> for ibmvfc_relogin(). Prototype was for ibmvfc_scsi_relogin() instead
>
> [...]
Applied to 7.3/scsi-fixes, thanks!
[1/2] scsi: ibmvfc: fix kernel-doc name for ibmvfc_scsi_relogin()
https://git.kernel.org/mkp/scsi/c/9a0716348daf
[2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target()
https://git.kernel.org/mkp/scsi/c/9a69cc5f192f
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 8+ messages in thread