Re: [PATCH i-g-t v2 2/3] lib: Add Crescent Island Support

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 06 Nov 2025 07:34:18 -0800, Shekhar Chauhan wrote:
>
> From: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>
> Add device info for Crescent Island (CRI).
>
> v2: Fix indentation/spacing for CrescentIsland in lib/intel_chipset.h
> (Kamil)
>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> ---
>  lib/intel_chipset.h     |  2 ++
>  lib/intel_device_info.c | 10 ++++++++++
>  2 files changed, 12 insertions(+)
>
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index 70ea78464..7739f4a84 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -94,6 +94,7 @@ struct intel_device_info {
>	bool is_battlemage : 1;
>	bool is_pantherlake : 1;
>	bool is_novalake: 1;
> +	bool is_crescentisland: 1;
>
>	const struct intel_cmds_info *cmds_info;
>	const char *codename;
> @@ -212,6 +213,7 @@ void intel_check_pch(void);
>  #define IS_BATTLEMAGE(devid)	(intel_get_device_info(devid)->is_battlemage)
>  #define IS_PANTHERLAKE(devid)	(intel_get_device_info(devid)->is_pantherlake)
>  #define IS_NOVALAKE(devid)	(intel_get_device_info(devid)->is_novalake)
> +#define IS_CRESCENTISLAND(devid)	(intel_get_device_info(devid)->is_crescentisland)
>
>  #define IS_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver == x)
>
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index fe452d50f..bb36c6968 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -549,6 +549,14 @@ static const struct intel_device_info intel_novalake_info = {
>	.cmds_info = &xe2_cmds_info,
>  };
>
> +static const struct intel_device_info intel_crescentisland_info = {
> +	.graphics_ver = 35,
> +	.graphics_rel = 11,
> +	.display_ver = 0,

Also:
       .has_oam = true,
       .is_crescentisland = true,

> +	.codename = "crescentisland",
> +	.cmds_info = &xe2_cmds_info,
> +};
> +
>  #define INTEL_PCI_ID_INIT(_id, _info) { \
>	.vendor_id = 0x8086, .device_id = (_id), \
>	.subvendor_id = PCI_MATCH_ANY, .subdevice_id = PCI_MATCH_ANY, \
> @@ -669,6 +677,8 @@ static const struct pci_id_match intel_device_match[] = {
>
>	INTEL_NVLS_IDS(INTEL_PCI_ID_INIT, &intel_novalake_info),
>
> +	INTEL_CRI_IDS(INTEL_PCI_ID_INIT, &intel_crescentisland_info),
> +
>	INTEL_PCI_ID_INIT(PCI_MATCH_ANY, &intel_generic_info),
>  };
>
> --
> 2.51.1
>