Re: [PATCH i-g-t v2 1/3] lib: Add NVL-S support

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 06 Nov 2025 07:34:17 -0800, Shekhar Chauhan wrote:
>
> Add NVL-S device info.
>
> v2: Fix indentation/spacing for PantherLake and Novalake in
> lib/intel_chipset.h (Kamil)
>
> Signed-off-by: Himanshu Girotra <himanshu.girotra@intel.com>
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> ---
>  lib/intel_chipset.h     |  4 +++-
>  lib/intel_device_info.c | 12 ++++++++++++
>  2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index 2f6bf788a..70ea78464 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -93,6 +93,7 @@ struct intel_device_info {
>	bool is_lunarlake : 1;
>	bool is_battlemage : 1;
>	bool is_pantherlake : 1;
> +	bool is_novalake: 1;

Maybe in this patch novalake should be changed to novalake_s everywhere?


>
>	const struct intel_cmds_info *cmds_info;
>	const char *codename;
> @@ -209,7 +210,8 @@ void intel_check_pch(void);
>  #define IS_PONTEVECCHIO(devid)	(intel_get_device_info(devid)->is_pontevecchio)
>  #define IS_LUNARLAKE(devid)	(intel_get_device_info(devid)->is_lunarlake)
>  #define IS_BATTLEMAGE(devid)	(intel_get_device_info(devid)->is_battlemage)
> -#define IS_PANTHERLAKE(devid)  (intel_get_device_info(devid)->is_pantherlake)
> +#define IS_PANTHERLAKE(devid)	(intel_get_device_info(devid)->is_pantherlake)
> +#define IS_NOVALAKE(devid)	(intel_get_device_info(devid)->is_novalake)
>
>  #define IS_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver == x)
>
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index a853f9ab4..fe452d50f 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -539,6 +539,16 @@ static const struct intel_device_info intel_pantherlake_info = {
>	.cmds_info = &xe2_cmds_info,
>  };
>
> +static const struct intel_device_info intel_novalake_info = {
> +	.graphics_ver = 30,
> +	.graphics_rel = 04,
> +	.display_ver = 35,
> +	.has_4tile = true,
> +	.is_novalake = true,
> +	.codename = "novalake",
> +	.cmds_info = &xe2_cmds_info,
> +};
> +
>  #define INTEL_PCI_ID_INIT(_id, _info) { \
>	.vendor_id = 0x8086, .device_id = (_id), \
>	.subvendor_id = PCI_MATCH_ANY, .subdevice_id = PCI_MATCH_ANY, \
> @@ -657,6 +667,8 @@ static const struct pci_id_match intel_device_match[] = {
>
>	INTEL_PTL_IDS(INTEL_PCI_ID_INIT, &intel_pantherlake_info),
>
> +	INTEL_NVLS_IDS(INTEL_PCI_ID_INIT, &intel_novalake_info),
> +
>	INTEL_PCI_ID_INIT(PCI_MATCH_ANY, &intel_generic_info),
>  };
>
> --
> 2.51.1
>