All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: Markus Armbruster <armbru@redhat.com>,
	 qemu-devel@nongnu.org, jsnow@redhat.com,  eblake@redhat.com,
	 thuth@redhat.com, berrange@redhat.com,  philmd@linaro.org,
	 kchamart@redhat.com, mst@redhat.com,  sgarzare@redhat.com
Subject: Re: [PATCH 1/8] qapi/audio: Fix description markup of AudiodevDBusOptions @nsamples
Date: Fri, 31 Oct 2025 12:46:52 +0100	[thread overview]
Message-ID: <87tszf8f9v.fsf@pond.sub.org> (raw)
In-Reply-To: <1313b150-57dc-4bd2-a593-63529e0026b0@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Fri, 31 Oct 2025 12:53:31 +0300")

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> On 31.10.25 12:47, Markus Armbruster wrote:
>> The description of Member @nsamples is indented incorrectly.  Comes
>> out like
>>
>>      Members:
>>              [...]
>> 	         nsamples (int, optional) – set the number of samples per read/write calls (default to 480,
>>      10ms at 48kHz).
>>
>> Fixing the indentation makes it come out like
>>
>>      Members:
>>              [...]
>> 	        nsamples (int, optional) – set the number of samples per read/write calls (default to 480, 10ms at 48kHz).
>> 
>
> I'm not sure this example worth breaking recommendation to
> " not use lines that are longer than 76 characters in your commit message" :)

Accident, will tidy up.

>> Fixes: 19c628f2f579 (dbus: add -audio dbus nsamples option)
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Thanks!



  reply	other threads:[~2025-10-31 11:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31  9:47 [PATCH 0/8] A QAPI schema doc markup fix, and style cleanup Markus Armbruster
2025-10-31  9:47 ` [PATCH 1/8] qapi/audio: Fix description markup of AudiodevDBusOptions @nsamples Markus Armbruster
2025-10-31  9:53   ` Vladimir Sementsov-Ogievskiy
2025-10-31 11:46     ` Markus Armbruster [this message]
2025-10-31 10:02   ` Philippe Mathieu-Daudé
2025-10-31  9:47 ` [PATCH 2/8] qapi: Refill doc comments to conform to conventions Markus Armbruster
2025-10-31 10:25   ` Vladimir Sementsov-Ogievskiy
2025-10-31 11:47     ` Markus Armbruster
2025-10-31  9:47 ` [PATCH 3/8] qapi: Clean up whitespace between definitions Markus Armbruster
2025-10-31 10:02   ` Philippe Mathieu-Daudé
2025-10-31 10:26   ` Vladimir Sementsov-Ogievskiy
2025-10-31  9:47 ` [PATCH 4/8] qga/qapi-schema: Refill doc comments to conform to conventions Markus Armbruster
2025-10-31 10:28   ` Vladimir Sementsov-Ogievskiy
2025-10-31  9:47 ` [PATCH 5/8] qga/qapi-schema: Clean up whitespace between definitions Markus Armbruster
2025-10-31 10:02   ` Philippe Mathieu-Daudé
2025-10-31 10:28   ` Vladimir Sementsov-Ogievskiy
2025-10-31  9:47 ` [PATCH 6/8] docs/interop: Refill QAPI doc comments to conform to conventions Markus Armbruster
2025-10-31 10:32   ` Vladimir Sementsov-Ogievskiy
2025-10-31 11:41     ` Markus Armbruster
2025-10-31  9:47 ` [PATCH 7/8] docs/interop/firmware: Literal block markup Markus Armbruster
2025-10-31 10:03   ` Philippe Mathieu-Daudé
2025-10-31 10:36   ` Vladimir Sementsov-Ogievskiy
2025-10-31  9:47 ` [PATCH 8/8] docs/interop: Add test to keep vhost-user.json sane Markus Armbruster
2025-10-31 10:53   ` Vladimir Sementsov-Ogievskiy
2025-10-31 11:45     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tszf8f9v.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=mst@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=thuth@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.