All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org,  jsnow@redhat.com,  eblake@redhat.com,
	thuth@redhat.com,  berrange@redhat.com,  philmd@linaro.org,
	kchamart@redhat.com,  mst@redhat.com,  sgarzare@redhat.com
Subject: Re: [PATCH 8/8] docs/interop: Add test to keep vhost-user.json sane
Date: Fri, 31 Oct 2025 12:45:19 +0100	[thread overview]
Message-ID: <87y0or8fcg.fsf@pond.sub.org> (raw)
In-Reply-To: <4d7c7507-970b-4eb2-8817-f18fd3693a73@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Fri, 31 Oct 2025 13:53:21 +0300")

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> On 31.10.25 12:47, Markus Armbruster wrote:
>> We did this for firmware.json in commit d4181658dfb (docs: add test
>> for firmware.json QAPI).
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>   docs/meson.build | 9 +++++++--
>>   1 file changed, 7 insertions(+), 2 deletions(-)
>> diff --git a/docs/meson.build b/docs/meson.build
>> index 3676f81c4d..7e54b01e6a 100644
>> --- a/docs/meson.build
>> +++ b/docs/meson.build
>> @@ -99,7 +99,12 @@ if build_docs
>>    alias_target('man', sphinxmans)
>>  endif
>> -test('QAPI firmware.json regression tests', qapi_gen,
>> -     args: ['-o', meson.current_build_dir() / 'qapi',
>> +test('QAPI firmware.json regression test', qapi_gen,
>> +     args: ['-o', meson.current_build_dir() / 'qapi-firmware',
>>              meson.current_source_dir() / 'interop/firmware.json'],
>>       suite: ['qapi-schema', 'qapi-interop'])
>> +
>> +test('QAPI vhost-user.json regression test', qapi_gen,
>> +     args: ['-o', meson.current_build_dir() / 'qapi-vhost-user',
>> +            meson.current_source_dir() / 'interop/vhost-user.json'],
>> +     suite: ['qapi-schema', 'qapi-interop'])
>
> Hmm, if we have more .json files in docs, we'll need some more
> convenient and safe way to cover them all.

Yes.  But so far it's just these two, and they're from 2018 and 2019.

> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> Tested-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Thanks!



      reply	other threads:[~2025-10-31 11:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31  9:47 [PATCH 0/8] A QAPI schema doc markup fix, and style cleanup Markus Armbruster
2025-10-31  9:47 ` [PATCH 1/8] qapi/audio: Fix description markup of AudiodevDBusOptions @nsamples Markus Armbruster
2025-10-31  9:53   ` Vladimir Sementsov-Ogievskiy
2025-10-31 11:46     ` Markus Armbruster
2025-10-31 10:02   ` Philippe Mathieu-Daudé
2025-10-31  9:47 ` [PATCH 2/8] qapi: Refill doc comments to conform to conventions Markus Armbruster
2025-10-31 10:25   ` Vladimir Sementsov-Ogievskiy
2025-10-31 11:47     ` Markus Armbruster
2025-10-31  9:47 ` [PATCH 3/8] qapi: Clean up whitespace between definitions Markus Armbruster
2025-10-31 10:02   ` Philippe Mathieu-Daudé
2025-10-31 10:26   ` Vladimir Sementsov-Ogievskiy
2025-10-31  9:47 ` [PATCH 4/8] qga/qapi-schema: Refill doc comments to conform to conventions Markus Armbruster
2025-10-31 10:28   ` Vladimir Sementsov-Ogievskiy
2025-10-31  9:47 ` [PATCH 5/8] qga/qapi-schema: Clean up whitespace between definitions Markus Armbruster
2025-10-31 10:02   ` Philippe Mathieu-Daudé
2025-10-31 10:28   ` Vladimir Sementsov-Ogievskiy
2025-10-31  9:47 ` [PATCH 6/8] docs/interop: Refill QAPI doc comments to conform to conventions Markus Armbruster
2025-10-31 10:32   ` Vladimir Sementsov-Ogievskiy
2025-10-31 11:41     ` Markus Armbruster
2025-10-31  9:47 ` [PATCH 7/8] docs/interop/firmware: Literal block markup Markus Armbruster
2025-10-31 10:03   ` Philippe Mathieu-Daudé
2025-10-31 10:36   ` Vladimir Sementsov-Ogievskiy
2025-10-31  9:47 ` [PATCH 8/8] docs/interop: Add test to keep vhost-user.json sane Markus Armbruster
2025-10-31 10:53   ` Vladimir Sementsov-Ogievskiy
2025-10-31 11:45     ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0or8fcg.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=mst@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=thuth@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.