All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Stanley Chu <stanley.chuys@gmail.com>
Cc: frank.li@nxp.com,  alexandre.belloni@bootlin.com,
	linux-i3c@lists.infradead.org,  linux-kernel@vger.kernel.org,
	tomer.maimon@nuvoton.com,  kwliu@nuvoton.com,  yschu@nuvoton.com
Subject: Re: [PATCH v3] i3c: master: svc: Fix npcm845 FIFO_EMPTY quirk
Date: Wed, 30 Jul 2025 09:59:43 +0200	[thread overview]
Message-ID: <87tt2unm6o.fsf@bootlin.com> (raw)
In-Reply-To: <20250730003719.1825593-1-yschu@nuvoton.com> (Stanley Chu's message of "Wed, 30 Jul 2025 08:37:19 +0800")

Hi Stanley,

On 30/07/2025 at 08:37:19 +08, Stanley Chu <stanley.chuys@gmail.com> wrote:

> From: Stanley Chu <yschu@nuvoton.com>
>
> In a private write transfer, the driver pre-fills the FIFO to work around
> the FIFO_EMPTY quirk. However, if an IBIWON event occurs, the hardware
> emits a NACK and the driver initiates a retry. During the retry, driver
> attempts to pre-fill the FIFO again if there is remaining data, but since
> the FIFO is already full, this leads to data loss.
>
> Check available space in FIFO to prevent overflow.
>
> Fixes: 4008a74e0f9b ("i3c: master: svc: Fix npcm845 FIFO empty issue")

Still missing Cc: stable here

> Signed-off-by: Stanley Chu <yschu@nuvoton.com>
> ---

Thanks,
Miquèl

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Stanley Chu <stanley.chuys@gmail.com>
Cc: frank.li@nxp.com,  alexandre.belloni@bootlin.com,
	linux-i3c@lists.infradead.org,  linux-kernel@vger.kernel.org,
	tomer.maimon@nuvoton.com,  kwliu@nuvoton.com,  yschu@nuvoton.com
Subject: Re: [PATCH v3] i3c: master: svc: Fix npcm845 FIFO_EMPTY quirk
Date: Wed, 30 Jul 2025 09:59:43 +0200	[thread overview]
Message-ID: <87tt2unm6o.fsf@bootlin.com> (raw)
In-Reply-To: <20250730003719.1825593-1-yschu@nuvoton.com> (Stanley Chu's message of "Wed, 30 Jul 2025 08:37:19 +0800")

Hi Stanley,

On 30/07/2025 at 08:37:19 +08, Stanley Chu <stanley.chuys@gmail.com> wrote:

> From: Stanley Chu <yschu@nuvoton.com>
>
> In a private write transfer, the driver pre-fills the FIFO to work around
> the FIFO_EMPTY quirk. However, if an IBIWON event occurs, the hardware
> emits a NACK and the driver initiates a retry. During the retry, driver
> attempts to pre-fill the FIFO again if there is remaining data, but since
> the FIFO is already full, this leads to data loss.
>
> Check available space in FIFO to prevent overflow.
>
> Fixes: 4008a74e0f9b ("i3c: master: svc: Fix npcm845 FIFO empty issue")

Still missing Cc: stable here

> Signed-off-by: Stanley Chu <yschu@nuvoton.com>
> ---

Thanks,
Miquèl

  reply	other threads:[~2025-07-30  7:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30  0:37 [PATCH v3] i3c: master: svc: Fix npcm845 FIFO_EMPTY quirk Stanley Chu
2025-07-30  0:37 ` Stanley Chu
2025-07-30  7:59 ` Miquel Raynal [this message]
2025-07-30  7:59   ` Miquel Raynal
2025-07-30 23:40 ` Alexandre Belloni
2025-07-30 23:40   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tt2unm6o.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=frank.li@nxp.com \
    --cc=kwliu@nuvoton.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stanley.chuys@gmail.com \
    --cc=tomer.maimon@nuvoton.com \
    --cc=yschu@nuvoton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.