[PATCH v2] ALSA: emu10k1: fix "for/take a while" typos

[PATCH v2] ALSA: emu10k1: fix "for/take a while" typos

[Ahelenia Ziemiańska]

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
---
v1: https://lore.kernel.org/lkml/h2ieddqja5jfrnuh3mvlxt6njrvp352t5rfzp2cvnrufop6tch@tarta.nabijaczleweli.xyz/t/#u

 sound/pci/emu10k1/emu10k1_main.c | 2 +-
 sound/pci/emu10k1/emupcm.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
index bbe252b8916c..6050201851b1 100644
--- a/sound/pci/emu10k1/emu10k1_main.c
+++ b/sound/pci/emu10k1/emu10k1_main.c
@@ -606,7 +606,7 @@ static int snd_emu10k1_ecard_init(struct snd_emu10k1 *emu)
 	/* Step 2: Calibrate the ADC and DAC */
 	snd_emu10k1_ecard_write(emu, EC_DACCAL | EC_LEDN | EC_TRIM_CSN);
 
-	/* Step 3: Wait for awhile;   XXX We can't get away with this
+	/* Step 3: Wait for a while;   XXX We can't get away with this
 	 * under a real operating system; we'll need to block and wait that
 	 * way. */
 	snd_emu10k1_wait(emu, 48000);
diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c
index 1bf6e3d652f8..ca4b03317539 100644
--- a/sound/pci/emu10k1/emupcm.c
+++ b/sound/pci/emu10k1/emupcm.c
@@ -991,7 +991,7 @@ static snd_pcm_uframes_t snd_emu10k1_capture_pointer(struct snd_pcm_substream *s
 	if (!epcm->running)
 		return 0;
 	if (epcm->first_ptr) {
-		udelay(50);	/* hack, it takes awhile until capture is started */
+		udelay(50);	/* hack, it takes a while until capture is started */
 		epcm->first_ptr = 0;
 	}
 	ptr = snd_emu10k1_ptr_read(emu, epcm->capture_idx_reg, 0) & 0x0000ffff;
-- 
2.39.5

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2] ALSA: emu10k1: fix "for/take a while" typos

[Takashi Iwai]

On Thu, 03 Jul 2025 20:21:29 +0200,
Ahelenia Ziemiańska wrote:
> 
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
> v1: https://lore.kernel.org/lkml/h2ieddqja5jfrnuh3mvlxt6njrvp352t5rfzp2cvnrufop6tch@tarta.nabijaczleweli.xyz/t/#u

Well, "awhile" is a proper word, AFAIK.


thanks,

Takashi

> 
>  sound/pci/emu10k1/emu10k1_main.c | 2 +-
>  sound/pci/emu10k1/emupcm.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
> index bbe252b8916c..6050201851b1 100644
> --- a/sound/pci/emu10k1/emu10k1_main.c
> +++ b/sound/pci/emu10k1/emu10k1_main.c
> @@ -606,7 +606,7 @@ static int snd_emu10k1_ecard_init(struct snd_emu10k1 *emu)
>  	/* Step 2: Calibrate the ADC and DAC */
>  	snd_emu10k1_ecard_write(emu, EC_DACCAL | EC_LEDN | EC_TRIM_CSN);
>  
> -	/* Step 3: Wait for awhile;   XXX We can't get away with this
> +	/* Step 3: Wait for a while;   XXX We can't get away with this
>  	 * under a real operating system; we'll need to block and wait that
>  	 * way. */
>  	snd_emu10k1_wait(emu, 48000);
> diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c
> index 1bf6e3d652f8..ca4b03317539 100644
> --- a/sound/pci/emu10k1/emupcm.c
> +++ b/sound/pci/emu10k1/emupcm.c
> @@ -991,7 +991,7 @@ static snd_pcm_uframes_t snd_emu10k1_capture_pointer(struct snd_pcm_substream *s
>  	if (!epcm->running)
>  		return 0;
>  	if (epcm->first_ptr) {
> -		udelay(50);	/* hack, it takes awhile until capture is started */
> +		udelay(50);	/* hack, it takes a while until capture is started */
>  		epcm->first_ptr = 0;
>  	}
>  	ptr = snd_emu10k1_ptr_read(emu, epcm->capture_idx_reg, 0) & 0x0000ffff;
> -- 
> 2.39.5
> Verifying...

Re: [PATCH v2] ALSA: emu10k1: fix "for/take a while" typos

[Ahelenia Ziemiańska]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

On Thu, Jul 10, 2025 at 04:28:00PM +0200, Takashi Iwai wrote:
> On Thu, 03 Jul 2025 20:21:29 +0200,
> Ahelenia Ziemiańska wrote:
> > 
> > Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> > ---
> > v1: https://lore.kernel.org/lkml/h2ieddqja5jfrnuh3mvlxt6njrvp352t5rfzp2cvnrufop6tch@tarta.nabijaczleweli.xyz/t/#u
> Well, "awhile" is a proper word, AFAIK.
Yes, but these two uses are clearly typos of "a while";
"awhile" is used differently: you could do
-	/* Step 3: Wait for awhile;   XXX We can't get away with this
+	/* Step 3: Wait awhile;   XXX We can't get away with this
for example.

I left the "awhile"s that weren't typos alone.

Best,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2] ALSA: emu10k1: fix "for/take a while" typos

[Takashi Iwai]

On Thu, 10 Jul 2025 17:44:20 +0200,
Ahelenia Ziemiańska wrote:
> 
> On Thu, Jul 10, 2025 at 04:28:00PM +0200, Takashi Iwai wrote:
> > On Thu, 03 Jul 2025 20:21:29 +0200,
> > Ahelenia Ziemiańska wrote:
> > > 
> > > Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> > > ---
> > > v1: https://lore.kernel.org/lkml/h2ieddqja5jfrnuh3mvlxt6njrvp352t5rfzp2cvnrufop6tch@tarta.nabijaczleweli.xyz/t/#u
> > Well, "awhile" is a proper word, AFAIK.
> Yes, but these two uses are clearly typos of "a while";
> "awhile" is used differently: you could do
> -	/* Step 3: Wait for awhile;   XXX We can't get away with this
> +	/* Step 3: Wait awhile;   XXX We can't get away with this
> for example.

That may be true from the strict grammatic POV, but "for awhile" is
seen relatively frequently and loosely perceived.


Takashi