Re: [Buildroot] [PATCH v6 4/5] package/vkmark: add vkmark benchmarking tool

["Alex Bennée" <alex.bennee@linaro.org>]

Nicolas Cavallari <nicolas.cavallari@green-communications.fr> writes:

> On 11/06/2025 15:55, Alex Bennée wrote:
>> Heiko Thiery <heiko.thiery@gmail.com> writes:
>> 
>>> Hi Alex,
>>>
>>> Am Mi., 11. Juni 2025 um 13:16 Uhr schrieb Alex Bennée <alex.bennee@linaro.org>:
>>>
>>>   We build from a recent HEAD to ensure we have the fixes to better
>>>   handle the missing KHR_display extension.
>>>
>>>   Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>>
>>> I tried to build vkmark against, now with wayland enabled and I see this:
>>>
>>> Program /usr/bin/wayland-scanner found: NO
>>>
>>> ../out-weston/build/vkmark-36e7d9b2ecf723e876add65534e95f55ec1bc79d/src/meson.build:116:22: ERROR: Program
>>> '/usr/bin/wayland-scanner' not found or not executable
>> Hmm this seems odd. At least wayland-scanner has a pkgconf variable:
>>    🕙14:51:21 alex@draig:buildroot.git/builds/x86_64  on 
>> add-virtio-vulkan-vkmark:master [$!?⇡]
>>    ➜  pkg-config --variable=wayland_scanner  wayland-scanner
>>    /usr/bin/wayland-scanner
>>    🕙14:52:16 alex@draig:buildroot.git/builds/x86_64  on  add-virtio-vulkan-vkmark:master [$!?⇡]
>>    ➜  ./host/bin/pkgconf --variable=wayland_scanner  wayland-scanner
>>    /home/alex/lsrc/tests/buildroot.git/builds/x86_64/host/bin/wayland-scanner
>>    🕙14:52:29 alex@draig:buildroot.git/builds/x86_64  on  add-virtio-vulkan-vkmark:master [$!?⇡]
>>    ➜
>> And the meson should find it with the normal dependency logic:
>>      wayland_scanner =
>> find_program(wayland_scanner_dep.get_variable('wayland_scanner'))
>
> wayland_scanner_dep is defined as:
>
> wayland_scanner_dep = dependency('wayland-scanner', required :
> get_option('wayland') == 'true')
>
> So it is searching for a wayland-scanner compiled for the target, not
> for one on the host. It should probably changed to
>
> wayland_scanner_dep = dependency('wayland-scanner', required :
> get_option('wayland') == 'true', native: true)

That works:

Build-time dependency wayland-scanner found: YES 1.23.1                                                                                                                       
Run-time dependency libdrm found: YES 2.4.124                                                                                                                                 
Run-time dependency gbm found: YES 25.1.3                                                                                                                                     
Program python3 found: YES (/home/alex/lsrc/tests/buildroot.git/builds/arm64/host/bin/python3)                                                                                
Program /home/alex/lsrc/tests/buildroot.git/builds/arm64/host/bin/wayland-scanner found: YES (/home/alex/lsrc/tests/buildroot.git/builds/arm64/host/bin/wayland-scanner)    


--8<---------------cut here---------------start------------->8---
modified   package/vkmark/0002-meson-fix-cross-compilation-50-75.patch
@@ -1,4 +1,4 @@
-From dc9a0c2d8687501ddf97c97599fa7a69d07d3d3d Mon Sep 17 00:00:00 2001
+From 0cb1a627ccb2da3c0cfd287e407c3e85fb750c94 Mon Sep 17 00:00:00 2001
 From: =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
 Date: Fri, 6 Jun 2025 17:48:40 +0100
 Subject: [PATCH 2/2] meson: fix cross-compilation (#50, #75)
@@ -6,15 +6,33 @@ MIME-Version: 1.0
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 8bit
 
-Now we have updated the minimum meson version we can apply sys_root to
-the prefix variable to ensure we can find the right vk.xml when
-cross-compiling.
+Currently there are a few problems getting in the way of cross
+compilation:
+
+  - we need to apply sys_root to the prefix variable to find the right vk.xml
+  - we need to force the native wayland-scanner to generate headers
 
 Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
 ---
+ meson.build     | 4 +++-
  src/meson.build | 4 +++-
- 1 file changed, 3 insertions(+), 1 deletion(-)
+ 2 files changed, 6 insertions(+), 2 deletions(-)
 
+diff --git a/meson.build b/meson.build
+index 2d08d53..6cb56f5 100644
+--- a/meson.build
++++ b/meson.build
+@@ -29,7 +29,9 @@ xcb_icccm_dep = dependency('xcb-icccm', required : get_option('xcb') == 'true')
+ wayland_client_dep = dependency('wayland-client', required : get_option('wayland') == 'true')
+ wayland_protocols_dep = dependency('wayland-protocols', version : '>= 1.12',
+                                    required : get_option('wayland') == 'true')
+-wayland_scanner_dep = dependency('wayland-scanner', required : get_option('wayland') == 'true')
++wayland_scanner_dep = dependency('wayland-scanner',
++                                 required : get_option('wayland') == 'true',
++                                 native: true)
+ libdrm_dep = dependency('libdrm', required : get_option('kms') == 'true')
+ gbm_dep = dependency('gbm', required : get_option('kms') == 'true')
+ 
 diff --git a/src/meson.build b/src/meson.build
 index a664ddc..b0e8c4a 100644
 --- a/src/meson.build
--8<---------------cut here---------------end--------------->8---



-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot