Re: [Buildroot] [PATCH v6 3/5] package/vulkan-[headers|loader|tools]: bump to 1.4.317 release

[Julien Olivain <ju.o@free.fr>]

Hi Alex,

On 11/06/2025 13:16, Alex Bennée wrote:
> Update to the current release. We now need the recently added
> vulkan-sdk to have access to the volk loader.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> v5
>   - 1.4.316 -> 1.4.317
> v4
>   - 1.4.306 -> 1.4.316
>   - doesn't seem to need isystem patch now
> v3
>   - fix up comment, properly select the SDK package

[...]

> diff --git a/package/vulkan-tools/Config.in 
> b/package/vulkan-tools/Config.in
> index 54fa539dab..bb0dce8282 100644
> --- a/package/vulkan-tools/Config.in
> +++ b/package/vulkan-tools/Config.in
> @@ -6,12 +6,13 @@ config BR2_PACKAGE_VULKAN_TOOLS

As I mentioned in:
https://lore.kernel.org/buildroot/1215059662f277baf90c9d16a7edac02@free.fr/T/#u

Could you update the dependency comment in this patch:

      depends on !BR2_STATIC_LIBS # vulkan-loader, vulkan-sdk


>  	depends on BR2_TOOLCHAIN_HAS_THREADS # vulkan-loader
>  	select BR2_PACKAGE_VULKAN_HEADERS
>  	select BR2_PACKAGE_VULKAN_LOADER
> +	select BR2_PACKAGE_VULKAN_SDK
> 
>  	help
>  	  The Khronos official Vulkan Tools and Utilities.
> 
>  	  https://github.com/KhronosGroup/Vulkan-Tools
> 
> -comment "vulkan-tools needs a toolchain w/ C++, dynamic library, 
> threads, gcc >= 4.9"
> +comment "vulkan-tools needs a toolchain w/ C++, dynamic library, 
> threads, gcc >= 4.9, vulkan-sdk"

Here, adding "vulkan-sdk" is not needed (because it is "select"ed and 
not a "depends on").
Could you remove it.

>  	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || \
>  		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

Could you send an updated patch addressing those comments, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot