All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] ALPM rework and fixes
@ 2025-05-08 14:16 Jouni Högander
  2025-05-08 14:17 ` [PATCH v3 1/2] drm/i915/alpm: Make intel_alpm_enable_sink available for PSR Jouni Högander
                   ` (12 more replies)
  0 siblings, 13 replies; 19+ messages in thread
From: Jouni Högander @ 2025-05-08 14:16 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: animesh.manna, Jouni Högander

Currently there are couple of problems in ALPM implelementation:

1. ALPM registers are written while PSR/ Panel Replay is kept
   enabled. This is causing following error messages on PTL:
   
   "xe 0000:00:02.0: [drm] *ERROR* Timeout waiting for DDI BUF A to
   get active".

   This is fixed by enabling ALPM only once when needed.

2. ALPM is never disabled when used by PSR/Panel Replay. I.e. if PSR
   is once enabled ALPM is left enabled for good when PSR is
   disabled. This is fixed by using intel_alpm_disable and calling it
   for both cases: LOBF disable and PSR disable.

This patch set is addressing these.

v3:
  - enable/disable ALPM from PSR code
v2:
  - continue using rmw when disabling ALPM
  - take into account disabled hw in old_crtc_state

Jouni Högander (2):
  drm/i915/alpm: Make intel_alpm_enable_sink available for PSR
  drm/i915/alpm: Stop writing ALPM registers when PSR is enabled

 drivers/gpu/drm/i915/display/intel_alpm.c | 15 +++++++++++----
 drivers/gpu/drm/i915/display/intel_alpm.h |  2 ++
 drivers/gpu/drm/i915/display/intel_psr.c  |  8 +++++++-
 3 files changed, 20 insertions(+), 5 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2025-05-13  4:47 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-08 14:16 [PATCH v3 0/2] ALPM rework and fixes Jouni Högander
2025-05-08 14:17 ` [PATCH v3 1/2] drm/i915/alpm: Make intel_alpm_enable_sink available for PSR Jouni Högander
2025-05-09  4:25   ` Kandpal, Suraj
2025-05-09 10:43   ` Jani Nikula
2025-05-09 12:04     ` Hogander, Jouni
2025-05-08 14:17 ` [PATCH v3 2/2] drm/i915/alpm: Stop writing ALPM registers when PSR is enabled Jouni Högander
2025-05-13  3:59   ` Kandpal, Suraj
2025-05-13  4:46     ` Hogander, Jouni
2025-05-08 14:22 ` ✓ CI.Patch_applied: success for ALPM rework and fixes (rev3) Patchwork
2025-05-08 14:22 ` ✓ CI.checkpatch: " Patchwork
2025-05-08 14:23 ` ✓ CI.KUnit: " Patchwork
2025-05-08 14:32 ` ✓ CI.Build: " Patchwork
2025-05-08 14:34 ` ✓ CI.Hooks: " Patchwork
2025-05-08 14:35 ` ✗ CI.checksparse: warning " Patchwork
2025-05-08 14:58 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-05-08 15:11 ` ✓ Xe.CI.BAT: success " Patchwork
2025-05-08 15:24 ` ✓ i915.CI.BAT: " Patchwork
2025-05-08 17:34 ` ✗ i915.CI.Full: failure " Patchwork
2025-05-09  5:54 ` ✗ Xe.CI.Full: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.