All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: richard@nod.at,  vigneshr@ti.com,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: Add error log for marvell_nfc_end_cmd()
Date: Mon, 07 Apr 2025 08:59:23 +0200	[thread overview]
Message-ID: <87tt70h2yc.fsf@bootlin.com> (raw)
In-Reply-To: <20250407020917.1242-1-vulab@iscas.ac.cn> (Wentao Liang's message of "Mon, 7 Apr 2025 10:09:16 +0800")

Hello Liang,

On 07/04/2025 at 10:09:16 +08, Wentao Liang <vulab@iscas.ac.cn> wrote:

> The function marvell_nfc_hw_ecc_bch_read_chunk() calls the function
> marvell_nfc_end_cmd(), but dose not check its return value. Since it
> is incorrect to bail from the loop if the marvell_nfc_end_cmd() fails,
> an error log is necessary to prevent silent failure.

The failure will not be silent, *_read_chunk() is called in
marvell_nfc_hw_ecc_bch_read_page() only, where the validity of the data
will be checked. If you really want to make it visible *there* I believe
the correct approach is to change the caller prototype and forward the
error instead.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: richard@nod.at,  vigneshr@ti.com,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: Add error log for marvell_nfc_end_cmd()
Date: Mon, 07 Apr 2025 08:59:23 +0200	[thread overview]
Message-ID: <87tt70h2yc.fsf@bootlin.com> (raw)
In-Reply-To: <20250407020917.1242-1-vulab@iscas.ac.cn> (Wentao Liang's message of "Mon, 7 Apr 2025 10:09:16 +0800")

Hello Liang,

On 07/04/2025 at 10:09:16 +08, Wentao Liang <vulab@iscas.ac.cn> wrote:

> The function marvell_nfc_hw_ecc_bch_read_chunk() calls the function
> marvell_nfc_end_cmd(), but dose not check its return value. Since it
> is incorrect to bail from the loop if the marvell_nfc_end_cmd() fails,
> an error log is necessary to prevent silent failure.

The failure will not be silent, *_read_chunk() is called in
marvell_nfc_hw_ecc_bch_read_page() only, where the validity of the data
will be checked. If you really want to make it visible *there* I believe
the correct approach is to change the caller prototype and forward the
error instead.

Thanks,
Miquèl

  parent reply	other threads:[~2025-04-07  6:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07  2:09 [PATCH] mtd: nand: Add error log for marvell_nfc_end_cmd() Wentao Liang
2025-04-07  2:09 ` Wentao Liang
2025-04-07  4:46 ` kernel test robot
2025-04-07  4:46   ` kernel test robot
2025-04-07  5:49 ` kernel test robot
2025-04-07  5:49   ` kernel test robot
2025-04-07  6:59 ` Miquel Raynal [this message]
2025-04-07  6:59   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tt70h2yc.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.