Re: [PATCH 03/14] configure, build: make valgrind optional

[Nick Alcock <nick.alcock@oracle.com>]

On 25 Oct 2024, Kris Van Hees uttered the following:

> On Thu, Oct 24, 2024 at 12:37:47PM +0100, Nick Alcock wrote:
>> We fail building if <valgrind/valgrind.h> is not available, which is
>> ridiculous given that the only reason we need it is to make valgrind go away
>> at suitable moments to let us drop uprobes.
>> 
>> A suitable new configure check (using a new check-header-macro-rule
>> function) lets us check for <valgrind/valgrind.h> and disable it if not
>> present: as usual, defining HAVE_VALGRIND or passing it to configure will
>> also suffice to override the check (though since the code this enables
>> doesn't require any part of valgrind at runtime, I don't see why one would
>> ever need to do so).
>
> I would remove the final ( ... ) since it is speculative about people's intent.

... what's wrong with speculating about people's intent? But fine, dropped.

>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Bug: https://github.com/oracle/dtrace-utils/issues/80
>
> Put Bug: before Signed-off-by:
> Indentation issue (see below).

Ack!

>> -	if (RUNNING_ON_VALGRIND)
>> +#ifdef HAVE_VALGRIND
>> +        if (RUNNING_ON_VALGRIND)
>
> Indentation issue (spaces vs tabs).

GNAH. Fixed series-wide. (And in the other ongoing series, too, which I
managed to forget to adjust before the most recent push.)

-- 
NULL && (void)