All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com, sam@gentoo.org
Subject: Re: [PATCH 02/14] pkgconfig: drop spaces in variable decls
Date: Mon, 28 Oct 2024 16:16:28 +0000	[thread overview]
Message-ID: <87y128qk2r.fsf@esperi.org.uk> (raw)
In-Reply-To: <ZxsA9ee8F2-cJ4yY@kvh-deb-bpf.us.oracle.com> (Kris Van Hees's message of "Thu, 24 Oct 2024 22:22:45 -0400")

On 25 Oct 2024, Kris Van Hees said:

> On Thu, Oct 24, 2024 at 12:37:46PM +0100, Nick Alcock wrote:
>> The requirement to have variable declarations with no spaces in them is not
>> documented, nor does pkg-config seem to care, but most pkg-config scripts in
>> the wild conform to it and pkgconf --validate complains.
>> 
>> (pkgconf --validate may also complain about the Version lines. This is a bug
>> in pkgconf, <https://todo.sr.ht/~kaniini/pkgconf/15>, and should be
>> ignored.)
>> 
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Bug: https://github.com/oracle/dtrace-utils/issues/105
>
> Move Bug before Signed-off-by, for clarity and consistency?

I kept on oscillating on that. I'll shuffle them all.

> Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

Thanks!

  reply	other threads:[~2024-10-28 16:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 11:37 [PATCH 00/14] gentoo, manpage, and assorted other small fixes Nick Alcock
2024-10-24 11:37 ` [PATCH 01/14] No longer depend on libsystemd Nick Alcock
2024-10-25  2:21   ` Kris Van Hees
2024-10-28 16:14     ` Nick Alcock
2024-10-24 11:37 ` [PATCH 02/14] pkgconfig: drop spaces in variable decls Nick Alcock
2024-10-25  2:22   ` Kris Van Hees
2024-10-28 16:16     ` Nick Alcock [this message]
2024-10-24 11:37 ` [PATCH 03/14] configure, build: make valgrind optional Nick Alcock
2024-10-25  2:30   ` Kris Van Hees
2024-10-28 16:38     ` Nick Alcock
2024-10-24 11:37 ` [PATCH 04/14] build: substitute LIBDIR in pkg-config files Nick Alcock
2024-10-25  2:32   ` Kris Van Hees
2024-10-24 11:37 ` [PATCH 05/14] probe: get the size of the hash-lookup key right Nick Alcock
2024-10-25  2:40   ` Kris Van Hees
2024-10-28 17:14     ` Nick Alcock
2024-10-24 11:37 ` [PATCH 06/14] configure: fix dreadful behaviour of MANDIR / --mandir Nick Alcock
2024-10-25  2:41   ` Kris Van Hees
2024-10-24 11:37 ` [PATCH 07/14] man: the synopsis is ended with .YS, not .SY Nick Alcock
2024-10-25  2:49   ` Kris Van Hees
2024-10-24 11:37 ` [PATCH 08/14] man: use \- for option dashes, not - Nick Alcock
2024-10-25  2:49   ` Kris Van Hees
2024-10-24 11:37 ` [PATCH 09/14] man: drop blank lines Nick Alcock
2024-10-25  2:50   ` Kris Van Hees
2024-10-24 11:37 ` [PATCH 10/14] man: fix blank line in environment variables list Nick Alcock
2024-10-25  2:50   ` Kris Van Hees
2024-10-24 11:37 ` [PATCH 11/14] dtprobed: fix parser child timeout Nick Alcock
2024-10-25  2:54   ` Kris Van Hees
2024-10-24 11:37 ` [PATCH 12/14] man: add manpage for dtprobed(8) Nick Alcock
2024-10-25  2:53   ` Kris Van Hees
2024-10-28 17:18     ` Nick Alcock
2024-10-24 11:37 ` [PATCH 13/14] man: drop double-\fB at the start of every option line Nick Alcock
2024-10-25  2:55   ` Kris Van Hees
2024-10-24 11:37 ` [PATCH 14/14] man: \fP-ize Nick Alcock
2024-10-25  2:55   ` Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y128qk2r.fsf@esperi.org.uk \
    --to=nick.alcock@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=kris.van.hees@oracle.com \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.