From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <johannes.berg@intel.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured
Date: Tue, 13 Feb 2024 14:54:18 +0200 [thread overview]
Message-ID: <87ttmced8l.fsf@kernel.org> (raw)
In-Reply-To: <20240213122556.9593-1-pkshih@realtek.com> (Ping-Ke Shih's message of "Tue, 13 Feb 2024 20:25:56 +0800")
Ping-Ke Shih <pkshih@realtek.com> writes:
> The rcu_read_unlock() is accidentally added, and sparse warn:
>
> drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
> warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock
>
> Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
> Cc: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Commit b82730bf57b5 is in wireless-next so I'll queue this patch to
wireless-next as well, right?
This again shows how important it is to fix all the remainging sparse
warnings in wireless code so that we don't miss important warnings like
this. If there just would be a way to get the cleanup patch submitters
to fix the sparse warnings, sigh.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-02-13 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 12:25 [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured Ping-Ke Shih
2024-02-13 12:54 ` Kalle Valo [this message]
2024-02-13 13:43 ` Ping-Ke Shih
2024-02-13 15:22 ` Kalle Valo
2024-02-15 11:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttmced8l.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.