From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"johannes.berg@intel.com" <johannes.berg@intel.com>
Subject: Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured
Date: Tue, 13 Feb 2024 17:22:56 +0200 [thread overview]
Message-ID: <874jecpewf.fsf@kernel.org> (raw)
In-Reply-To: <f8b28bf1f735432489c1674d62fc68a8cf475ee8.camel@realtek.com> (Ping-Ke Shih's message of "Tue, 13 Feb 2024 13:43:46 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
>> This again shows how important it is to fix all the remainging sparse
>> warnings in wireless code so that we don't miss important warnings like
>> this. If there just would be a way to get the cleanup patch submitters
>> to fix the sparse warnings, sigh.
>
> In short term, can we record the count of warnings and ensure it
> doesn't increase while new commits are getting merged?
Netdev has that kind of checks in checkpatch:
netdev/build_allmodconfig_warn success Errors and warnings before: 993 this patch: 992
https://patchwork.kernel.org/project/netdevbpf/patch/20240213112122.404045-2-leitao@debian.org/
But in wireless project we have not set up that. That reminds me that I
need to reply to Jakub's email related to this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-02-13 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 12:25 [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured Ping-Ke Shih
2024-02-13 12:54 ` Kalle Valo
2024-02-13 13:43 ` Ping-Ke Shih
2024-02-13 15:22 ` Kalle Valo [this message]
2024-02-15 11:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jecpewf.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.