[PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured

[PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured

[Ping-Ke Shih]

The rcu_read_unlock() is accidentally added, and sparse warn:

  drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
    warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock

Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/fw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 540ea16f048e..7f0c8cfb3e2d 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -2808,7 +2808,6 @@ int rtw89_fw_h2c_assoc_cmac_tbl_g7(struct rtw89_dev *rtwdev,
 
 		h2c->w4 |= le32_encode_bits(~punct,
 					    CCTLINFO_G7_W4_ACT_SUBCH_CBW);
-		rcu_read_unlock();
 		h2c->m4 |= cpu_to_le32(CCTLINFO_G7_W4_ACT_SUBCH_CBW);
 	}
 
-- 
2.25.1

Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> writes:

> The rcu_read_unlock() is accidentally added, and sparse warn:
>
>   drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
>     warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock
>
> Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
> Cc: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Commit b82730bf57b5 is in wireless-next so I'll queue this patch to
wireless-next as well, right?

This again shows how important it is to fix all the remainging sparse
warnings in wireless code so that we don't miss important warnings like
this. If there just would be a way to get the cleanup patch submitters
to fix the sparse warnings, sigh.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured

[Ping-Ke Shih]

On Tue, 2024-02-13 at 14:54 +0200, Kalle Valo wrote:
> 
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > The rcu_read_unlock() is accidentally added, and sparse warn:
> > 
> >   drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
> >     warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock
> > 
> > Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
> > Cc: Johannes Berg <johannes.berg@intel.com>
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> Commit b82730bf57b5 is in wireless-next so I'll queue this patch to
> wireless-next as well, right?

I think yes.

> 
> This again shows how important it is to fix all the remainging sparse
> warnings in wireless code so that we don't miss important warnings like
> this. If there just would be a way to get the cleanup patch submitters
> to fix the sparse warnings, sigh.
> 

In short term, can we record the count of warnings and ensure it
doesn't increase while new commits are getting merged? 

Ping-Ke 

Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> writes:

>> This again shows how important it is to fix all the remainging sparse
>> warnings in wireless code so that we don't miss important warnings like
>> this. If there just would be a way to get the cleanup patch submitters
>> to fix the sparse warnings, sigh.
>
> In short term, can we record the count of warnings and ensure it
> doesn't increase while new commits are getting merged? 

Netdev has that kind of checks in checkpatch:

netdev/build_allmodconfig_warn	success	Errors and warnings before: 993 this patch: 992

https://patchwork.kernel.org/project/netdevbpf/patch/20240213112122.404045-2-leitao@debian.org/

But in wireless project we have not set up that. That reminds me that I
need to reply to Jakub's email related to this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> wrote:

> The rcu_read_unlock() is accidentally added, and sparse warn:
> 
>   drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
>     warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock
> 
> Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
> Cc: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

63d94f749623 wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240213122556.9593-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches