Re: [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up

[Takashi Iwai <tiwai@suse.de>]

On Thu, 06 Apr 2023 13:15:45 +0200,
Oswald Buddenhagen wrote:
> 
> On Thu, Apr 06, 2023 at 09:48:40AM +0200, Takashi Iwai wrote:
> >The "BUG:" suffix should be dropped.  This would catch eyes of (badly)
> >trained kernel programmers as if it were a kernel panic message :)
> >
> done
> 
> >Also the term "binary compatibility" is ambiguous in this context --
> >especially because we're dealing with the code that treats the
> >32/64bit binary compatibility.
> >
> i wasn't sure what to make of that. how about this:
> 
> -- >8 --
> 
> I'm not the first one to run into this, see e.g.
> https://lore.kernel.org/all/29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org/
> 
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> ---
>  include/uapi/sound/asound.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index de6810e94abe..7eecc99ddef7 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -570,7 +570,8 @@ struct __snd_pcm_mmap_status64 {
>  struct __snd_pcm_mmap_control64 {
>  	__pad_before_uframe __pad1;
>  	snd_pcm_uframes_t appl_ptr;	 /* RW: appl ptr (0...boundary-1) */
> -	__pad_before_uframe __pad2;
> +	__pad_before_uframe __pad2;	 // This should be __pad_after_uframe, but binary
> +					 // backwards compatibility constraints prevent a fix.

Looks much better.
Care to resubmit v2 patch?


Thanks!

Takashi