Re: [PATCH] ALSA: document that struct __snd_pcm_mmap_control64 is messed up

[Takashi Iwai <tiwai@suse.de>]

On Wed, 05 Apr 2023 22:12:19 +0200,
Oswald Buddenhagen wrote:
> 
> I suppose this can't be changed anymore due to binary compat concerns.

Yes, please check the thread at
  https://lore.kernel.org/all/29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org/

> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> ---
>  include/uapi/sound/asound.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index de6810e94abe..595a683968bc 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -570,7 +570,7 @@ struct __snd_pcm_mmap_status64 {
>  struct __snd_pcm_mmap_control64 {
>  	__pad_before_uframe __pad1;
>  	snd_pcm_uframes_t appl_ptr;	 /* RW: appl ptr (0...boundary-1) */
> -	__pad_before_uframe __pad2;
> +	__pad_before_uframe __pad2;	 // BUG: this should have been __pad_after_uframe!

Writing this alone doesn't help much.  Actual help would be to mention
that this typo is kept intentionally.


Takashi