[PATCH] changelog: Fix missing reference to driver notifications

[PATCH] changelog: Fix missing reference to driver notifications

[Parav Pandit]

Cited commit in fixes tag missed to update the reference to drivers
notifications section in past change log.
Fix the reference.

Fixes: be2ce1ee17e0 ("content.tex Fix Driver notifications label")
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 cl-os.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cl-os.tex b/cl-os.tex
index 5ae8a7b..a7364b7 100644
--- a/cl-os.tex
+++ b/cl-os.tex
@@ -254,7 +254,7 @@
 
 Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
 
-See \ref{sec:Virtqueues / Driver notifications}.
+See \ref{sec:Basic Facilities of a Virtio Device / Driver notifications}.
  } \\
 \hline
 8f2c4e03eae8 & 27 Oct 2019 & Eugenio Pérez & { block: Add multiqueue
-- 
2.26.2

[virtio-dev] Re: [PATCH] changelog: Fix missing reference to driver notifications

[Cornelia Huck]

On Thu, Feb 16 2023, Parav Pandit <parav@nvidia.com> wrote:

> Cited commit in fixes tag missed to update the reference to drivers
> notifications section in past change log.
> Fix the reference.
>
> Fixes: be2ce1ee17e0 ("content.tex Fix Driver notifications label")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
>  cl-os.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Does it really make sense to patch the changelog? This is about the
1.1->1.2 changes, and I'd assume it is only relevant for the released
1.2 spec. We'll replace the changelog anyway when we do the 1.3 release.

[Speaking of the 1.3 release, we really should be planning for it. Maybe
target June or so, with a freeze in April?]


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

RE: [PATCH] changelog: Fix missing reference to driver notifications

[Parav Pandit]

> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Thursday, February 16, 2023 3:01 AM
> 
> On Thu, Feb 16 2023, Parav Pandit <parav@nvidia.com> wrote:
> 
> > Cited commit in fixes tag missed to update the reference to drivers
> > notifications section in past change log.
> > Fix the reference.
> >
> > Fixes: be2ce1ee17e0 ("content.tex Fix Driver notifications label")
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > ---
> >  cl-os.tex | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Does it really make sense to patch the changelog? This is about the
> 1.1->1.2 changes, and I'd assume it is only relevant for the released
> 1.2 spec. We'll replace the changelog anyway when we do the 1.3 release.
>
Right. I got it.
It should be fine to drop this patch.
I took a blind scan to make sure all the previous links exists now.
It isn't necessary from 1.2 to 1.3 as those entries will be removed as you say.
 
> [Speaking of the 1.3 release, we really should be planning for it. Maybe target
> June or so, with a freeze in April?]
Very good point. Yes.
Not fully familiar yet, if its June end, may be May is alright too depending on changes in coming months.
I am sure you and Michael are better place to make this call.

[virtio-comment] Re: [PATCH] changelog: Fix missing reference to driver notifications

[Michael S. Tsirkin]

On Thu, Feb 16, 2023 at 09:13:12PM +0000, Parav Pandit wrote:
> 
> > From: Cornelia Huck <cohuck@redhat.com>
> > Sent: Thursday, February 16, 2023 3:01 AM
> > 
> > On Thu, Feb 16 2023, Parav Pandit <parav@nvidia.com> wrote:
> > 
> > > Cited commit in fixes tag missed to update the reference to drivers
> > > notifications section in past change log.
> > > Fix the reference.
> > >
> > > Fixes: be2ce1ee17e0 ("content.tex Fix Driver notifications label")
> > > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > > ---
> > >  cl-os.tex | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Does it really make sense to patch the changelog? This is about the
> > 1.1->1.2 changes, and I'd assume it is only relevant for the released
> > 1.2 spec. We'll replace the changelog anyway when we do the 1.3 release.
> >
> Right. I got it.
> It should be fine to drop this patch.
> I took a blind scan to make sure all the previous links exists now.
> It isn't necessary from 1.2 to 1.3 as those entries will be removed as you say.

Right just post a patch to drop all of cl-os.tex.

> > [Speaking of the 1.3 release, we really should be planning for it. Maybe target
> > June or so, with a freeze in April?]
> Very good point. Yes.
> Not fully familiar yet, if its June end, may be May is alright too depending on changes in coming months.
> I am sure you and Michael are better place to make this call.



This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/