* [PATCH] tests/tcg: include CONFIG_PLUGIN in config-host.mak
@ 2022-10-13 13:13 Paolo Bonzini
2022-10-13 20:35 ` Alex Bennée
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2022-10-13 13:13 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure b/configure
index f4ff1cf305..a5af9c524f 100755
--- a/configure
+++ b/configure
@@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
if test -n "$gdb_bin"; then
echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
fi
+if test "$plugins" = "yes" ; then
+ echo "CONFIG_PLUGIN=y" >> $config_host_mak
+fi
tcg_tests_targets=
for target in $target_list; do
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tests/tcg: include CONFIG_PLUGIN in config-host.mak
2022-10-13 13:13 [PATCH] tests/tcg: include CONFIG_PLUGIN in config-host.mak Paolo Bonzini
@ 2022-10-13 20:35 ` Alex Bennée
2022-10-13 20:57 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2022-10-13 20:35 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> configure | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configure b/configure
> index f4ff1cf305..a5af9c524f 100755
> --- a/configure
> +++ b/configure
> @@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
> if test -n "$gdb_bin"; then
> echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
> fi
> +if test "$plugins" = "yes" ; then
> + echo "CONFIG_PLUGIN=y" >> $config_host_mak
> +fi
Don't we already do that anyway?
>
> tcg_tests_targets=
> for target in $target_list; do
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/tcg: include CONFIG_PLUGIN in config-host.mak
2022-10-13 20:35 ` Alex Bennée
@ 2022-10-13 20:57 ` Paolo Bonzini
2022-10-14 8:18 ` Alex Bennée
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2022-10-13 20:57 UTC (permalink / raw)
To: Alex Bennée; +Cc: qemu-devel
On Thu, Oct 13, 2022 at 10:35 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > configure | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/configure b/configure
> > index f4ff1cf305..a5af9c524f 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
> > if test -n "$gdb_bin"; then
> > echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
> > fi
> > +if test "$plugins" = "yes" ; then
> > + echo "CONFIG_PLUGIN=y" >> $config_host_mak
> > +fi
>
> Don't we already do that anyway?
No, we don't. CONFIG_PLUGIN enables "make test-plugins" and "make
plugins" but not the plugin tests in tests/tcg.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/tcg: include CONFIG_PLUGIN in config-host.mak
2022-10-13 20:57 ` Paolo Bonzini
@ 2022-10-14 8:18 ` Alex Bennée
0 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2022-10-14 8:18 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> On Thu, Oct 13, 2022 at 10:35 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>>
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> > ---
>> > configure | 3 +++
>> > 1 file changed, 3 insertions(+)
>> >
>> > diff --git a/configure b/configure
>> > index f4ff1cf305..a5af9c524f 100755
>> > --- a/configure
>> > +++ b/configure
>> > @@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak
>> > if test -n "$gdb_bin"; then
>> > echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
>> > fi
>> > +if test "$plugins" = "yes" ; then
>> > + echo "CONFIG_PLUGIN=y" >> $config_host_mak
>> > +fi
>>
>> Don't we already do that anyway?
>
> No, we don't. CONFIG_PLUGIN enables "make test-plugins" and "make
> plugins" but not the plugin tests in tests/tcg.
Ahh I see. Queued to testing/next, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-14 8:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-13 13:13 [PATCH] tests/tcg: include CONFIG_PLUGIN in config-host.mak Paolo Bonzini
2022-10-13 20:35 ` Alex Bennée
2022-10-13 20:57 ` Paolo Bonzini
2022-10-14 8:18 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.