From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: stable@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Fix otg port initialization
Date: Sun, 18 Sep 2022 20:46:33 +0300 [thread overview]
Message-ID: <87tu54r2w1.fsf@gmail.com> (raw)
In-Reply-To: <6779635c-a162-0b7e-d124-d88d1ed9e162@sholland.org>
On 2022-09-17 at 12:12 -05, Samuel Holland <samuel@sholland.org> wrote:
> On 9/17/22 11:58, Mikhail Rudenko wrote:
>> There are two issues in rockchip_usb2phy_otg_port_init(): (1) even if
>> devm_extcon_register_notifier() returns error, the code proceeds to
>> the next if statement and (2) if no extcon is defined in of_node, the
>> return value of property_enabled() is reused as the return value of
>> the whole function. If the return value of property_enable() is
>> nonzero, (2) results in an unexpected probe failure and kernel panic
>> in delayed work:
>
> This should be fixed by the following patch which is accepted already:
>
> https://lore.kernel.org/lkml/20220902184543.1234835-1-pgwipeout@gmail.com/
Ah, I see now. Sorry for the noise!
--
Best regards,
Mikhail Rudenko
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: stable@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Fix otg port initialization
Date: Sun, 18 Sep 2022 20:46:33 +0300 [thread overview]
Message-ID: <87tu54r2w1.fsf@gmail.com> (raw)
In-Reply-To: <6779635c-a162-0b7e-d124-d88d1ed9e162@sholland.org>
On 2022-09-17 at 12:12 -05, Samuel Holland <samuel@sholland.org> wrote:
> On 9/17/22 11:58, Mikhail Rudenko wrote:
>> There are two issues in rockchip_usb2phy_otg_port_init(): (1) even if
>> devm_extcon_register_notifier() returns error, the code proceeds to
>> the next if statement and (2) if no extcon is defined in of_node, the
>> return value of property_enabled() is reused as the return value of
>> the whole function. If the return value of property_enable() is
>> nonzero, (2) results in an unexpected probe failure and kernel panic
>> in delayed work:
>
> This should be fixed by the following patch which is accepted already:
>
> https://lore.kernel.org/lkml/20220902184543.1234835-1-pgwipeout@gmail.com/
Ah, I see now. Sorry for the noise!
--
Best regards,
Mikhail Rudenko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: stable@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Fix otg port initialization
Date: Sun, 18 Sep 2022 20:46:33 +0300 [thread overview]
Message-ID: <87tu54r2w1.fsf@gmail.com> (raw)
In-Reply-To: <6779635c-a162-0b7e-d124-d88d1ed9e162@sholland.org>
On 2022-09-17 at 12:12 -05, Samuel Holland <samuel@sholland.org> wrote:
> On 9/17/22 11:58, Mikhail Rudenko wrote:
>> There are two issues in rockchip_usb2phy_otg_port_init(): (1) even if
>> devm_extcon_register_notifier() returns error, the code proceeds to
>> the next if statement and (2) if no extcon is defined in of_node, the
>> return value of property_enabled() is reused as the return value of
>> the whole function. If the return value of property_enable() is
>> nonzero, (2) results in an unexpected probe failure and kernel panic
>> in delayed work:
>
> This should be fixed by the following patch which is accepted already:
>
> https://lore.kernel.org/lkml/20220902184543.1234835-1-pgwipeout@gmail.com/
Ah, I see now. Sorry for the noise!
--
Best regards,
Mikhail Rudenko
WARNING: multiple messages have this Message-ID (diff)
From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: Samuel Holland <samuel@sholland.org>
Cc: stable@vger.kernel.org, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Fix otg port initialization
Date: Sun, 18 Sep 2022 20:46:33 +0300 [thread overview]
Message-ID: <87tu54r2w1.fsf@gmail.com> (raw)
In-Reply-To: <6779635c-a162-0b7e-d124-d88d1ed9e162@sholland.org>
On 2022-09-17 at 12:12 -05, Samuel Holland <samuel@sholland.org> wrote:
> On 9/17/22 11:58, Mikhail Rudenko wrote:
>> There are two issues in rockchip_usb2phy_otg_port_init(): (1) even if
>> devm_extcon_register_notifier() returns error, the code proceeds to
>> the next if statement and (2) if no extcon is defined in of_node, the
>> return value of property_enabled() is reused as the return value of
>> the whole function. If the return value of property_enable() is
>> nonzero, (2) results in an unexpected probe failure and kernel panic
>> in delayed work:
>
> This should be fixed by the following patch which is accepted already:
>
> https://lore.kernel.org/lkml/20220902184543.1234835-1-pgwipeout@gmail.com/
Ah, I see now. Sorry for the noise!
--
Best regards,
Mikhail Rudenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-18 17:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 16:58 [PATCH] phy: rockchip-inno-usb2: Fix otg port initialization Mikhail Rudenko
2022-09-17 16:58 ` Mikhail Rudenko
2022-09-17 16:58 ` Mikhail Rudenko
2022-09-17 16:58 ` Mikhail Rudenko
2022-09-17 17:12 ` Samuel Holland
2022-09-17 17:12 ` Samuel Holland
2022-09-17 17:12 ` Samuel Holland
2022-09-17 17:12 ` Samuel Holland
2022-09-18 17:46 ` Mikhail Rudenko [this message]
2022-09-18 17:46 ` Mikhail Rudenko
2022-09-18 17:46 ` Mikhail Rudenko
2022-09-18 17:46 ` Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu54r2w1.fsf@gmail.com \
--to=mike.rudenko@gmail.com \
--cc=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=samuel@sholland.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.