Re: [PATCH 1/4] ath10k: improve tx status reporting

From: Kalle Valo <kvalo@kernel.org>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	"Edward Matijevic" <motolav@gmail.com>,
	"John Crispin" <john@phrozen.org>,
	"Oldřich Jedlička" <oldium.pro@gmail.com>,
	"Tom Psyborg" <pozega.tomislav@gmail.com>,
	"Vasanthakumar Thiagarajan" <vthiagar@qti.qualcomm.com>,
	"Zhijun You" <hujy652@gmail.com>
Subject: Re: [PATCH 1/4] ath10k: improve tx status reporting
Date: Wed, 18 May 2022 10:30:01 +0300	[thread overview]
Message-ID: <87tu9n2t8m.fsf@kernel.org> (raw)
In-Reply-To: <CAHNKnsS2_vVPZT-PSjNDzfQmyXEaOJNO8MHqVfntN=GSG3P_Ng@mail.gmail.com> (Sergey Ryazanov's message of "Mon, 16 May 2022 23:57:34 +0300")

Sergey Ryazanov <ryazanov.s.a@gmail.com> writes:
> On Mon, May 16, 2022 at 6:25 AM Sergey Ryazanov <ryazanov.s.a@gmail.com> wrote:
>
>> --- a/drivers/net/wireless/ath/ath10k/txrx.c
>> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
>> @@ -43,6 +43,7 @@ static void ath10k_report_offchan_tx(struct ath10k *ar, struct sk_buff *skb)
>>  int ath10k_txrx_tx_unref(struct ath10k_htt *htt,
>>                          const struct htt_tx_done *tx_done)
>>  {
>> +       struct ieee80211_tx_status status;
>>         struct ath10k *ar = htt->ar;
>>         struct device *dev = ar->dev;
>>         struct ieee80211_tx_info *info;
>> @@ -128,7 +129,16 @@ int ath10k_txrx_tx_unref(struct ath10k_htt *htt,
>>                 info->status.flags |= IEEE80211_TX_STATUS_ACK_SIGNAL_VALID;
>>         }
>>
>> -       ieee80211_tx_status(htt->ar->hw, msdu);
>> +       memset(&status, 0, sizeof(status));
>> +       status.skb = msdu;
>> +       status.info = info;
>> +
>> +       rcu_read_lock();
>> +       if (txq && txq->sta)
>> +               status.sta = txq->sta;
>
> Just noticed that since we do not dereference the txq->sta pointer
> here, the above code can be simplified to:
>
> if (txq)
>         status.sta = txq->sta;
>
> Kalle, should I send V2 or can you change this in your tree?

I changed this in the pending branch, please check my changes:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=1bd0c16e10229683fab1dd8adf8c4339992688b7

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k