All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: Changbin Du <changbin.du@gmail.com>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	 linux-riscv <linux-riscv@lists.infradead.org>,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: eliminate unreliable __builtin_frame_address(1)
Date: Thu, 20 Jan 2022 00:53:07 +0100	[thread overview]
Message-ID: <87tudz5llo.fsf@igel.home> (raw)
In-Reply-To: <BD64D67C-613B-495E-9FB7-2AFB6FA15308@jrtc27.com> (Jessica Clarke's message of "Wed, 19 Jan 2022 21:27:46 +0000")

On Jan 19 2022, Jessica Clarke wrote:

> What’s your point?

LLVM doesn't have to deal with the extra complexity.

> doesn’t mean other toolchains that do need that to be correct should
> just do something wrong.

__builtin_frame_address with count > 0 is considered bad.  Nobody should
use it.

You don't have to be arrogant.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: Changbin Du <changbin.du@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: eliminate unreliable __builtin_frame_address(1)
Date: Thu, 20 Jan 2022 00:53:07 +0100	[thread overview]
Message-ID: <87tudz5llo.fsf@igel.home> (raw)
In-Reply-To: <BD64D67C-613B-495E-9FB7-2AFB6FA15308@jrtc27.com> (Jessica Clarke's message of "Wed, 19 Jan 2022 21:27:46 +0000")

On Jan 19 2022, Jessica Clarke wrote:

> What’s your point?

LLVM doesn't have to deal with the extra complexity.

> doesn’t mean other toolchains that do need that to be correct should
> just do something wrong.

__builtin_frame_address with count > 0 is considered bad.  Nobody should
use it.

You don't have to be arrogant.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  reply	other threads:[~2022-01-19 23:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 15:44 [PATCH] riscv: eliminate unreliable __builtin_frame_address(1) Changbin Du
2022-01-17 15:44 ` Changbin Du
2022-01-17 16:10 ` Andreas Schwab
2022-01-17 16:10   ` Andreas Schwab
2022-01-17 17:33 ` Jessica Clarke
2022-01-17 17:33   ` Jessica Clarke
2022-01-19 10:58   ` Andreas Schwab
2022-01-19 10:58     ` Andreas Schwab
2022-01-19 19:05     ` Jessica Clarke
2022-01-19 19:05       ` Jessica Clarke
2022-01-19 20:44       ` Andreas Schwab
2022-01-19 20:44         ` Andreas Schwab
2022-01-19 20:48         ` Jessica Clarke
2022-01-19 20:48           ` Jessica Clarke
2022-01-19 21:07           ` Andreas Schwab
2022-01-19 21:07             ` Andreas Schwab
2022-01-19 21:27             ` Jessica Clarke
2022-01-19 21:27               ` Jessica Clarke
2022-01-19 23:53               ` Andreas Schwab [this message]
2022-01-19 23:53                 ` Andreas Schwab
2022-01-20  0:15                 ` Palmer Dabbelt
2022-01-20  0:15                   ` Palmer Dabbelt
2022-02-04 21:56 ` Palmer Dabbelt
2022-02-04 21:56   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tudz5llo.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=changbin.du@gmail.com \
    --cc=jrtc27@jrtc27.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.