From: Cornelia Huck <cohuck@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>, David Airlie <airlied@linux.ie>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>,
Diana Craciun <diana.craciun@oss.nxp.com>,
dri-devel@lists.freedesktop.org,
Eric Auger <eric.auger@redhat.com>,
Eric Farman <farman@linux.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Jason Herne <jjherne@linux.ibm.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
kvm@vger.kernel.org, Kirti Wankhede <kwankhede@nvidia.com>,
linux-doc@vger.kernel.org, linux-s390@vger.kernel.org,
Matthew Rosato <mjrosato@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Zhi Wang <zhi.a.wang@intel.com>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
Christoph Hellwig <hch@lst.de>,
Leon Romanovsky <leonro@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH v4 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set
Date: Wed, 11 Aug 2021 12:33:01 +0200 [thread overview]
Message-ID: <87tujwuv8i.fsf@redhat.com> (raw)
In-Reply-To: <10-v4-9ea22c5e6afb+1adf-vfio_reflck_jgg@nvidia.com>
On Thu, Aug 05 2021, Jason Gunthorpe <jgg@nvidia.com> wrote:
> Like vfio_pci_dev_set_try_reset() this code wants to reset all of the
> devices in the "reset group" which is the same membership as the device
> set.
>
> Instead of trying to reconstruct the device set from the PCI list go
> directly from the device set's device list to execute the reset.
>
> The same basic structure as vfio_pci_dev_set_try_reset() is used. The
> 'vfio_devices' struct is replaced with the device set linked list and we
> simply sweep it multiple times under the lock.
>
> This eliminates a memory allocation and get/put traffic and another
> improperly locked test of pci_dev_driver().
>
> Reviewed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/pci/vfio_pci.c | 213 +++++++++++++++---------------------
> 1 file changed, 89 insertions(+), 124 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>, David Airlie <airlied@linux.ie>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>,
Diana Craciun <diana.craciun@oss.nxp.com>,
dri-devel@lists.freedesktop.org,
Eric Auger <eric.auger@redhat.com>,
Eric Farman <farman@linux.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Jason Herne <jjherne@linux.ibm.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
kvm@vger.kernel.org, Kirti Wankhede <kwankhede@nvidia.com>,
linux-doc@vger.kernel.org, linux-s390@vger.kernel.org,
Matthew Rosato <mjrosato@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Zhi Wang <zhi.a.wang@intel.com>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
Christoph Hellwig <hch@lst.de>,
Leon Romanovsky <leonro@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH v4 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set
Date: Wed, 11 Aug 2021 12:33:01 +0200 [thread overview]
Message-ID: <87tujwuv8i.fsf@redhat.com> (raw)
In-Reply-To: <10-v4-9ea22c5e6afb+1adf-vfio_reflck_jgg@nvidia.com>
On Thu, Aug 05 2021, Jason Gunthorpe <jgg@nvidia.com> wrote:
> Like vfio_pci_dev_set_try_reset() this code wants to reset all of the
> devices in the "reset group" which is the same membership as the device
> set.
>
> Instead of trying to reconstruct the device set from the PCI list go
> directly from the device set's device list to execute the reset.
>
> The same basic structure as vfio_pci_dev_set_try_reset() is used. The
> 'vfio_devices' struct is replaced with the device set linked list and we
> simply sweep it multiple times under the lock.
>
> This eliminates a memory allocation and get/put traffic and another
> improperly locked test of pci_dev_driver().
>
> Reviewed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/vfio/pci/vfio_pci.c | 213 +++++++++++++++---------------------
> 1 file changed, 89 insertions(+), 124 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2021-08-11 10:33 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 1:18 [Intel-gfx] [PATCH v4 00/14] Provide core infrastructure for managing open/release Jason Gunthorpe
2021-08-06 1:18 ` Jason Gunthorpe
2021-08-06 1:18 ` [Intel-gfx] [PATCH v4 01/14] vfio/samples: Remove module get/put Jason Gunthorpe
2021-08-06 1:18 ` Jason Gunthorpe
2021-08-08 8:54 ` [Intel-gfx] " Max Gurtovoy
2021-08-08 8:54 ` Max Gurtovoy
2021-08-06 1:18 ` [Intel-gfx] [PATCH v4 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes Jason Gunthorpe
2021-08-06 1:18 ` Jason Gunthorpe
2021-08-11 9:17 ` [Intel-gfx] " Cornelia Huck
2021-08-11 9:17 ` Cornelia Huck
2021-08-06 1:18 ` [Intel-gfx] [PATCH v4 03/14] vfio: Introduce a vfio_uninit_group_dev() API call Jason Gunthorpe
2021-08-06 1:18 ` Jason Gunthorpe
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 04/14] vfio: Provide better generic support for open/release vfio_device_ops Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 05/14] vfio/samples: Delete useless open/close Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 06/14] vfio/fsl: Move to the device set infrastructure Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 08/14] vfio/pci: Move to the device set infrastructure Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-11 9:35 ` [Intel-gfx] " Cornelia Huck
2021-08-11 9:35 ` Cornelia Huck
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-10 8:26 ` [Intel-gfx] " Christoph Hellwig
2021-08-10 8:26 ` Christoph Hellwig
2021-08-11 10:14 ` [Intel-gfx] " Cornelia Huck
2021-08-11 10:14 ` Cornelia Huck
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-11 10:33 ` Cornelia Huck [this message]
2021-08-11 10:33 ` Cornelia Huck
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 11/14] vfio/mbochs: Fix close when multiple device FDs are open Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 12/14] vfio/ap, ccw: Fix open/close " Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-06 1:19 ` [PATCH v4 12/14] vfio/ap,ccw: " Jason Gunthorpe
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 13/14] vfio/gvt: " Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-06 1:19 ` [Intel-gfx] [PATCH v4 14/14] vfio: Remove struct vfio_device_ops open/release Jason Gunthorpe
2021-08-06 1:19 ` Jason Gunthorpe
2021-08-11 10:35 ` [Intel-gfx] " Cornelia Huck
2021-08-11 10:35 ` Cornelia Huck
2021-08-06 1:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Provide core infrastructure for managing open/release (rev9) Patchwork
2021-08-06 2:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-08-11 22:08 ` [Intel-gfx] [PATCH v4 00/14] Provide core infrastructure for managing open/release Alex Williamson
2021-08-11 22:08 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tujwuv8i.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=diana.craciun@oss.nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.auger@redhat.com \
--cc=farman@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=rodrigo.vivi@intel.com \
--cc=vneethv@linux.ibm.com \
--cc=yishaih@nvidia.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.