* [Intel-gfx] [PATCH] drm/i915/selftests: Add a mock i915_vma to the mock_ring
@ 2020-01-14 12:49 Chris Wilson
2020-01-14 12:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2020-01-14 12:49 UTC (permalink / raw)
To: intel-gfx
Add a i915_vma to the mock_engine/mock_ring so that the core code can
always assume the presence of ring->vma.
Fixes: 8ccfc20a7d56 ("drm/i915/gt: Mark ring->vma as active while pinned")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/mock_engine.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/mock_engine.c b/drivers/gpu/drm/i915/gt/mock_engine.c
index a560b7eee2cd..54bd5461738b 100644
--- a/drivers/gpu/drm/i915/gt/mock_engine.c
+++ b/drivers/gpu/drm/i915/gt/mock_engine.c
@@ -59,6 +59,13 @@ static struct intel_ring *mock_ring(struct intel_engine_cs *engine)
ring->vaddr = (void *)(ring + 1);
atomic_set(&ring->pin_count, 1);
+ ring->vma = i915_vma_alloc();
+ if (ring->vma == NULL) {
+ kfree(ring);
+ return NULL;
+ }
+ i915_active_init(&ring->vma->active, NULL, NULL);
+
intel_ring_update_space(ring);
return ring;
@@ -121,6 +128,7 @@ static void mock_context_destroy(struct kref *ref)
GEM_BUG_ON(intel_context_is_pinned(ce));
if (test_bit(CONTEXT_ALLOC_BIT, &ce->flags)) {
+ i915_vma_free(ce->ring->vma);
kfree(ce->ring);
mock_timeline_unpin(ce->timeline);
}
--
2.25.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Add a mock i915_vma to the mock_ring
2020-01-14 12:49 [Intel-gfx] [PATCH] drm/i915/selftests: Add a mock i915_vma to the mock_ring Chris Wilson
@ 2020-01-14 12:57 ` Patchwork
2020-01-14 13:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-01-14 12:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Add a mock i915_vma to the mock_ring
URL : https://patchwork.freedesktop.org/series/72005/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
63ab231fcfb0 drm/i915/selftests: Add a mock i915_vma to the mock_ring
-:21: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!ring->vma"
#21: FILE: drivers/gpu/drm/i915/gt/mock_engine.c:63:
+ if (ring->vma == NULL) {
total: 0 errors, 0 warnings, 1 checks, 20 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Add a mock i915_vma to the mock_ring
2020-01-14 12:49 [Intel-gfx] [PATCH] drm/i915/selftests: Add a mock i915_vma to the mock_ring Chris Wilson
2020-01-14 12:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-01-14 13:31 ` Patchwork
2020-01-14 13:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-14 15:55 ` [Intel-gfx] [PATCH] " Mika Kuoppala
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-01-14 13:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Add a mock i915_vma to the mock_ring
URL : https://patchwork.freedesktop.org/series/72005/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7738 -> Patchwork_16092
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/index.html
Known issues
------------
Here are the changes found in Patchwork_16092 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gt_lrc:
- fi-skl-6600u: [PASS][1] -> [DMESG-FAIL][2] ([i915#889]) +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-skl-6600u/igt@i915_selftest@live_gt_lrc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-skl-6600u/igt@i915_selftest@live_gt_lrc.html
* igt@i915_selftest@live_late_gt_pm:
- fi-skl-6600u: [PASS][3] -> [DMESG-WARN][4] ([i915#889]) +23 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-skl-6600u/igt@i915_selftest@live_late_gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-skl-6600u/igt@i915_selftest@live_late_gt_pm.html
#### Possible fixes ####
* igt@gem_exec_parallel@basic:
- {fi-ehl-1}: [INCOMPLETE][5] ([i915#937]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-ehl-1/igt@gem_exec_parallel@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-ehl-1/igt@gem_exec_parallel@basic.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-dsi: [INCOMPLETE][7] ([i915#140]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-icl-dsi/igt@gem_exec_suspend@basic-s4-devices.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-icl-dsi/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-cfl-8700k: [INCOMPLETE][9] ([i915#505]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
- fi-skl-lmem: [INCOMPLETE][11] ([i915#671]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][13] ([i915#725]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-hsw-4770/igt@i915_selftest@live_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [DMESG-FAIL][15] ([i915#722]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
#### Warnings ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][17] ([i915#725]) -> [DMESG-FAIL][18] ([i915#563])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7738/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/fi-hsw-4770r/igt@i915_selftest@live_blt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#505]: https://gitlab.freedesktop.org/drm/intel/issues/505
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#591]: https://gitlab.freedesktop.org/drm/intel/issues/591
[i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
[i915#710]: https://gitlab.freedesktop.org/drm/intel/issues/710
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#879]: https://gitlab.freedesktop.org/drm/intel/issues/879
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937
Participating hosts (52 -> 48)
------------------------------
Additional (2): fi-bsw-kefka fi-tgl-y
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7738 -> Patchwork_16092
CI-20190529: 20190529
CI_DRM_7738: 246c70d322d6d79049dde29bb1117d4fd62a0276 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5365: e9ec0ed63b25c86861ffac3c8601cc4d1b910b65 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16092: 63ab231fcfb03b408c9cbf867fadcf94660af902 @ git://anongit.freedesktop.org/gfx-ci/linux
== Kernel 32bit build ==
Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/Patchwork_16092/build_32bit.log
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 122 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
scripts/Makefile.modpost:93: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1282: recipe for target 'modules' failed
make: *** [modules] Error 2
== Linux commits ==
63ab231fcfb0 drm/i915/selftests: Add a mock i915_vma to the mock_ring
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* [Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/selftests: Add a mock i915_vma to the mock_ring
2020-01-14 12:49 [Intel-gfx] [PATCH] drm/i915/selftests: Add a mock i915_vma to the mock_ring Chris Wilson
2020-01-14 12:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-01-14 13:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-01-14 13:31 ` Patchwork
2020-01-14 15:55 ` [Intel-gfx] [PATCH] " Mika Kuoppala
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-01-14 13:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Add a mock i915_vma to the mock_ring
URL : https://patchwork.freedesktop.org/series/72005/
State : warning
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 122 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
scripts/Makefile.modpost:93: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1282: recipe for target 'modules' failed
make: *** [modules] Error 2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16092/build_32bit.log
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add a mock i915_vma to the mock_ring
2020-01-14 12:49 [Intel-gfx] [PATCH] drm/i915/selftests: Add a mock i915_vma to the mock_ring Chris Wilson
` (2 preceding siblings ...)
2020-01-14 13:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
@ 2020-01-14 15:55 ` Mika Kuoppala
3 siblings, 0 replies; 5+ messages in thread
From: Mika Kuoppala @ 2020-01-14 15:55 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Add a i915_vma to the mock_engine/mock_ring so that the core code can
> always assume the presence of ring->vma.
>
> Fixes: 8ccfc20a7d56 ("drm/i915/gt: Mark ring->vma as active while pinned")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/mock_engine.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/mock_engine.c b/drivers/gpu/drm/i915/gt/mock_engine.c
> index a560b7eee2cd..54bd5461738b 100644
> --- a/drivers/gpu/drm/i915/gt/mock_engine.c
> +++ b/drivers/gpu/drm/i915/gt/mock_engine.c
> @@ -59,6 +59,13 @@ static struct intel_ring *mock_ring(struct intel_engine_cs *engine)
> ring->vaddr = (void *)(ring + 1);
> atomic_set(&ring->pin_count, 1);
>
> + ring->vma = i915_vma_alloc();
> + if (ring->vma == NULL) {
> + kfree(ring);
> + return NULL;
> + }
> + i915_active_init(&ring->vma->active, NULL, NULL);
> +
> intel_ring_update_space(ring);
>
> return ring;
> @@ -121,6 +128,7 @@ static void mock_context_destroy(struct kref *ref)
> GEM_BUG_ON(intel_context_is_pinned(ce));
>
> if (test_bit(CONTEXT_ALLOC_BIT, &ce->flags)) {
> + i915_vma_free(ce->ring->vma);
> kfree(ce->ring);
> mock_timeline_unpin(ce->timeline);
with i915_active_fini() added also,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> }
> --
> 2.25.0.rc2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-14 15:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-14 12:49 [Intel-gfx] [PATCH] drm/i915/selftests: Add a mock i915_vma to the mock_ring Chris Wilson
2020-01-14 12:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-01-14 13:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-14 13:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-14 15:55 ` [Intel-gfx] [PATCH] " Mika Kuoppala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.