* [igt-dev] [PATCH 0/2] Check if get/set tiling is supported
@ 2019-11-15 5:33 Vanshidhar Konda
2019-11-15 5:33 ` [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Vanshidhar Konda
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Vanshidhar Konda @ 2019-11-15 5:33 UTC (permalink / raw)
To: igt-dev; +Cc: brian.welty
With Gen12 hardware, the GET/SET_TILING IOCTLs return EOPNOTSUPP error.
This change impacts usermode code. See this link for more discussion
about this change:
https://patchwork.freedesktop.org/patch/325343/
IGT tests have to be updated to check if these IOCTLs are supported.
Vanshidhar Konda (2):
lib/ioctl_wrappers: Query if device supports set/get legacy tiling
i915/i915_fb_tiling: Check if device supports tiling
lib/ioctl_wrappers.c | 16 ++++++++++++++++
lib/ioctl_wrappers.h | 1 +
tests/i915/i915_fb_tiling.c | 2 ++
3 files changed, 19 insertions(+)
--
2.24.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread* [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling 2019-11-15 5:33 [igt-dev] [PATCH 0/2] Check if get/set tiling is supported Vanshidhar Konda @ 2019-11-15 5:33 ` Vanshidhar Konda 2019-11-15 5:42 ` Dixit, Ashutosh 2019-11-15 5:33 ` [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling Vanshidhar Konda ` (2 subsequent siblings) 3 siblings, 1 reply; 11+ messages in thread From: Vanshidhar Konda @ 2019-11-15 5:33 UTC (permalink / raw) To: igt-dev; +Cc: brian.welty Add a method to query if the device supports setting and getting legacy tiling formats for buffer objects. Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com> --- lib/ioctl_wrappers.c | 16 ++++++++++++++++ lib/ioctl_wrappers.h | 1 + 2 files changed, 17 insertions(+) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 628f8b83..837ef2cf 100644 --- a/lib/ioctl_wrappers.c +++ b/lib/ioctl_wrappers.c @@ -133,6 +133,22 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg) return err; } +/** + * gem_has_legacy_hw_tiling: + * @fd: open i915 drm file descriptor + * + * Feature check to query if the device supports setting/getting + * legacy tiling formats for buffer objects + * + * Returns: True if tiling is supported + */ +bool +gem_has_legacy_hw_tiling(int fd) +{ + struct drm_i915_gem_get_tiling arg = {}; + return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP); +} + /** * gem_get_tiling: * @fd: open i915 drm file descriptor diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h index 03211c97..c9c96902 100644 --- a/lib/ioctl_wrappers.h +++ b/lib/ioctl_wrappers.h @@ -145,6 +145,7 @@ void gem_require_caching(int fd); void gem_require_ring(int fd, unsigned ring); bool gem_has_mocs_registers(int fd); void gem_require_mocs_registers(int fd); +bool gem_has_legacy_hw_tiling(int fd); #define gem_has_ring(f, r) gem_context_has_engine(f, 0, r) -- 2.24.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling 2019-11-15 5:33 ` [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Vanshidhar Konda @ 2019-11-15 5:42 ` Dixit, Ashutosh 2019-11-15 5:50 ` Vanshidhar Konda 0 siblings, 1 reply; 11+ messages in thread From: Dixit, Ashutosh @ 2019-11-15 5:42 UTC (permalink / raw) To: Vanshidhar Konda; +Cc: igt-dev, brian.welty On Thu, 14 Nov 2019 21:33:25 -0800, Vanshidhar Konda wrote: > > Add a method to query if the device supports setting and > getting legacy tiling formats for buffer objects. > > Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com> > --- > lib/ioctl_wrappers.c | 16 ++++++++++++++++ > lib/ioctl_wrappers.h | 1 + > 2 files changed, 17 insertions(+) > > diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c > index 628f8b83..837ef2cf 100644 > --- a/lib/ioctl_wrappers.c > +++ b/lib/ioctl_wrappers.c > @@ -133,6 +133,22 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg) > return err; > } > > +/** > + * gem_has_legacy_hw_tiling: > + * @fd: open i915 drm file descriptor > + * > + * Feature check to query if the device supports setting/getting > + * legacy tiling formats for buffer objects > + * > + * Returns: True if tiling is supported > + */ > +bool > +gem_has_legacy_hw_tiling(int fd) > +{ > + struct drm_i915_gem_get_tiling arg = {}; > + return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP); Probably just return !__gem_get_tiling(fd, &arg); That is, no need to check for specific error code? _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling 2019-11-15 5:42 ` Dixit, Ashutosh @ 2019-11-15 5:50 ` Vanshidhar Konda 2019-11-15 18:16 ` Dixit, Ashutosh 0 siblings, 1 reply; 11+ messages in thread From: Vanshidhar Konda @ 2019-11-15 5:50 UTC (permalink / raw) To: Dixit, Ashutosh; +Cc: igt-dev, brian.welty On Thu, Nov 14, 2019 at 09:42:24PM -0800, Dixit, Ashutosh wrote: >On Thu, 14 Nov 2019 21:33:25 -0800, Vanshidhar Konda wrote: >> >> Add a method to query if the device supports setting and >> getting legacy tiling formats for buffer objects. >> >> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com> >> --- >> lib/ioctl_wrappers.c | 16 ++++++++++++++++ >> lib/ioctl_wrappers.h | 1 + >> 2 files changed, 17 insertions(+) >> >> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c >> index 628f8b83..837ef2cf 100644 >> --- a/lib/ioctl_wrappers.c >> +++ b/lib/ioctl_wrappers.c >> @@ -133,6 +133,22 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg) >> return err; >> } >> >> +/** >> + * gem_has_legacy_hw_tiling: >> + * @fd: open i915 drm file descriptor >> + * >> + * Feature check to query if the device supports setting/getting >> + * legacy tiling formats for buffer objects >> + * >> + * Returns: True if tiling is supported >> + */ >> +bool >> +gem_has_legacy_hw_tiling(int fd) >> +{ >> + struct drm_i915_gem_get_tiling arg = {}; >> + return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP); > >Probably just > > return !__gem_get_tiling(fd, &arg); No. Only this specific error means it is not supported by the hardware. Other errors could mean that I made a mistake with the arguments - I've not set them to valid values. Vanshi > >That is, no need to check for specific error code? _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling 2019-11-15 5:50 ` Vanshidhar Konda @ 2019-11-15 18:16 ` Dixit, Ashutosh 2019-11-15 18:51 ` Vanshidhar Konda 0 siblings, 1 reply; 11+ messages in thread From: Dixit, Ashutosh @ 2019-11-15 18:16 UTC (permalink / raw) To: Vanshidhar Konda; +Cc: igt-dev, brian.welty On Thu, 14 Nov 2019 21:50:39 -0800, Vanshidhar Konda wrote: > > On Thu, Nov 14, 2019 at 09:42:24PM -0800, Dixit, Ashutosh wrote: > > On Thu, 14 Nov 2019 21:33:25 -0800, Vanshidhar Konda wrote: > >> > >> Add a method to query if the device supports setting and > >> getting legacy tiling formats for buffer objects. > >> > >> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com> > >> --- > >> lib/ioctl_wrappers.c | 16 ++++++++++++++++ > >> lib/ioctl_wrappers.h | 1 + > >> 2 files changed, 17 insertions(+) > >> > >> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c > >> index 628f8b83..837ef2cf 100644 > >> --- a/lib/ioctl_wrappers.c > >> +++ b/lib/ioctl_wrappers.c > >> @@ -133,6 +133,22 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg) > >> return err; > >> } > >> > >> +/** > >> + * gem_has_legacy_hw_tiling: > >> + * @fd: open i915 drm file descriptor > >> + * > >> + * Feature check to query if the device supports setting/getting > >> + * legacy tiling formats for buffer objects > >> + * > >> + * Returns: True if tiling is supported > >> + */ > >> +bool > >> +gem_has_legacy_hw_tiling(int fd) > >> +{ > >> + struct drm_i915_gem_get_tiling arg = {}; > >> + return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP); > > > > Probably just > > > > return !__gem_get_tiling(fd, &arg); > > No. Only this specific error means it is not supported by the hardware. > Other errors could mean that I made a mistake with the arguments - I've > not set them to valid values. __gem_get_tiling() returns 0 if tiling is supported, it returns -EOPNOTSUPP if tiling is not supported and if it returns anything else we don't know if tiling is supported or not supported (error in arguments etc.). So if gem_has_legacy_hw_tiling() is to definitively indicate tiling is supported it should just: return !__gem_get_tiling(fd, &arg); For example, if __gem_get_tiling() returns -EINVAL I don't think we want to return true from gem_has_legacy_hw_tiling(). _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling 2019-11-15 18:16 ` Dixit, Ashutosh @ 2019-11-15 18:51 ` Vanshidhar Konda 2019-11-15 22:27 ` Dixit, Ashutosh 0 siblings, 1 reply; 11+ messages in thread From: Vanshidhar Konda @ 2019-11-15 18:51 UTC (permalink / raw) To: Dixit, Ashutosh; +Cc: igt-dev, brian.welty On Fri, Nov 15, 2019 at 10:16:19AM -0800, Dixit, Ashutosh wrote: >On Thu, 14 Nov 2019 21:50:39 -0800, Vanshidhar Konda wrote: >> >> On Thu, Nov 14, 2019 at 09:42:24PM -0800, Dixit, Ashutosh wrote: >> > On Thu, 14 Nov 2019 21:33:25 -0800, Vanshidhar Konda wrote: >> >> >> >> Add a method to query if the device supports setting and >> >> getting legacy tiling formats for buffer objects. >> >> >> >> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com> >> >> --- >> >> lib/ioctl_wrappers.c | 16 ++++++++++++++++ >> >> lib/ioctl_wrappers.h | 1 + >> >> 2 files changed, 17 insertions(+) >> >> >> >> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c >> >> index 628f8b83..837ef2cf 100644 >> >> --- a/lib/ioctl_wrappers.c >> >> +++ b/lib/ioctl_wrappers.c >> >> @@ -133,6 +133,22 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg) >> >> return err; >> >> } >> >> >> >> +/** >> >> + * gem_has_legacy_hw_tiling: >> >> + * @fd: open i915 drm file descriptor >> >> + * >> >> + * Feature check to query if the device supports setting/getting >> >> + * legacy tiling formats for buffer objects >> >> + * >> >> + * Returns: True if tiling is supported >> >> + */ >> >> +bool >> >> +gem_has_legacy_hw_tiling(int fd) >> >> +{ >> >> + struct drm_i915_gem_get_tiling arg = {}; >> >> + return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP); >> > >> > Probably just >> > >> > return !__gem_get_tiling(fd, &arg); >> >> No. Only this specific error means it is not supported by the hardware. >> Other errors could mean that I made a mistake with the arguments - I've >> not set them to valid values. > >__gem_get_tiling() returns 0 if tiling is supported, it returns -EOPNOTSUPP >if tiling is not supported and if it returns anything else we don't know if >tiling is supported or not supported (error in arguments etc.). So if >gem_has_legacy_hw_tiling() is to definitively indicate tiling is supported >it should just: > > return !__gem_get_tiling(fd, &arg); > >For example, if __gem_get_tiling() returns -EINVAL I don't think we want to >return true from gem_has_legacy_hw_tiling(). The basis of my change is the assumption that GET/SET_TILING is supported by default. All user mode code today is written with the assumption that this is true. Only the return of EOPNOTSUPP indicates that it is not supported on the device. Even return of EINVAL would mean that it is supported but the argument passed is incorrect. Vanshi > > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling 2019-11-15 18:51 ` Vanshidhar Konda @ 2019-11-15 22:27 ` Dixit, Ashutosh 0 siblings, 0 replies; 11+ messages in thread From: Dixit, Ashutosh @ 2019-11-15 22:27 UTC (permalink / raw) To: Vanshidhar Konda; +Cc: igt-dev, brian.welty On Fri, 15 Nov 2019 10:51:54 -0800, Vanshidhar Konda wrote: > > On Fri, Nov 15, 2019 at 10:16:19AM -0800, Dixit, Ashutosh wrote: > > On Thu, 14 Nov 2019 21:50:39 -0800, Vanshidhar Konda wrote: > >> > >> On Thu, Nov 14, 2019 at 09:42:24PM -0800, Dixit, Ashutosh wrote: > >> > On Thu, 14 Nov 2019 21:33:25 -0800, Vanshidhar Konda wrote: > >> >> > >> >> Add a method to query if the device supports setting and > >> >> getting legacy tiling formats for buffer objects. > >> >> > >> >> Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com> > >> >> --- > >> >> lib/ioctl_wrappers.c | 16 ++++++++++++++++ > >> >> lib/ioctl_wrappers.h | 1 + > >> >> 2 files changed, 17 insertions(+) > >> >> > >> >> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c > >> >> index 628f8b83..837ef2cf 100644 > >> >> --- a/lib/ioctl_wrappers.c > >> >> +++ b/lib/ioctl_wrappers.c > >> >> @@ -133,6 +133,22 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg) > >> >> return err; > >> >> } > >> >> > >> >> +/** > >> >> + * gem_has_legacy_hw_tiling: > >> >> + * @fd: open i915 drm file descriptor > >> >> + * > >> >> + * Feature check to query if the device supports setting/getting > >> >> + * legacy tiling formats for buffer objects > >> >> + * > >> >> + * Returns: True if tiling is supported > >> >> + */ > >> >> +bool > >> >> +gem_has_legacy_hw_tiling(int fd) > >> >> +{ > >> >> + struct drm_i915_gem_get_tiling arg = {}; > >> >> + return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP); > >> > > >> > Probably just > >> > > >> > return !__gem_get_tiling(fd, &arg); > >> > >> No. Only this specific error means it is not supported by the hardware. > >> Other errors could mean that I made a mistake with the arguments - I've > >> not set them to valid values. > > > > __gem_get_tiling() returns 0 if tiling is supported, it returns -EOPNOTSUPP > > if tiling is not supported and if it returns anything else we don't know if > > tiling is supported or not supported (error in arguments etc.). So if > > gem_has_legacy_hw_tiling() is to definitively indicate tiling is supported > > it should just: > > > > return !__gem_get_tiling(fd, &arg); > > > > For example, if __gem_get_tiling() returns -EINVAL I don't think we want to > > return true from gem_has_legacy_hw_tiling(). > > The basis of my change is the assumption that GET/SET_TILING is > supported by default. All user mode code today is written with the > assumption that this is true. Only the return of EOPNOTSUPP indicates that > it is not supported on the device. Even return of EINVAL would mean that it is > supported but the argument passed is incorrect. OK, finally understand that this way of doing it allows gem_has_legacy_hw_tiling() be called without a valid gem object. A comment would help but since the function doesn't take a gem object as an input anyway, I guess it's fine as is too. Perhaps need an empty line between the declaration and the following statement to keep static checkers happy? With that: Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling 2019-11-15 5:33 [igt-dev] [PATCH 0/2] Check if get/set tiling is supported Vanshidhar Konda 2019-11-15 5:33 ` [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Vanshidhar Konda @ 2019-11-15 5:33 ` Vanshidhar Konda 2019-11-15 6:24 ` [igt-dev] ✓ Fi.CI.BAT: success for Check if get/set tiling is supported Patchwork 2019-11-16 12:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 11+ messages in thread From: Vanshidhar Konda @ 2019-11-15 5:33 UTC (permalink / raw) To: igt-dev; +Cc: brian.welty Skip this test if the platform does not support setting tiling for frame buffer object. Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com> --- tests/i915/i915_fb_tiling.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/i915/i915_fb_tiling.c b/tests/i915/i915_fb_tiling.c index 7d5c3f1f..4ec84962 100644 --- a/tests/i915/i915_fb_tiling.c +++ b/tests/i915/i915_fb_tiling.c @@ -32,6 +32,8 @@ igt_simple_main struct igt_fb fb; int ret; + igt_require(gem_has_legacy_hw_tiling(drm_fd)); + igt_create_fb(drm_fd, 512, 512, DRM_FORMAT_XRGB8888, LOCAL_I915_FORMAT_MOD_X_TILED, &fb); -- 2.24.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Check if get/set tiling is supported 2019-11-15 5:33 [igt-dev] [PATCH 0/2] Check if get/set tiling is supported Vanshidhar Konda 2019-11-15 5:33 ` [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Vanshidhar Konda 2019-11-15 5:33 ` [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling Vanshidhar Konda @ 2019-11-15 6:24 ` Patchwork 2019-11-16 12:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-11-15 6:24 UTC (permalink / raw) To: Vanshidhar Konda; +Cc: igt-dev == Series Details == Series: Check if get/set tiling is supported URL : https://patchwork.freedesktop.org/series/69503/ State : success == Summary == CI Bug Log - changes from CI_DRM_7349 -> IGTPW_3709 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/index.html Known issues ------------ Here are the changes found in IGTPW_3709 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([fdo#107407]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/fi-bsw-kefka/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/fi-bsw-kefka/igt@gem_exec_suspend@basic-s3.html * igt@i915_pm_rpm@module-reload: - fi-icl-guc: [PASS][3] -> [DMESG-WARN][4] ([fdo#106107]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/fi-icl-guc/igt@i915_pm_rpm@module-reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/fi-icl-guc/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live_gem_contexts: - fi-bsw-kefka: [PASS][5] -> [INCOMPLETE][6] ([fdo# 111542]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([fdo#111045] / [fdo#111096]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html #### Possible fixes #### * igt@i915_pm_rpm@module-reload: - fi-skl-6770hq: [FAIL][9] ([fdo#108511]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live_gem_contexts: - fi-bsw-nick: [INCOMPLETE][11] ([fdo# 111542]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html * igt@i915_selftest@live_hangcheck: - fi-hsw-4770r: [DMESG-FAIL][13] ([fdo#111991]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html * igt@kms_busy@basic-flip-pipe-b: - fi-skl-6770hq: [DMESG-WARN][15] ([fdo#105541]) -> [PASS][16] +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html [fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541 [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107 [fdo#107407]: https://bugs.freedesktop.org/show_bug.cgi?id=107407 [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511 [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991 Participating hosts (48 -> 45) ------------------------------ Missing (3): fi-byt-clapper fi-bsw-cyan fi-hsw-4200u Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5287 -> IGTPW_3709 CI-20190529: 20190529 CI_DRM_7349: 1ac295d19c04ab5eaf41857c86d666405751eb03 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3709: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/index.html IGT_5287: 9e57f8a51d59b3ffe4002d761fe0315d733bd66e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Check if get/set tiling is supported 2019-11-15 5:33 [igt-dev] [PATCH 0/2] Check if get/set tiling is supported Vanshidhar Konda ` (2 preceding siblings ...) 2019-11-15 6:24 ` [igt-dev] ✓ Fi.CI.BAT: success for Check if get/set tiling is supported Patchwork @ 2019-11-16 12:50 ` Patchwork 3 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-11-16 12:50 UTC (permalink / raw) To: Vanshidhar Konda; +Cc: igt-dev == Series Details == Series: Check if get/set tiling is supported URL : https://patchwork.freedesktop.org/series/69503/ State : success == Summary == CI Bug Log - changes from CI_DRM_7349_full -> IGTPW_3709_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_3709_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * {igt@gem_exec_parse_blt@batch-without-end}: - shard-iclb: NOTRUN -> [SKIP][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb4/igt@gem_exec_parse_blt@batch-without-end.html * {igt@gem_exec_parse_blt@bb-secure}: - shard-tglb: NOTRUN -> [SKIP][2] +5 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb1/igt@gem_exec_parse_blt@bb-secure.html * {igt@gem_exec_reloc@basic-spin-blt}: - shard-glk: NOTRUN -> [TIMEOUT][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-glk5/igt@gem_exec_reloc@basic-spin-blt.html - shard-apl: NOTRUN -> [TIMEOUT][4] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-apl3/igt@gem_exec_reloc@basic-spin-blt.html - shard-kbl: NOTRUN -> [TIMEOUT][5] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-kbl3/igt@gem_exec_reloc@basic-spin-blt.html Known issues ------------ Here are the changes found in IGTPW_3709_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@vcs1-mixed-process: - shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276] / [fdo#112080]) +2 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb3/igt@gem_ctx_persistence@vcs1-mixed-process.html * igt@gem_exec_create@basic: - shard-tglb: [PASS][8] -> [INCOMPLETE][9] ([fdo#111736]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb7/igt@gem_exec_create@basic.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb6/igt@gem_exec_create@basic.html * igt@gem_exec_nop@basic-parallel: - shard-tglb: [PASS][10] -> [INCOMPLETE][11] ([fdo#111747]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb5/igt@gem_exec_nop@basic-parallel.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb7/igt@gem_exec_nop@basic-parallel.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#112146]) +3 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [PASS][14] -> [SKIP][15] ([fdo#109276]) +10 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive: - shard-apl: [PASS][16] -> [TIMEOUT][17] ([fdo#112113]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-apl4/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-apl7/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-iclb: [PASS][18] -> [FAIL][19] ([fdo#112037]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_userptr_blits@sync-unmap-cycles: - shard-snb: [PASS][20] -> [DMESG-WARN][21] ([fdo#111870]) +1 similar issue [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-snb4/igt@gem_userptr_blits@sync-unmap-cycles.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html - shard-hsw: [PASS][22] -> [DMESG-WARN][23] ([fdo#111870]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-hsw5/igt@gem_userptr_blits@sync-unmap-cycles.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-hsw2/igt@gem_userptr_blits@sync-unmap-cycles.html * igt@gem_workarounds@suspend-resume: - shard-iclb: [PASS][24] -> [DMESG-WARN][25] ([fdo#111764]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb5/igt@gem_workarounds@suspend-resume.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb8/igt@gem_workarounds@suspend-resume.html * igt@i915_pm_dc@dc5-dpms: - shard-iclb: [PASS][26] -> [FAIL][27] ([fdo#111795 ]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb2/igt@i915_pm_dc@dc5-dpms.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-snb: [PASS][28] -> [SKIP][29] ([fdo#109271]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-snb5/igt@i915_pm_rc6_residency@rc6-accuracy.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-snb2/igt@i915_pm_rc6_residency@rc6-accuracy.html * igt@i915_selftest@live_hangcheck: - shard-hsw: [PASS][30] -> [DMESG-FAIL][31] ([fdo#111991]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-hsw2/igt@i915_selftest@live_hangcheck.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-hsw5/igt@i915_selftest@live_hangcheck.html * igt@i915_suspend@sysfs-reader: - shard-kbl: [PASS][32] -> [DMESG-WARN][33] ([fdo#108566]) +4 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-kbl3/igt@i915_suspend@sysfs-reader.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-kbl1/igt@i915_suspend@sysfs-reader.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-apl: [PASS][34] -> [DMESG-WARN][35] ([fdo#108566]) +2 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-rte: - shard-iclb: [PASS][36] -> [FAIL][37] ([fdo#103167] / [fdo#110378]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-rte.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-rte.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-iclb: [PASS][38] -> [FAIL][39] ([fdo#103167]) +6 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-tglb: [PASS][40] -> [FAIL][41] ([fdo#103167]) +2 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][42] -> [FAIL][43] ([fdo#103166]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-y.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][44] -> [FAIL][45] ([fdo#108341]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb7/igt@kms_psr@no_drrs.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109441]) +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_setmode@basic: - shard-apl: [PASS][48] -> [FAIL][49] ([fdo#99912]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-apl2/igt@kms_setmode@basic.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-apl7/igt@kms_setmode@basic.html * igt@perf_pmu@busy-check-all-vcs1: - shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#112080]) +9 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb2/igt@perf_pmu@busy-check-all-vcs1.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb6/igt@perf_pmu@busy-check-all-vcs1.html #### Possible fixes #### * igt@gem_ctx_isolation@vcs1-dirty-create: - shard-iclb: [SKIP][52] ([fdo#109276] / [fdo#112080]) -> [PASS][53] +2 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb3/igt@gem_ctx_isolation@vcs1-dirty-create.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb2/igt@gem_ctx_isolation@vcs1-dirty-create.html * igt@gem_ctx_isolation@vcs1-s3: - shard-tglb: [INCOMPLETE][54] ([fdo#111832]) -> [PASS][55] +1 similar issue [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb7/igt@gem_ctx_isolation@vcs1-s3.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb5/igt@gem_ctx_isolation@vcs1-s3.html * igt@gem_ctx_shared@q-smoketest-all: - shard-tglb: [INCOMPLETE][56] ([fdo#111735]) -> [PASS][57] [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb6/igt@gem_ctx_shared@q-smoketest-all.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb4/igt@gem_ctx_shared@q-smoketest-all.html * igt@gem_ctx_switch@vcs1-heavy: - shard-iclb: [SKIP][58] ([fdo#112080]) -> [PASS][59] +6 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb3/igt@gem_ctx_switch@vcs1-heavy.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb1/igt@gem_ctx_switch@vcs1-heavy.html * igt@gem_exec_schedule@independent-bsd2: - shard-iclb: [SKIP][60] ([fdo#109276]) -> [PASS][61] +19 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb8/igt@gem_exec_schedule@independent-bsd2.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb2/igt@gem_exec_schedule@independent-bsd2.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [SKIP][62] ([fdo#112146]) -> [PASS][63] +6 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb1/igt@gem_exec_schedule@wide-bsd.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb6/igt@gem_exec_schedule@wide-bsd.html * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive: - shard-apl: [TIMEOUT][64] ([fdo#112113]) -> [PASS][65] [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-apl7/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-glk: [DMESG-FAIL][66] -> [PASS][67] [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-glk1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-glk1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_sync@basic-all: - shard-tglb: [INCOMPLETE][68] -> [PASS][69] [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb9/igt@gem_sync@basic-all.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb1/igt@gem_sync@basic-all.html * igt@gem_userptr_blits@map-fixed-invalidate-busy: - shard-snb: [DMESG-WARN][70] ([fdo#111870]) -> [PASS][71] +2 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: - shard-hsw: [DMESG-WARN][72] ([fdo#111870]) -> [PASS][73] +2 similar issues [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy: - shard-hsw: [DMESG-WARN][74] ([fdo#110789] / [fdo#111870]) -> [PASS][75] [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-kbl: [INCOMPLETE][76] ([fdo#103665] / [fdo#107807]) -> [PASS][77] [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-kbl6/igt@i915_pm_rpm@system-suspend-execbuf.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-kbl4/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@i915_selftest@live_hangcheck: - shard-snb: [INCOMPLETE][78] ([fdo#105411]) -> [PASS][79] +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-snb2/igt@i915_selftest@live_hangcheck.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-snb1/igt@i915_selftest@live_hangcheck.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [DMESG-WARN][80] ([fdo#108566]) -> [PASS][81] +4 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_frontbuffer_tracking@basic: - shard-iclb: [FAIL][82] ([fdo#103167]) -> [PASS][83] +1 similar issue [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb8/igt@kms_frontbuffer_tracking@basic.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb5/igt@kms_frontbuffer_tracking@basic.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite: - shard-tglb: [FAIL][84] ([fdo#103167]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render: - shard-glk: [DMESG-FAIL][86] ([fdo#105763] / [fdo#106538]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen: - shard-glk: [FAIL][88] ([fdo#103167]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-tglb: [INCOMPLETE][90] ([fdo#111832] / [fdo#111850]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_setmode@basic: - shard-glk: [FAIL][92] ([fdo#99912]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-glk3/igt@kms_setmode@basic.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-glk4/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend: - shard-tglb: [INCOMPLETE][94] ([fdo#111850]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb7/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb6/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv-switch: - shard-iclb: [SKIP][96] ([fdo#109276] / [fdo#112080]) -> [FAIL][97] ([fdo#111329]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html * igt@gem_exec_schedule@deep-render: - shard-tglb: [FAIL][98] ([fdo#111646]) -> [INCOMPLETE][99] ([fdo#111671]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb2/igt@gem_exec_schedule@deep-render.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb3/igt@gem_exec_schedule@deep-render.html * igt@gem_exec_schedule@deep-vebox: - shard-tglb: [INCOMPLETE][100] ([fdo#111671]) -> [FAIL][101] ([fdo#111646]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb2/igt@gem_exec_schedule@deep-vebox.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb3/igt@gem_exec_schedule@deep-vebox.html * igt@kms_atomic_transition@6x-modeset-transitions: - shard-tglb: [SKIP][102] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][103] ([fdo#112021 ]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-tglb7/igt@kms_atomic_transition@6x-modeset-transitions.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html * igt@kms_psr@psr2_suspend: - shard-iclb: [SKIP][104] ([fdo#109441]) -> [DMESG-WARN][105] ([fdo#107724]) [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7349/shard-iclb7/igt@kms_psr@psr2_suspend.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/shard-iclb2/igt@kms_psr@psr2_suspend.html {name}: This element is suppressed. This means it is ignored when comp == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3709/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH 0/2] Check if get/set tiling is supported @ 2019-11-15 23:16 Vanshidhar Konda 2019-11-15 23:16 ` [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Vanshidhar Konda 0 siblings, 1 reply; 11+ messages in thread From: Vanshidhar Konda @ 2019-11-15 23:16 UTC (permalink / raw) To: igt-dev; +Cc: brian.welty With Gen12 hardware, the GET/SET_TILING IOCTLs return EOPNOTSUPP error. This change impacts usermode code. See this link for more discussion about this change: https://patchwork.freedesktop.org/patch/325343/ IGT tests have to be updated to check if these IOCTLs are supported. Vanshidhar Konda (2): lib/ioctl_wrappers: Query if device supports set/get legacy tiling i915/i915_fb_tiling: Check if device supports tiling lib/ioctl_wrappers.c | 16 ++++++++++++++++ lib/ioctl_wrappers.h | 1 + tests/i915/i915_fb_tiling.c | 2 ++ 3 files changed, 19 insertions(+) -- 2.24.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling 2019-11-15 23:16 [igt-dev] [PATCH 0/2] " Vanshidhar Konda @ 2019-11-15 23:16 ` Vanshidhar Konda 0 siblings, 0 replies; 11+ messages in thread From: Vanshidhar Konda @ 2019-11-15 23:16 UTC (permalink / raw) To: igt-dev; +Cc: brian.welty Add a method to query if the device supports setting and getting legacy tiling formats for buffer objects. Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda@intel.com> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> --- lib/ioctl_wrappers.c | 17 +++++++++++++++++ lib/ioctl_wrappers.h | 1 + 2 files changed, 18 insertions(+) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 628f8b83..aefe08d8 100644 --- a/lib/ioctl_wrappers.c +++ b/lib/ioctl_wrappers.c @@ -133,6 +133,23 @@ __gem_get_tiling(int fd, struct drm_i915_gem_get_tiling *arg) return err; } +/** + * gem_has_legacy_hw_tiling: + * @fd: open i915 drm file descriptor + * + * Feature check to query if the device supports setting/getting + * legacy tiling formats for buffer objects + * + * Returns: True if tiling is supported + */ +bool +gem_has_legacy_hw_tiling(int fd) +{ + struct drm_i915_gem_get_tiling arg = {}; + + return (__gem_get_tiling(fd, &arg) != -EOPNOTSUPP); +} + /** * gem_get_tiling: * @fd: open i915 drm file descriptor diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h index 03211c97..c9c96902 100644 --- a/lib/ioctl_wrappers.h +++ b/lib/ioctl_wrappers.h @@ -145,6 +145,7 @@ void gem_require_caching(int fd); void gem_require_ring(int fd, unsigned ring); bool gem_has_mocs_registers(int fd); void gem_require_mocs_registers(int fd); +bool gem_has_legacy_hw_tiling(int fd); #define gem_has_ring(f, r) gem_context_has_engine(f, 0, r) -- 2.23.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-11-16 12:50 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-11-15 5:33 [igt-dev] [PATCH 0/2] Check if get/set tiling is supported Vanshidhar Konda 2019-11-15 5:33 ` [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Vanshidhar Konda 2019-11-15 5:42 ` Dixit, Ashutosh 2019-11-15 5:50 ` Vanshidhar Konda 2019-11-15 18:16 ` Dixit, Ashutosh 2019-11-15 18:51 ` Vanshidhar Konda 2019-11-15 22:27 ` Dixit, Ashutosh 2019-11-15 5:33 ` [igt-dev] [PATCH 2/2] i915/i915_fb_tiling: Check if device supports tiling Vanshidhar Konda 2019-11-15 6:24 ` [igt-dev] ✓ Fi.CI.BAT: success for Check if get/set tiling is supported Patchwork 2019-11-16 12:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2019-11-15 23:16 [igt-dev] [PATCH 0/2] " Vanshidhar Konda 2019-11-15 23:16 ` [igt-dev] [PATCH 1/2] lib/ioctl_wrappers: Query if device supports set/get legacy tiling Vanshidhar Konda
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.