From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 06/15] powerpc/Kconfig: select PPC_MM_SLICES from subarch type
Date: Thu, 11 Apr 2019 10:37:29 +0530 [thread overview]
Message-ID: <87tvf53zam.fsf@linux.ibm.com> (raw)
In-Reply-To: <87zhox3zjo.fsf@linux.ibm.com>
Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> writes:
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>
>> Lets select PPC_MM_SLICES from the subarch config item instead of
>> doing it via defaults declaration in the PPC_MM_SLICES item itself.
>>
>
> Did we miss the book3s 64 default y here?
>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>> arch/powerpc/platforms/Kconfig.cputype | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
>> index 842b2c7e156a..a46a0adb634d 100644
>> --- a/arch/powerpc/platforms/Kconfig.cputype
>> +++ b/arch/powerpc/platforms/Kconfig.cputype
>> @@ -34,6 +34,7 @@ config PPC_8xx
>> bool "Freescale 8xx"
>> select FSL_SOC
>> select SYS_SUPPORTS_HUGETLBFS
>> + select PPC_MM_SLICES if HUGETLB_PAGE
>>
>> config 40x
>> bool "AMCC 40x"
>> @@ -75,6 +76,7 @@ config PPC_BOOK3S_64
>> select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE
>> select ARCH_SUPPORTS_NUMA_BALANCING
>> select IRQ_WORK
>> + select PPC_MM_SLICES
ok this takes care of BOOK3S_64.
>>
>> config PPC_BOOK3E_64
>> bool "Embedded processors"
>> @@ -360,8 +362,6 @@ config PPC_BOOK3E_MMU
>>
>> config PPC_MM_SLICES
>> bool
>> - default y if PPC_BOOK3S_64
>> - default y if PPC_8xx && HUGETLB_PAGE
>>
>> config PPC_HAVE_PMU_SUPPORT
>> bool
>> --
>> 2.13.3
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v1 06/15] powerpc/Kconfig: select PPC_MM_SLICES from subarch type
Date: Thu, 11 Apr 2019 10:37:29 +0530 [thread overview]
Message-ID: <87tvf53zam.fsf@linux.ibm.com> (raw)
In-Reply-To: <87zhox3zjo.fsf@linux.ibm.com>
Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> writes:
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>
>> Lets select PPC_MM_SLICES from the subarch config item instead of
>> doing it via defaults declaration in the PPC_MM_SLICES item itself.
>>
>
> Did we miss the book3s 64 default y here?
>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>> arch/powerpc/platforms/Kconfig.cputype | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
>> index 842b2c7e156a..a46a0adb634d 100644
>> --- a/arch/powerpc/platforms/Kconfig.cputype
>> +++ b/arch/powerpc/platforms/Kconfig.cputype
>> @@ -34,6 +34,7 @@ config PPC_8xx
>> bool "Freescale 8xx"
>> select FSL_SOC
>> select SYS_SUPPORTS_HUGETLBFS
>> + select PPC_MM_SLICES if HUGETLB_PAGE
>>
>> config 40x
>> bool "AMCC 40x"
>> @@ -75,6 +76,7 @@ config PPC_BOOK3S_64
>> select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE
>> select ARCH_SUPPORTS_NUMA_BALANCING
>> select IRQ_WORK
>> + select PPC_MM_SLICES
ok this takes care of BOOK3S_64.
>>
>> config PPC_BOOK3E_64
>> bool "Embedded processors"
>> @@ -360,8 +362,6 @@ config PPC_BOOK3E_MMU
>>
>> config PPC_MM_SLICES
>> bool
>> - default y if PPC_BOOK3S_64
>> - default y if PPC_8xx && HUGETLB_PAGE
>>
>> config PPC_HAVE_PMU_SUPPORT
>> bool
>> --
>> 2.13.3
next prev parent reply other threads:[~2019-04-11 5:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 20:06 [PATCH v1 00/15] Refactor pgalloc stuff Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 01/15] powerpc/mm: drop __bad_pte() Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 02/15] powerpc/mm: define __pud_free_tlb() at all time on nohash/64 Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 03/15] powerpc/mm: convert Book3E 64 to pte_fragment Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 04/15] powerpc/mm: move pgtable_t in asm/mmu.h Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 05/15] powerpc/mm: get rid of nohash/32/mmu.h and nohash/64/mmu.h Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 06/15] powerpc/Kconfig: select PPC_MM_SLICES from subarch type Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-11 5:02 ` Aneesh Kumar K.V
2019-04-11 5:02 ` Aneesh Kumar K.V
2019-04-11 5:07 ` Aneesh Kumar K.V [this message]
2019-04-11 5:07 ` Aneesh Kumar K.V
2019-04-03 20:06 ` [PATCH v1 07/15] powerpc/book3e: move early_alloc_pgtable() to init section Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 08/15] powerpc/mm: don't use pte_alloc_kernel() until slab is available on PPC32 Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 09/15] powerpc/mm: inline pte_alloc_one_kernel() and pte_alloc_one() " Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 10/15] powerpc/mm: refactor pte_alloc_one() and pte_free() families definition Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 11/15] powerpc/mm: refactor definition of pgtable_cache[] Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 12/15] powerpc/mm: Only keep one version of pmd_populate() functions on nohash/32 Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 13/15] powerpc/mm: refactor pgtable freeing functions on nohash Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 14/15] powerpc/mm: refactor pmd_pgtable() Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-03 20:06 ` [PATCH v1 15/15] powerpc/mm: refactor pgd_alloc() and pgd_free() on nohash Christophe Leroy
2019-04-03 20:06 ` Christophe Leroy
2019-04-11 5:06 ` [PATCH v1 00/15] Refactor pgalloc stuff Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvf53zam.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.