* Re: [RFC] drm/i915/guc: Keep GuC log disabled by default
2018-01-19 12:49 [RFC] drm/i915/guc: Keep GuC log disabled by default Michal Wajdeczko
@ 2018-01-19 13:22 ` Lofstedt, Marta
2018-01-19 13:36 ` Michał Winiarski
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Lofstedt, Marta @ 2018-01-19 13:22 UTC (permalink / raw)
To: Wajdeczko, Michal, intel-gfx@lists.freedesktop.org
Cc: Sarvela, Tomi P, Vetter, Daniel
+ Daniel
> -----Original Message-----
> From: Wajdeczko, Michal
> Sent: Friday, January 19, 2018 2:49 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Wajdeczko, Michal <Michal.Wajdeczko@intel.com>; Chris Wilson
> <chris@chris-wilson.co.uk>; Saarinen, Jani <jani.saarinen@intel.com>;
> Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Lofstedt, Marta
> <marta.lofstedt@intel.com>; Winiarski, Michal <michal.winiarski@intel.com>
> Subject: [RFC] drm/i915/guc: Keep GuC log disabled by default
>
> It looks that GuC log functionality is not fully functional yet and causes issues
> when enabled by auto(-1) modparam on debug builds.
>
> [ 30.062893]
> ======================================================
> [ 30.062894] WARNING: possible circular locking dependency detected
> [ 30.062895] 4.15.0-rc8-CI-CI_DRM_3648+ #1 Tainted: G U
> [ 30.062896] ------------------------------------------------------
> [ 30.062897] debugfs_test/1268 is trying to acquire lock:
> [ 30.062898] (&dev->struct_mutex){+.+.}, at: [<00000000e4213449>]
> i915_mutex_lock_interruptible+0x47/0x130 [i915]
> [ 30.062921]
> but task is already holding lock:
> [ 30.062921] (&mm->mmap_sem){++++}, at: [<00000000dd7adc93>]
> __do_page_fault+0x106/0x560
> [ 30.062924]
> which lock already depends on the new lock.
>
> Fixes: 0ed87953532652 ("drm/i915/guc: Redefine guc_log_level modparam
> values")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Saarinen <jani.saarinen@intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> Cc: Marta Lofstedt <marta.lofstedt@intel.com>
> Cc: Michal Winiarski <michal.winiarski@intel.com>
> ---
> drivers/gpu/drm/i915/i915_params.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.h
> b/drivers/gpu/drm/i915/i915_params.h
> index c963603..430f5f9 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -48,7 +48,7 @@
> param(int, enable_ips, 1) \
> param(int, invert_brightness, 0) \
> param(int, enable_guc, 0) \
> - param(int, guc_log_level, -1) \
> + param(int, guc_log_level, 0) \
> param(char *, guc_firmware_path, NULL) \
> param(char *, huc_firmware_path, NULL) \
> param(int, mmio_debug, 0) \
> --
> 1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC] drm/i915/guc: Keep GuC log disabled by default
2018-01-19 12:49 [RFC] drm/i915/guc: Keep GuC log disabled by default Michal Wajdeczko
2018-01-19 13:22 ` Lofstedt, Marta
@ 2018-01-19 13:36 ` Michał Winiarski
2018-01-19 14:17 ` Jani Nikula
2018-01-19 20:40 ` Chris Wilson
2018-01-19 15:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-19 19:40 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 2 replies; 7+ messages in thread
From: Michał Winiarski @ 2018-01-19 13:36 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: Tomi Sarvela, intel-gfx
On Fri, Jan 19, 2018 at 12:49:26PM +0000, Michal Wajdeczko wrote:
> It looks that GuC log functionality is not fully functional yet and
> causes issues when enabled by auto(-1) modparam on debug builds.
>
> [ 30.062893] ======================================================
> [ 30.062894] WARNING: possible circular locking dependency detected
> [ 30.062895] 4.15.0-rc8-CI-CI_DRM_3648+ #1 Tainted: G U
> [ 30.062896] ------------------------------------------------------
> [ 30.062897] debugfs_test/1268 is trying to acquire lock:
> [ 30.062898] (&dev->struct_mutex){+.+.}, at: [<00000000e4213449>] i915_mutex_lock_interruptible+0x47/0x130 [i915]
> [ 30.062921]
> but task is already holding lock:
> [ 30.062921] (&mm->mmap_sem){++++}, at: [<00000000dd7adc93>] __do_page_fault+0x106/0x560
> [ 30.062924]
> which lock already depends on the new lock.
>
I'd leave the lockdep splat out of here, since that's just the tip of the
iceberg :)
> Fixes: 0ed87953532652 ("drm/i915/guc: Redefine guc_log_level modparam values")
s/Fixes/References
It allows us to get test results while we're fixing the logging issues, so:
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
-Michał
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Saarinen <jani.saarinen@intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> Cc: Marta Lofstedt <marta.lofstedt@intel.com>
> Cc: Michal Winiarski <michal.winiarski@intel.com>
> ---
> drivers/gpu/drm/i915/i915_params.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index c963603..430f5f9 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -48,7 +48,7 @@
> param(int, enable_ips, 1) \
> param(int, invert_brightness, 0) \
> param(int, enable_guc, 0) \
> - param(int, guc_log_level, -1) \
> + param(int, guc_log_level, 0) \
> param(char *, guc_firmware_path, NULL) \
> param(char *, huc_firmware_path, NULL) \
> param(int, mmio_debug, 0) \
> --
> 1.9.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC] drm/i915/guc: Keep GuC log disabled by default
2018-01-19 13:36 ` Michał Winiarski
@ 2018-01-19 14:17 ` Jani Nikula
2018-01-19 20:40 ` Chris Wilson
1 sibling, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2018-01-19 14:17 UTC (permalink / raw)
To: Michał Winiarski, Michal Wajdeczko; +Cc: Tomi Sarvela, intel-gfx
On Fri, 19 Jan 2018, Michał Winiarski <michal.winiarski@intel.com> wrote:
> On Fri, Jan 19, 2018 at 12:49:26PM +0000, Michal Wajdeczko wrote:
>> It looks that GuC log functionality is not fully functional yet and
>> causes issues when enabled by auto(-1) modparam on debug builds.
This could use a better explanation. Now it seems like you're just
sweeping things under the carpet.
>>
>> [ 30.062893] ======================================================
>> [ 30.062894] WARNING: possible circular locking dependency detected
>> [ 30.062895] 4.15.0-rc8-CI-CI_DRM_3648+ #1 Tainted: G U
>> [ 30.062896] ------------------------------------------------------
>> [ 30.062897] debugfs_test/1268 is trying to acquire lock:
>> [ 30.062898] (&dev->struct_mutex){+.+.}, at: [<00000000e4213449>] i915_mutex_lock_interruptible+0x47/0x130 [i915]
>> [ 30.062921]
>> but task is already holding lock:
>> [ 30.062921] (&mm->mmap_sem){++++}, at: [<00000000dd7adc93>] __do_page_fault+0x106/0x560
>> [ 30.062924]
>> which lock already depends on the new lock.
>>
>
> I'd leave the lockdep splat out of here, since that's just the tip of the
> iceberg :)
>
>> Fixes: 0ed87953532652 ("drm/i915/guc: Redefine guc_log_level modparam values")
>
> s/Fixes/References
References should generally reference URIs I think.
BR,
Jani.
>
> It allows us to get test results while we're fixing the logging issues, so:
>
> Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
>
> -Michał
>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Jani Saarinen <jani.saarinen@intel.com>
>> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
>> Cc: Marta Lofstedt <marta.lofstedt@intel.com>
>> Cc: Michal Winiarski <michal.winiarski@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_params.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
>> index c963603..430f5f9 100644
>> --- a/drivers/gpu/drm/i915/i915_params.h
>> +++ b/drivers/gpu/drm/i915/i915_params.h
>> @@ -48,7 +48,7 @@
>> param(int, enable_ips, 1) \
>> param(int, invert_brightness, 0) \
>> param(int, enable_guc, 0) \
>> - param(int, guc_log_level, -1) \
>> + param(int, guc_log_level, 0) \
>> param(char *, guc_firmware_path, NULL) \
>> param(char *, huc_firmware_path, NULL) \
>> param(int, mmio_debug, 0) \
>> --
>> 1.9.1
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC] drm/i915/guc: Keep GuC log disabled by default
2018-01-19 13:36 ` Michał Winiarski
2018-01-19 14:17 ` Jani Nikula
@ 2018-01-19 20:40 ` Chris Wilson
1 sibling, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2018-01-19 20:40 UTC (permalink / raw)
To: Michał Winiarski, Michal Wajdeczko; +Cc: Tomi Sarvela, intel-gfx
Quoting Michał Winiarski (2018-01-19 13:36:27)
> On Fri, Jan 19, 2018 at 12:49:26PM +0000, Michal Wajdeczko wrote:
> > It looks that GuC log functionality is not fully functional yet and
> > causes issues when enabled by auto(-1) modparam on debug builds.
> >
> > [ 30.062893] ======================================================
> > [ 30.062894] WARNING: possible circular locking dependency detected
> > [ 30.062895] 4.15.0-rc8-CI-CI_DRM_3648+ #1 Tainted: G U
> > [ 30.062896] ------------------------------------------------------
> > [ 30.062897] debugfs_test/1268 is trying to acquire lock:
> > [ 30.062898] (&dev->struct_mutex){+.+.}, at: [<00000000e4213449>] i915_mutex_lock_interruptible+0x47/0x130 [i915]
> > [ 30.062921]
> > but task is already holding lock:
> > [ 30.062921] (&mm->mmap_sem){++++}, at: [<00000000dd7adc93>] __do_page_fault+0x106/0x560
> > [ 30.062924]
> > which lock already depends on the new lock.
> >
>
> I'd leave the lockdep splat out of here, since that's just the tip of the
> iceberg :)
>
> > Fixes: 0ed87953532652 ("drm/i915/guc: Redefine guc_log_level modparam values")
>
> s/Fixes/References
>
> It allows us to get test results while we're fixing the logging issues, so:
>
> Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
I agree. It's a mess, but disabling it for now lets CI provide test
coverage and early warning for new breakage. So pushed, even though it's
an RFC.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/guc: Keep GuC log disabled by default
2018-01-19 12:49 [RFC] drm/i915/guc: Keep GuC log disabled by default Michal Wajdeczko
2018-01-19 13:22 ` Lofstedt, Marta
2018-01-19 13:36 ` Michał Winiarski
@ 2018-01-19 15:07 ` Patchwork
2018-01-19 19:40 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-01-19 15:07 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Keep GuC log disabled by default
URL : https://patchwork.freedesktop.org/series/36796/
State : success
== Summary ==
Series 36796v1 drm/i915/guc: Keep GuC log disabled by default
https://patchwork.freedesktop.org/api/1.0/series/36796/revisions/1/mbox/
Test debugfs_test:
Subgroup read_all_entries:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:426s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:437s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:383s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:517s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:293s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:500s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:504s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:495s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:482s
fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:304s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:529s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:398s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:407s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:426s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:473s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:424s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:467s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:501s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:465s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:510s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:626s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:441s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:516s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:533s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:493s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:499s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:438s
fi-snb-2520m total:3 pass:2 dwarn:0 dfail:0 fail:0 skip:0
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:401s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:256 dwarn:0 dfail:0 fail:3 skip:26 time:557s
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:485s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:420s
fd10fae2b0f673861816511f99d4798d6b619b40 drm-tip: 2018y-01m-19d-14h-22m-15s UTC integration manifest
7240e554a44b drm/i915/guc: Keep GuC log disabled by default
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7720/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915/guc: Keep GuC log disabled by default
2018-01-19 12:49 [RFC] drm/i915/guc: Keep GuC log disabled by default Michal Wajdeczko
` (2 preceding siblings ...)
2018-01-19 15:07 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-01-19 19:40 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-01-19 19:40 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Keep GuC log disabled by default
URL : https://patchwork.freedesktop.org/series/36796/
State : failure
== Summary ==
Warning: bzip CI_DRM_3658/shard-glkb6/results22.json.bz2 wasn't in correct JSON format
Test pm_rps:
Subgroup reset:
pass -> FAIL (shard-apl) fdo#104218 +1
Test gem_exec_schedule:
Subgroup deep-vebox:
skip -> FAIL (shard-apl) fdo#102848
Test kms_flip:
Subgroup flip-vs-modeset-vs-hang:
dmesg-warn -> PASS (shard-snb) fdo#103821
Test kms_cursor_crc:
Subgroup cursor-128x128-sliding:
pass -> INCOMPLETE (shard-hsw)
Test perf:
Subgroup enable-disable:
pass -> FAIL (shard-apl) fdo#103715
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test gem_linear_blits:
Subgroup normal:
skip -> PASS (shard-apl)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
fdo#102848 https://bugs.freedesktop.org/show_bug.cgi?id=102848
fdo#103821 https://bugs.freedesktop.org/show_bug.cgi?id=103821
fdo#103715 https://bugs.freedesktop.org/show_bug.cgi?id=103715
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
shard-apl total:2768 pass:1707 dwarn:1 dfail:0 fail:25 skip:1034 time:14307s
shard-hsw total:2741 pass:1689 dwarn:1 dfail:1 fail:13 skip:1034 time:13978s
shard-snb total:2780 pass:1317 dwarn:1 dfail:1 fail:11 skip:1450 time:8044s
Blacklisted hosts:
shard-kbl total:2746 pass:1813 dwarn:1 dfail:1 fail:23 skip:906 time:10428s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7720/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread