From: Markus Armbruster <armbru@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>, alistair23@gmail.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v6 05/29] hw/dma: Replace fprintf(stderr, "*\n" with error_report()
Date: Fri, 22 Dec 2017 16:21:43 +0100 [thread overview]
Message-ID: <87tvwin5yw.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <75171003322239e9f9c16cc723c2d4cac569fde4.1513790495.git.alistair.francis@xilinx.com> (Alistair Francis's message of "Wed, 20 Dec 2017 09:23:04 -0800")
Alistair Francis <alistair.francis@xilinx.com> writes:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
>
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
>
> Some lines where then manually tweaked to pass checkpatch.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, alistair23@gmail.com
Subject: Re: [Qemu-devel] [PATCH v6 05/29] hw/dma: Replace fprintf(stderr, "*\n" with error_report()
Date: Fri, 22 Dec 2017 16:21:43 +0100 [thread overview]
Message-ID: <87tvwin5yw.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <75171003322239e9f9c16cc723c2d4cac569fde4.1513790495.git.alistair.francis@xilinx.com> (Alistair Francis's message of "Wed, 20 Dec 2017 09:23:04 -0800")
Alistair Francis <alistair.francis@xilinx.com> writes:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
>
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
> find ./* -type f -exec sed -i \
> 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
> {} +
>
> Some lines where then manually tweaked to pass checkpatch.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2017-12-22 15:22 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 17:22 [Qemu-trivial] [PATCH v6 00/29] Remove some of the fprintf(stderr, "* Alistair Francis
2017-12-20 17:22 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:22 ` [Qemu-trivial] [PATCH v6 01/29] audio: Replace AUDIO_FUNC with __func__ Alistair Francis
2017-12-20 17:22 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:22 ` [Qemu-trivial] [PATCH v6 02/29] Replace all occurances of __FUNCTION__ " Alistair Francis
2017-12-20 17:22 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:22 ` Alistair Francis
2017-12-20 17:22 ` [Qemu-arm] " Alistair Francis
2017-12-20 17:22 ` [Qemu-trivial] [PATCH v6 03/29] Fixes after renaming __FUNCTION__ to __func__ Alistair Francis
2017-12-20 17:22 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report() Alistair Francis
2017-12-20 17:23 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:23 ` [Qemu-arm] " Alistair Francis
2017-12-22 15:21 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2017-12-22 15:21 ` Markus Armbruster
2017-12-22 15:21 ` [Qemu-arm] " Markus Armbruster
2017-12-22 15:37 ` [Qemu-trivial] " Markus Armbruster
2017-12-22 15:37 ` Markus Armbruster
2017-12-22 15:37 ` [Qemu-arm] " Markus Armbruster
2017-12-22 17:17 ` [Qemu-trivial] " Thomas Huth
2017-12-22 17:17 ` Thomas Huth
2017-12-22 17:17 ` [Qemu-arm] " Thomas Huth
2017-12-22 19:57 ` [Qemu-trivial] " Alistair Francis
2017-12-22 19:57 ` Alistair Francis
2017-12-22 19:57 ` [Qemu-arm] " Alistair Francis
2017-12-22 20:30 ` [Qemu-trivial] " Markus Armbruster
2017-12-22 20:30 ` Markus Armbruster
2017-12-22 20:30 ` [Qemu-arm] " Markus Armbruster
2017-12-22 20:58 ` [Qemu-trivial] " Alistair Francis
2017-12-22 20:58 ` Alistair Francis
2017-12-22 20:58 ` [Qemu-arm] " Alistair Francis
2018-01-02 12:59 ` [Qemu-trivial] " Markus Armbruster
2018-01-02 12:59 ` Markus Armbruster
2018-01-02 12:59 ` [Qemu-arm] " Markus Armbruster
2018-01-09 0:32 ` [Qemu-trivial] " Alistair Francis
2018-01-09 0:32 ` Alistair Francis
2018-01-09 0:32 ` Alistair Francis
2018-01-09 15:31 ` [Qemu-trivial] " Thomas Huth
2018-01-09 15:31 ` Thomas Huth
2018-01-09 15:31 ` [Qemu-arm] " Thomas Huth
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 05/29] hw/dma: " Alistair Francis
2017-12-20 17:23 ` [Qemu-devel] " Alistair Francis
2017-12-22 15:21 ` Markus Armbruster [this message]
2017-12-22 15:21 ` Markus Armbruster
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 06/29] hw/gpio: " Alistair Francis
2017-12-20 17:23 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 07/29] hw/i2c: " Alistair Francis
2017-12-20 17:23 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 09/29] hw/ide: " Alistair Francis
2017-12-20 17:23 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 10/29] hw/intc: " Alistair Francis
2017-12-20 17:23 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 11/29] hw/ipmi: " Alistair Francis
2017-12-20 17:23 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:23 ` [Qemu-trivial] [PATCH v6 12/29] hw/isa: " Alistair Francis
2017-12-20 17:23 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 13/29] hw/lm32: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 14/29] hw/mips: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 15/29] hw/moxie: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 16/29] hw/nios2: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 17/29] hw/nvram: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 18/29] hw/openrisc: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 19/29] hw/pci*: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 20/29] hw/ppc: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 21/29] hw/s390x: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2018-01-09 17:45 ` [Qemu-trivial] " Cornelia Huck
2018-01-09 17:45 ` Cornelia Huck
2018-01-09 18:09 ` [Qemu-trivial] " Alistair Francis
2018-01-09 18:09 ` Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 23/29] hw/sd: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 24/29] hw/sparc*: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 25/29] hw/ssi: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:24 ` [Qemu-trivial] [PATCH v6 26/29] hw/timer: " Alistair Francis
2017-12-20 17:24 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:25 ` [Qemu-trivial] [PATCH v6 27/29] hw/xen*: " Alistair Francis
2017-12-20 17:25 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:25 ` [Qemu-trivial] [PATCH v6 28/29] tcg: " Alistair Francis
2017-12-20 17:25 ` [Qemu-devel] " Alistair Francis
2017-12-20 17:25 ` [Qemu-trivial] [PATCH v6 29/29] target: Use qemu_log() instead of fprintf(stderr, ...) Alistair Francis
2017-12-20 17:25 ` [Qemu-devel] " Alistair Francis
[not found] ` <97bff6488fbc4c6b2c10879798aa149a43426fd9.1513790495.git.alistair.francis@xilinx.com>
2017-12-20 22:10 ` [Qemu-trivial] [PATCH v6 08/29] hw/i386: Replace fprintf(stderr, "*\n" with error_report() Eduardo Habkost
2017-12-20 22:10 ` [Qemu-devel] " Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvwin5yw.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.