Re: [PATCH] drm/i915: Remove pre-production pooled-EU w/a for Broxton

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 16 Nov 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Thu, Nov 16, 2017 at 09:22:23AM +0000, Jani Nikula wrote:
>> On Wed, 15 Nov 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > Quoting David Weinehall (2017-11-15 18:01:41)
>> >> On Tue, Nov 14, 2017 at 01:51:16PM +0000, Chris Wilson wrote:
>> >> > WaEnablePooledEuFor2x6 only applies to preproduction models, unsupported
>> >> > since commit 0102ba1fd8af ("drm/i915: Add early BXT sdv to the list of
>> >> > preproduction machines").
>> >> > 
>> >> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> >> > Cc: Jani Nikula <jani.nikula@intel.com>
>> >> 
>> >> Reviewed-by: David Weinehall <david.weinehall@linux.intel.com>
>> >
>> > Ta, hope your sdp is ok in the bin ;)
>> >
>> > Any volunteers for IS_GLK_REVID, IS_KBL_REVID ?
>> >
>> > I see one IS_SKL_REVID that can easily be removed.
>> 
>> Need to know what the first shipped rev was. For example with bxt we
>> apparently can't remove some of the rev checks.
>> 
>> Seems like we should add more checks to intel_detect_preproduction_hw()
>> too.
>
> With the IS_*_REVID in place I'd advocate to leave the workarounds around.
>
> I understand that codes get cleaner if we remove them from here,
> but usually previous pre-prod workarounds are useful reference for
> new platforms power-on...

Perhaps for the gen-1, but not older.

BR,
Jani.

>
> Thanks,
> Rodrigo.
>
>> 
>> BR,
>> Jani.
>> 
>> -- 
>> Jani Nikula, Intel Open Source Technology Center
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx