All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andrew Jones <drjones@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] Makefile: Move balloon.o, numa.o and bootdevice.o to common-obj-y
Date: Thu, 08 Jun 2017 16:37:06 +0200	[thread overview]
Message-ID: <87tw3qa6lp.fsf@secure.mitica> (raw)
In-Reply-To: <1496931482-29914-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 8 Jun 2017 16:18:02 +0200")

Thomas Huth <thuth@redhat.com> wrote:
> There does not seem to be any target specific code in these files, so
> we can put them into "common-obj" instead of "obj" to compile them only
> once for all targets.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Again, nothing strange on that files that looks target specific.


WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andrew Jones <drjones@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Move balloon.o, numa.o and bootdevice.o to common-obj-y
Date: Thu, 08 Jun 2017 16:37:06 +0200	[thread overview]
Message-ID: <87tw3qa6lp.fsf@secure.mitica> (raw)
In-Reply-To: <1496931482-29914-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 8 Jun 2017 16:18:02 +0200")

Thomas Huth <thuth@redhat.com> wrote:
> There does not seem to be any target specific code in these files, so
> we can put them into "common-obj" instead of "obj" to compile them only
> once for all targets.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Again, nothing strange on that files that looks target specific.

  reply	other threads:[~2017-06-08 14:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 14:18 [Qemu-trivial] [PATCH] Makefile: Move balloon.o, numa.o and bootdevice.o to common-obj-y Thomas Huth
2017-06-08 14:18 ` [Qemu-devel] " Thomas Huth
2017-06-08 14:37 ` Juan Quintela [this message]
2017-06-08 14:37   ` Juan Quintela
2017-06-14 11:18 ` [Qemu-trivial] " Thomas Huth
2017-06-14 11:18   ` Thomas Huth
2017-06-14 11:25   ` [Qemu-trivial] " Paolo Bonzini
2017-06-14 11:25     ` Paolo Bonzini
2017-06-16 11:03     ` [Qemu-trivial] " Thomas Huth
2017-06-16 11:03       ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw3qa6lp.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=drjones@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.