* [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin
@ 2016-12-21 12:57 ` Romain Perier
0 siblings, 0 replies; 10+ messages in thread
From: Romain Perier @ 2016-12-21 12:57 UTC (permalink / raw)
To: linux-arm-kernel
This set of patches adds support for the Marvell ethernet switch 88E6341.
It also add the devicetree definition of this switch to the DT board.
Romain Perier (2):
net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >=
num_of_ports
net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141
drivers/net/dsa/mv88e6xxx/chip.c | 48 ++++++++++++++++++++++++++++++-----
drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 4 ++-
2 files changed, 45 insertions(+), 7 deletions(-)
--
Note: As requested by Gregory, I have removed the patch for the DT (already merged).
2.9.3
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin @ 2016-12-21 12:57 ` Romain Perier 0 siblings, 0 replies; 10+ messages in thread From: Romain Perier @ 2016-12-21 12:57 UTC (permalink / raw) To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Jason Cooper, Sebastian Hesselbarth, Gregory Clement Cc: netdev-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Ian Campbell, Pawel Moll, Mark Rutland, Kumar Gala, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thomas Petazzoni, Nadav Haklai, Romain Perier This set of patches adds support for the Marvell ethernet switch 88E6341. It also add the devicetree definition of this switch to the DT board. Romain Perier (2): net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141 drivers/net/dsa/mv88e6xxx/chip.c | 48 ++++++++++++++++++++++++++++++----- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 4 ++- 2 files changed, 45 insertions(+), 7 deletions(-) -- Note: As requested by Gregory, I have removed the patch for the DT (already merged). 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net-next v4 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports 2016-12-21 12:57 ` Romain Perier @ 2016-12-21 12:57 ` Romain Perier -1 siblings, 0 replies; 10+ messages in thread From: Romain Perier @ 2016-12-21 12:57 UTC (permalink / raw) To: linux-arm-kernel Some Marvell ethernet switches have internal ethernet transceivers with hardcoded phy addresses. These addresses can be greater than the number of ports or its value might be different than the associated port number. This is for example the case for MV88E6341 that has 6 ports and internal Port 1 to Port4 PHYs mapped at SMI addresses from 0x11 to 0x14. This commits fixes the issue by removing the condition in MDIO callbacks. Signed-off-by: Romain Perier <romain.perier@free-electrons.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- Changes in v4: - Fixed typo in the commit log Changes in v2: - Added tag "Reviewed-by" by Andrew - Fixed typo in the commit log drivers/net/dsa/mv88e6xxx/chip.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index b5f0e1e..76d944e 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2881,9 +2881,6 @@ static int mv88e6xxx_mdio_read(struct mii_bus *bus, int phy, int reg) u16 val; int err; - if (phy >= mv88e6xxx_num_ports(chip)) - return 0xffff; - mutex_lock(&chip->reg_lock); err = mv88e6xxx_phy_read(chip, phy, reg, &val); mutex_unlock(&chip->reg_lock); @@ -2896,9 +2893,6 @@ static int mv88e6xxx_mdio_write(struct mii_bus *bus, int phy, int reg, u16 val) struct mv88e6xxx_chip *chip = bus->priv; int err; - if (phy >= mv88e6xxx_num_ports(chip)) - return 0xffff; - mutex_lock(&chip->reg_lock); err = mv88e6xxx_phy_write(chip, phy, reg, val); mutex_unlock(&chip->reg_lock); -- 2.9.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH net-next v4 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports @ 2016-12-21 12:57 ` Romain Perier 0 siblings, 0 replies; 10+ messages in thread From: Romain Perier @ 2016-12-21 12:57 UTC (permalink / raw) To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Jason Cooper, Sebastian Hesselbarth, Gregory Clement Cc: netdev, devicetree, Rob Herring, Ian Campbell, Pawel Moll, Mark Rutland, Kumar Gala, linux-arm-kernel, Thomas Petazzoni, Nadav Haklai, Romain Perier Some Marvell ethernet switches have internal ethernet transceivers with hardcoded phy addresses. These addresses can be greater than the number of ports or its value might be different than the associated port number. This is for example the case for MV88E6341 that has 6 ports and internal Port 1 to Port4 PHYs mapped at SMI addresses from 0x11 to 0x14. This commits fixes the issue by removing the condition in MDIO callbacks. Signed-off-by: Romain Perier <romain.perier@free-electrons.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- Changes in v4: - Fixed typo in the commit log Changes in v2: - Added tag "Reviewed-by" by Andrew - Fixed typo in the commit log drivers/net/dsa/mv88e6xxx/chip.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index b5f0e1e..76d944e 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2881,9 +2881,6 @@ static int mv88e6xxx_mdio_read(struct mii_bus *bus, int phy, int reg) u16 val; int err; - if (phy >= mv88e6xxx_num_ports(chip)) - return 0xffff; - mutex_lock(&chip->reg_lock); err = mv88e6xxx_phy_read(chip, phy, reg, &val); mutex_unlock(&chip->reg_lock); @@ -2896,9 +2893,6 @@ static int mv88e6xxx_mdio_write(struct mii_bus *bus, int phy, int reg, u16 val) struct mv88e6xxx_chip *chip = bus->priv; int err; - if (phy >= mv88e6xxx_num_ports(chip)) - return 0xffff; - mutex_lock(&chip->reg_lock); err = mv88e6xxx_phy_write(chip, phy, reg, val); mutex_unlock(&chip->reg_lock); -- 2.9.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141 2016-12-21 12:57 ` Romain Perier @ 2016-12-21 12:57 ` Romain Perier -1 siblings, 0 replies; 10+ messages in thread From: Romain Perier @ 2016-12-21 12:57 UTC (permalink / raw) To: linux-arm-kernel The Marvell 88E6341 device is single-chip, 6-port ethernet switch with four integrated 10/100/1000Mbps ethernet transceivers and one high speed SerDes interfaces. It is compatible with switches of family 88E6352. This commit adds basic support for this switch by describing its capabilities to the driver. Signed-off-by: Romain Perier <romain.perier@free-electrons.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- Changes in v3: - Added tag "Reviewed-by" by Andrew Changes in v2: - Add a dedicated data structure for the operations of the 88E6341 - Re-ordered PORT_SWITCH_ID_PROD_NUM_6341 in alphabetic order with other macros drivers/net/dsa/mv88e6xxx/chip.c | 42 +++++++++++++++++++++++++++++++++++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 4 +++- 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 76d944e..5e97dc4 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3625,6 +3625,34 @@ static const struct mv88e6xxx_ops mv88e6321_ops = { .reset = mv88e6352_g1_reset, }; +static const struct mv88e6xxx_ops mv88e6341_ops = { + /* MV88E6XXX_FAMILY_6352 */ + .get_eeprom = mv88e6xxx_g2_get_eeprom16, + .set_eeprom = mv88e6xxx_g2_set_eeprom16, + .set_switch_mac = mv88e6xxx_g2_set_switch_mac, + .phy_read = mv88e6xxx_g2_smi_phy_read, + .phy_write = mv88e6xxx_g2_smi_phy_write, + .port_set_link = mv88e6xxx_port_set_link, + .port_set_duplex = mv88e6xxx_port_set_duplex, + .port_set_rgmii_delay = mv88e6352_port_set_rgmii_delay, + .port_set_speed = mv88e6352_port_set_speed, + .port_tag_remap = mv88e6095_port_tag_remap, + .port_set_frame_mode = mv88e6351_port_set_frame_mode, + .port_set_egress_unknowns = mv88e6351_port_set_egress_unknowns, + .port_set_ether_type = mv88e6351_port_set_ether_type, + .port_jumbo_config = mv88e6165_port_jumbo_config, + .port_egress_rate_limiting = mv88e6097_port_egress_rate_limiting, + .port_pause_config = mv88e6097_port_pause_config, + .stats_snapshot = mv88e6320_g1_stats_snapshot, + .stats_get_sset_count = mv88e6095_stats_get_sset_count, + .stats_get_strings = mv88e6095_stats_get_strings, + .stats_get_stats = mv88e6095_stats_get_stats, + .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, + .g1_set_egress_port = mv88e6095_g1_set_egress_port, + .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu, + .reset = mv88e6352_g1_reset, +}; + static const struct mv88e6xxx_ops mv88e6350_ops = { /* MV88E6XXX_FAMILY_6351 */ .set_switch_mac = mv88e6xxx_g2_set_switch_mac, @@ -4086,6 +4114,20 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = { .ops = &mv88e6321_ops, }, + [MV88E6341] = { + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341, + .family = MV88E6XXX_FAMILY_6352, + .name = "Marvell 88E6341", + .num_databases = 4096, + .num_ports = 6, + .port_base_addr = 0x10, + .global1_addr = 0x1b, + .age_time_coeff = 15000, + .tag_protocol = DSA_TAG_PROTO_EDSA, + .flags = MV88E6XXX_FLAGS_FAMILY_6352, + .ops = &mv88e6341_ops, + }, + [MV88E6350] = { .prod_num = PORT_SWITCH_ID_PROD_NUM_6350, .family = MV88E6XXX_FAMILY_6351, diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h index af54bae..cb55fdb 100644 --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h @@ -100,6 +100,7 @@ #define PORT_SWITCH_ID_PROD_NUM_6240 0x240 #define PORT_SWITCH_ID_PROD_NUM_6290 0x290 #define PORT_SWITCH_ID_PROD_NUM_6321 0x310 +#define PORT_SWITCH_ID_PROD_NUM_6341 0x340 #define PORT_SWITCH_ID_PROD_NUM_6352 0x352 #define PORT_SWITCH_ID_PROD_NUM_6350 0x371 #define PORT_SWITCH_ID_PROD_NUM_6351 0x375 @@ -432,6 +433,7 @@ enum mv88e6xxx_model { MV88E6290, MV88E6320, MV88E6321, + MV88E6341, MV88E6350, MV88E6351, MV88E6352, @@ -448,7 +450,7 @@ enum mv88e6xxx_family { MV88E6XXX_FAMILY_6185, /* 6108 6121 6122 6131 6152 6155 6182 6185 */ MV88E6XXX_FAMILY_6320, /* 6320 6321 */ MV88E6XXX_FAMILY_6351, /* 6171 6175 6350 6351 */ - MV88E6XXX_FAMILY_6352, /* 6172 6176 6240 6352 */ + MV88E6XXX_FAMILY_6352, /* 6172 6176 6240 6341 6352 */ MV88E6XXX_FAMILY_6390, /* 6190 6190X 6191 6290 6390 6390X */ }; -- 2.9.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141 @ 2016-12-21 12:57 ` Romain Perier 0 siblings, 0 replies; 10+ messages in thread From: Romain Perier @ 2016-12-21 12:57 UTC (permalink / raw) To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Jason Cooper, Sebastian Hesselbarth, Gregory Clement Cc: netdev, devicetree, Rob Herring, Ian Campbell, Pawel Moll, Mark Rutland, Kumar Gala, linux-arm-kernel, Thomas Petazzoni, Nadav Haklai, Romain Perier The Marvell 88E6341 device is single-chip, 6-port ethernet switch with four integrated 10/100/1000Mbps ethernet transceivers and one high speed SerDes interfaces. It is compatible with switches of family 88E6352. This commit adds basic support for this switch by describing its capabilities to the driver. Signed-off-by: Romain Perier <romain.perier@free-electrons.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- Changes in v3: - Added tag "Reviewed-by" by Andrew Changes in v2: - Add a dedicated data structure for the operations of the 88E6341 - Re-ordered PORT_SWITCH_ID_PROD_NUM_6341 in alphabetic order with other macros drivers/net/dsa/mv88e6xxx/chip.c | 42 +++++++++++++++++++++++++++++++++++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 4 +++- 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 76d944e..5e97dc4 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3625,6 +3625,34 @@ static const struct mv88e6xxx_ops mv88e6321_ops = { .reset = mv88e6352_g1_reset, }; +static const struct mv88e6xxx_ops mv88e6341_ops = { + /* MV88E6XXX_FAMILY_6352 */ + .get_eeprom = mv88e6xxx_g2_get_eeprom16, + .set_eeprom = mv88e6xxx_g2_set_eeprom16, + .set_switch_mac = mv88e6xxx_g2_set_switch_mac, + .phy_read = mv88e6xxx_g2_smi_phy_read, + .phy_write = mv88e6xxx_g2_smi_phy_write, + .port_set_link = mv88e6xxx_port_set_link, + .port_set_duplex = mv88e6xxx_port_set_duplex, + .port_set_rgmii_delay = mv88e6352_port_set_rgmii_delay, + .port_set_speed = mv88e6352_port_set_speed, + .port_tag_remap = mv88e6095_port_tag_remap, + .port_set_frame_mode = mv88e6351_port_set_frame_mode, + .port_set_egress_unknowns = mv88e6351_port_set_egress_unknowns, + .port_set_ether_type = mv88e6351_port_set_ether_type, + .port_jumbo_config = mv88e6165_port_jumbo_config, + .port_egress_rate_limiting = mv88e6097_port_egress_rate_limiting, + .port_pause_config = mv88e6097_port_pause_config, + .stats_snapshot = mv88e6320_g1_stats_snapshot, + .stats_get_sset_count = mv88e6095_stats_get_sset_count, + .stats_get_strings = mv88e6095_stats_get_strings, + .stats_get_stats = mv88e6095_stats_get_stats, + .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, + .g1_set_egress_port = mv88e6095_g1_set_egress_port, + .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu, + .reset = mv88e6352_g1_reset, +}; + static const struct mv88e6xxx_ops mv88e6350_ops = { /* MV88E6XXX_FAMILY_6351 */ .set_switch_mac = mv88e6xxx_g2_set_switch_mac, @@ -4086,6 +4114,20 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = { .ops = &mv88e6321_ops, }, + [MV88E6341] = { + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341, + .family = MV88E6XXX_FAMILY_6352, + .name = "Marvell 88E6341", + .num_databases = 4096, + .num_ports = 6, + .port_base_addr = 0x10, + .global1_addr = 0x1b, + .age_time_coeff = 15000, + .tag_protocol = DSA_TAG_PROTO_EDSA, + .flags = MV88E6XXX_FLAGS_FAMILY_6352, + .ops = &mv88e6341_ops, + }, + [MV88E6350] = { .prod_num = PORT_SWITCH_ID_PROD_NUM_6350, .family = MV88E6XXX_FAMILY_6351, diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h index af54bae..cb55fdb 100644 --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h @@ -100,6 +100,7 @@ #define PORT_SWITCH_ID_PROD_NUM_6240 0x240 #define PORT_SWITCH_ID_PROD_NUM_6290 0x290 #define PORT_SWITCH_ID_PROD_NUM_6321 0x310 +#define PORT_SWITCH_ID_PROD_NUM_6341 0x340 #define PORT_SWITCH_ID_PROD_NUM_6352 0x352 #define PORT_SWITCH_ID_PROD_NUM_6350 0x371 #define PORT_SWITCH_ID_PROD_NUM_6351 0x375 @@ -432,6 +433,7 @@ enum mv88e6xxx_model { MV88E6290, MV88E6320, MV88E6321, + MV88E6341, MV88E6350, MV88E6351, MV88E6352, @@ -448,7 +450,7 @@ enum mv88e6xxx_family { MV88E6XXX_FAMILY_6185, /* 6108 6121 6122 6131 6152 6155 6182 6185 */ MV88E6XXX_FAMILY_6320, /* 6320 6321 */ MV88E6XXX_FAMILY_6351, /* 6171 6175 6350 6351 */ - MV88E6XXX_FAMILY_6352, /* 6172 6176 6240 6352 */ + MV88E6XXX_FAMILY_6352, /* 6172 6176 6240 6341 6352 */ MV88E6XXX_FAMILY_6390, /* 6190 6190X 6191 6290 6390 6390X */ }; -- 2.9.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin @ 2017-01-05 14:25 ` Gregory CLEMENT 0 siblings, 0 replies; 10+ messages in thread From: Gregory CLEMENT @ 2017-01-05 14:25 UTC (permalink / raw) To: linux-arm-kernel Hi David, On mer., d?c. 21 2016, Romain Perier <romain.perier@free-electrons.com> wrote: > This set of patches adds support for the Marvell ethernet switch 88E6341. > It also add the devicetree definition of this switch to the DT board. The forth version of this series had been sent while the net-next merge window was closed so I think it was missed. Do you want that we send it again on the netdev mainling list? Thanks, Gregory > > Romain Perier (2): > net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= > num_of_ports > net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141 > > drivers/net/dsa/mv88e6xxx/chip.c | 48 ++++++++++++++++++++++++++++++----- > drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 4 ++- > 2 files changed, 45 insertions(+), 7 deletions(-) > > -- > > Note: As requested by Gregory, I have removed the patch for the DT (already merged). > > 2.9.3 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin @ 2017-01-05 14:25 ` Gregory CLEMENT 0 siblings, 0 replies; 10+ messages in thread From: Gregory CLEMENT @ 2017-01-05 14:25 UTC (permalink / raw) To: David Miller Cc: Andrew Lunn, Romain Perier, Vivien Didelot, Florian Fainelli, Jason Cooper, Sebastian Hesselbarth, netdev-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Ian Campbell, Pawel Moll, Mark Rutland, Kumar Gala, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thomas Petazzoni, Nadav Haklai Hi David, On mer., déc. 21 2016, Romain Perier <romain.perier-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > This set of patches adds support for the Marvell ethernet switch 88E6341. > It also add the devicetree definition of this switch to the DT board. The forth version of this series had been sent while the net-next merge window was closed so I think it was missed. Do you want that we send it again on the netdev mainling list? Thanks, Gregory > > Romain Perier (2): > net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= > num_of_ports > net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141 > > drivers/net/dsa/mv88e6xxx/chip.c | 48 ++++++++++++++++++++++++++++++----- > drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 4 ++- > 2 files changed, 45 insertions(+), 7 deletions(-) > > -- > > Note: As requested by Gregory, I have removed the patch for the DT (already merged). > > 2.9.3 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin 2017-01-05 14:25 ` Gregory CLEMENT @ 2017-01-05 14:52 ` Andrew Lunn -1 siblings, 0 replies; 10+ messages in thread From: Andrew Lunn @ 2017-01-05 14:52 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 05, 2017 at 03:25:53PM +0100, Gregory CLEMENT wrote: > Hi David, > > On mer., d?c. 21 2016, Romain Perier <romain.perier@free-electrons.com> wrote: > > > This set of patches adds support for the Marvell ethernet switch 88E6341. > > It also add the devicetree definition of this switch to the DT board. > > The forth version of this series had been sent while the net-next merge > window was closed so I think it was missed. Having done a bit more research, i'm pretty sure the second patch is wrong. The 88E6341 is not compatible with the 6352, it is a different family. It might be more like the 6390. So supporting it will need a side-by-side comparison of the datasheet against the 6352 and the 6390, and the correct selection of the ops. Andrew ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin @ 2017-01-05 14:52 ` Andrew Lunn 0 siblings, 0 replies; 10+ messages in thread From: Andrew Lunn @ 2017-01-05 14:52 UTC (permalink / raw) To: Gregory CLEMENT Cc: Mark Rutland, devicetree, Florian Fainelli, Romain Perier, Jason Cooper, Pawel Moll, Vivien Didelot, netdev, Ian Campbell, Nadav Haklai, Rob Herring, Kumar Gala, David Miller, Thomas Petazzoni, linux-arm-kernel, Sebastian Hesselbarth On Thu, Jan 05, 2017 at 03:25:53PM +0100, Gregory CLEMENT wrote: > Hi David, > > On mer., déc. 21 2016, Romain Perier <romain.perier@free-electrons.com> wrote: > > > This set of patches adds support for the Marvell ethernet switch 88E6341. > > It also add the devicetree definition of this switch to the DT board. > > The forth version of this series had been sent while the net-next merge > window was closed so I think it was missed. Having done a bit more research, i'm pretty sure the second patch is wrong. The 88E6341 is not compatible with the 6352, it is a different family. It might be more like the 6390. So supporting it will need a side-by-side comparison of the datasheet against the 6352 and the 6390, and the correct selection of the ops. Andrew ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-01-05 14:52 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-12-21 12:57 [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin Romain Perier 2016-12-21 12:57 ` Romain Perier 2016-12-21 12:57 ` [PATCH net-next v4 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Romain Perier 2016-12-21 12:57 ` Romain Perier 2016-12-21 12:57 ` [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141 Romain Perier 2016-12-21 12:57 ` Romain Perier 2017-01-05 14:25 ` [PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin Gregory CLEMENT 2017-01-05 14:25 ` Gregory CLEMENT 2017-01-05 14:52 ` Andrew Lunn 2017-01-05 14:52 ` Andrew Lunn
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.