All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 6/7] ath10k: Enable periodic peer stats update
Date: Thu, 21 Jan 2016 14:48:13 +0200	[thread overview]
Message-ID: <87twm7yu7m.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1452699994-5078-7-git-send-email-mohammed@qca.qualcomm.com> (Mohammed Shafi Shajakhan's message of "Wed, 13 Jan 2016 21:16:33 +0530")

Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> writes:

> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>
> Register for 500ms as periodic peer stats update period,
> and parameters like rx_duration that needs to be tracked
> in host can be achieved by this provision, also periodic
> stats update is the future of fw_stats and shall be extended
> for pdev / vdev stats irrespecitive PEER_STATS service is enabled
> or not
>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath10k/mac.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 2dba57c..fd4b4df 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -4103,6 +4103,18 @@ static int ath10k_start(struct ieee80211_hw *hw)
>  
>  	ar->ani_enabled = true;
>  
> +	if (test_bit(WMI_SERVICE_PEER_STATS, ar->wmi.svc_map)) {
> +		param = ar->wmi.pdev_param->peer_stats_update_period;
> +		ret = ath10k_wmi_pdev_set_param(ar, param,
> +					PEER_DEFAULT_STATS_UPDATE_PERIOD);

This gives a new checkpatch warning:

drivers/net/wireless/ath/ath10k/mac.c:4110: Alignment should match open parenthesis

I fixed that in the pending branch.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 6/7] ath10k: Enable periodic peer stats update
Date: Thu, 21 Jan 2016 14:48:13 +0200	[thread overview]
Message-ID: <87twm7yu7m.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1452699994-5078-7-git-send-email-mohammed@qca.qualcomm.com> (Mohammed Shafi Shajakhan's message of "Wed, 13 Jan 2016 21:16:33 +0530")

Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> writes:

> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>
> Register for 500ms as periodic peer stats update period,
> and parameters like rx_duration that needs to be tracked
> in host can be achieved by this provision, also periodic
> stats update is the future of fw_stats and shall be extended
> for pdev / vdev stats irrespecitive PEER_STATS service is enabled
> or not
>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath10k/mac.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 2dba57c..fd4b4df 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -4103,6 +4103,18 @@ static int ath10k_start(struct ieee80211_hw *hw)
>  
>  	ar->ani_enabled = true;
>  
> +	if (test_bit(WMI_SERVICE_PEER_STATS, ar->wmi.svc_map)) {
> +		param = ar->wmi.pdev_param->peer_stats_update_period;
> +		ret = ath10k_wmi_pdev_set_param(ar, param,
> +					PEER_DEFAULT_STATS_UPDATE_PERIOD);

This gives a new checkpatch warning:

drivers/net/wireless/ath/ath10k/mac.c:4110: Alignment should match open parenthesis

I fixed that in the pending branch.

-- 
Kalle Valo

  reply	other threads:[~2016-01-21 12:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 15:46 [PATCH 0/7] Add support for Per STA Rx duration Mohammed Shafi Shajakhan
2016-01-13 15:46 ` Mohammed Shafi Shajakhan
2016-01-13 15:46 ` [PATCH 1/7] ath10k: Add support for parsing per STA rx_duration for 10.2.4 Mohammed Shafi Shajakhan
2016-01-13 15:46   ` Mohammed Shafi Shajakhan
2016-01-13 15:46 ` [PATCH 2/7] ath10k: Fix naming Peer stats rssi_changed field in 10.2.4 Mohammed Shafi Shajakhan
2016-01-13 15:46   ` Mohammed Shafi Shajakhan
2016-01-13 15:46 ` [PATCH 3/7] ath10k: Cleanup setting pdev paramaters Mohammed Shafi Shajakhan
2016-01-13 15:46   ` Mohammed Shafi Shajakhan
2016-01-13 15:46 ` [PATCH 4/7] ath10k: Rename few function names of firmware stats Mohammed Shafi Shajakhan
2016-01-13 15:46   ` Mohammed Shafi Shajakhan
2016-01-13 15:46 ` [PATCH 5/7] ath10k: Provision to support periodic peer stats update Mohammed Shafi Shajakhan
2016-01-13 15:46   ` Mohammed Shafi Shajakhan
2016-01-13 15:46 ` [PATCH 6/7] ath10k: Enable " Mohammed Shafi Shajakhan
2016-01-13 15:46   ` Mohammed Shafi Shajakhan
2016-01-21 12:48   ` Kalle Valo [this message]
2016-01-21 12:48     ` Kalle Valo
2016-01-21 14:01     ` Mohammed Shafi Shajakhan
2016-01-21 14:01       ` Mohammed Shafi Shajakhan
2016-01-13 15:46 ` [PATCH 7/7] ath10k: Add debugfs support for Per STA total rx duration Mohammed Shafi Shajakhan
2016-01-13 15:46   ` Mohammed Shafi Shajakhan
2016-01-26 15:02 ` [PATCH 0/7] Add support for Per STA Rx duration Kalle Valo
2016-01-26 15:02   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twm7yu7m.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mohammed@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.