All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: c_traja@qti.qualcomm.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/2 v2] ath10k: add fw_stats support to 10.4 firmware
Date: Fri, 16 Oct 2015 15:42:44 +0300	[thread overview]
Message-ID: <87twprgf23.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1444812862-11173-1-git-send-email-c_traja@qti.qualcomm.com> (c. traja's message of "Wed, 14 Oct 2015 14:24:22 +0530")

<c_traja@qti.qualcomm.com> writes:

> From: Manikanta <c_mpubbi@qti.qualcomm.com>
>
> This patch adds support for getting firmware debug stats in 10.4 fw.
>
> Signed-off-by: Tamizh chelvam <c_traja@qti.qualcomm.com>

This patch adds new warnings:

drivers/net/wireless/ath/ath10k/wmi.c:7121:6: warning: symbol 'ath10k_wmi_10_4_fw_stats_fill' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/wmi.c:7122: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/wmi.h:6323: Alignment should match open parenthesis

And while testing this I found this buggy:

root@lainahp:/sys/kernel/debug/ieee80211/phy0/ath10k# tail -20 fw_stats 
   MPDU errors (FCS, MIC, ENC)          0
        Num Rx Overflow errors          0

             ath10k VDEV stats (0)
             =================


             ath10k PEER stats (2)
             =================

              Peer MAC address 02:00:00:00:03:00
                     Peer RSSI 0
                  Peer TX rate 5120
                  Peer RX rate 0

              Peer MAC address 00:00:00:00:10:68
                     Peer RSSI 34236
                  Peer TX rate 31
                  Peer RX rate 0

The last two bytes of the client's mac address are bc:85 and 34236 is
0x85bc so ath10k is definitely not parsing the peer stats correctly.

I used:

[   68.077601] ath10k_pci 0000:02:00.0: pci irq msi interrupts 1 irq_mode 0 reset_mode 0
[   72.516344] ath10k_pci 0000:02:00.0: qca99x0 hw2.0 (0x01000000, 0x003801ff bmi 1:1) fw 10.4.1.00030-1 fwapi 5 bdapi 2 htt-ver 2.2 wmi-op 6 htt-op 4 cal otp max-sta 512 raw 0 hwcrypto 1 features no-p2p
[   72.516468] ath10k_pci 0000:02:00.0: debug 1 debugfs 1 tracing 1 dfs 1 testmode 1

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <c_traja@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2 v2] ath10k: add fw_stats support to 10.4 firmware
Date: Fri, 16 Oct 2015 15:42:44 +0300	[thread overview]
Message-ID: <87twprgf23.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1444812862-11173-1-git-send-email-c_traja@qti.qualcomm.com> (c. traja's message of "Wed, 14 Oct 2015 14:24:22 +0530")

<c_traja@qti.qualcomm.com> writes:

> From: Manikanta <c_mpubbi@qti.qualcomm.com>
>
> This patch adds support for getting firmware debug stats in 10.4 fw.
>
> Signed-off-by: Tamizh chelvam <c_traja@qti.qualcomm.com>

This patch adds new warnings:

drivers/net/wireless/ath/ath10k/wmi.c:7121:6: warning: symbol 'ath10k_wmi_10_4_fw_stats_fill' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/wmi.c:7122: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/wmi.h:6323: Alignment should match open parenthesis

And while testing this I found this buggy:

root@lainahp:/sys/kernel/debug/ieee80211/phy0/ath10k# tail -20 fw_stats 
   MPDU errors (FCS, MIC, ENC)          0
        Num Rx Overflow errors          0

             ath10k VDEV stats (0)
             =================


             ath10k PEER stats (2)
             =================

              Peer MAC address 02:00:00:00:03:00
                     Peer RSSI 0
                  Peer TX rate 5120
                  Peer RX rate 0

              Peer MAC address 00:00:00:00:10:68
                     Peer RSSI 34236
                  Peer TX rate 31
                  Peer RX rate 0

The last two bytes of the client's mac address are bc:85 and 34236 is
0x85bc so ath10k is definitely not parsing the peer stats correctly.

I used:

[   68.077601] ath10k_pci 0000:02:00.0: pci irq msi interrupts 1 irq_mode 0 reset_mode 0
[   72.516344] ath10k_pci 0000:02:00.0: qca99x0 hw2.0 (0x01000000, 0x003801ff bmi 1:1) fw 10.4.1.00030-1 fwapi 5 bdapi 2 htt-ver 2.2 wmi-op 6 htt-op 4 cal otp max-sta 512 raw 0 hwcrypto 1 features no-p2p
[   72.516468] ath10k_pci 0000:02:00.0: debug 1 debugfs 1 tracing 1 dfs 1 testmode 1

-- 
Kalle Valo

  reply	other threads:[~2015-10-16 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  8:54 [PATCH 2/2 v2] ath10k: add fw_stats support to 10.4 firmware c_traja
2015-10-14  8:54 ` c_traja
2015-10-16 12:42 ` Kalle Valo [this message]
2015-10-16 12:42   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twprgf23.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=c_traja@qti.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.