All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
	"Huangweidong (C)" <weidong.huang@huawei.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report
Date: Tue, 16 Sep 2014 18:16:06 +0200	[thread overview]
Message-ID: <87tx47a6d5.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1410877007.32607.9.camel@nilsson.home.kraxel.org> (Gerd Hoffmann's message of "Tue, 16 Sep 2014 16:16:47 +0200")

Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
>> > Gonglei (2):
>> >   redirect.c: Don't use qerror_report()
>> >   dev-network: Don't use qerror_report_err()
>
>> Hi, Gerd 
>> Would you like to apply this patch series at present? Thanks!
>
> Picked it up now.  Originally dropped due to review comments from paolo,
> but switching all usb over to realize is a bigger project indeed.

Please don't, it degrades QMP errors.  Example:

    { "execute": "device_add", "arguments": { "driver": "usb-redir" } }

Reply before:

    {"error": {"class": "GenericError", "desc": "Parameter 'chardev' is missing"}}

After:

    {"error": {"class": "GenericError", "desc": "Device initialization failed."}}

with "Parameter 'chardev' is missing" barfed to stderr.

  reply	other threads:[~2014-09-16 16:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12  7:30 [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report arei.gonglei
2014-09-12  7:30 ` [Qemu-devel] [PATCH v2 1/2] redirect.c: Don't use qerror_report() arei.gonglei
2014-09-12  7:30 ` [Qemu-devel] [PATCH v2 2/2] dev-network: Don't use qerror_report_err() arei.gonglei
2014-09-12  8:35 ` [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report Paolo Bonzini
2014-09-12  8:50   ` Gonglei (Arei)
2014-09-12  8:59     ` Paolo Bonzini
2014-09-12  9:09       ` Gonglei (Arei)
2014-09-16 13:54 ` Gonglei (Arei)
2014-09-16 14:08   ` Paolo Bonzini
2014-09-16 14:25     ` Markus Armbruster
2014-09-17  1:00       ` Gonglei (Arei)
2014-09-16 14:16   ` Gerd Hoffmann
2014-09-16 16:16     ` Markus Armbruster [this message]
2014-09-17  1:02       ` Gonglei (Arei)
2014-09-18  3:14     ` Gonglei (Arei)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx47a6d5.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weidong.huang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.