From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: prevent CE from looping indefinitely
Date: Mon, 9 Sep 2013 11:00:11 +0300 [thread overview]
Message-ID: <87txhuctmc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1378213798-24769-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 3 Sep 2013 15:09:58 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> The double while() could end up running forever.
> Inner while() would complete very fast. However
> the completion processing could take enough time
> for more completions to flow in. In that case the
> outer while() would not terminate and run again,
> and again. This could happen especially on a slow
> host system.
>
> This could lead to a system freeze during heavy
> traffic. Note: this doesn't solve all known
> starvation issues yet.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Applied, thanks.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: prevent CE from looping indefinitely
Date: Mon, 9 Sep 2013 11:00:11 +0300 [thread overview]
Message-ID: <87txhuctmc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1378213798-24769-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 3 Sep 2013 15:09:58 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> The double while() could end up running forever.
> Inner while() would complete very fast. However
> the completion processing could take enough time
> for more completions to flow in. In that case the
> outer while() would not terminate and run again,
> and again. This could happen especially on a slow
> host system.
>
> This could lead to a system freeze during heavy
> traffic. Note: this doesn't solve all known
> starvation issues yet.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Applied, thanks.
--
Kalle Valo
next prev parent reply other threads:[~2013-09-09 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 13:09 [PATCH] ath10k: prevent CE from looping indefinitely Michal Kazior
2013-09-03 13:09 ` Michal Kazior
2013-09-09 8:00 ` Kalle Valo [this message]
2013-09-09 8:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txhuctmc.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.