From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Oliver McFadden <oliver.mcfadden@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Set guardband clipping workaround bit in the right register.
Date: Tue, 09 Oct 2012 10:43:10 +0300 [thread overview]
Message-ID: <87txu4ks4x.fsf@rosetta.fi.intel.com> (raw)
In-Reply-To: <1349625067-4677-1-git-send-email-kenneth@whitecape.org>
On Sun, 7 Oct 2012 08:51:07 -0700, Kenneth Graunke <kenneth@whitecape.org> wrote:
> A previous patch, namely:
>
> commit bf97b276ca04cee9ab65ffd378fa8e6aedd71ff6
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Wed Apr 11 20:42:41 2012 +0200
>
> drm/i915: implement w/a for incorrect guarband clipping
>
> accidentally set bit 5 in 3D_CHICKEN, which has nothing to do with
> clipping. This patch changes it to be set in 3D_CHICKEN3, where it
> belongs.
>
> The game "Dante" demonstrates random clipping issues when guardband
> clipping is enabled and bit 5 of 3D_CHICKEN3 isn't set. So the
> workaround is actually necessary.
>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Oliver McFadden <oliver.mcfadden@linux.intel.com>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
next prev parent reply other threads:[~2012-10-09 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 0:46 [PATCH] drm/i915: Set guardband clipping workaround bit in the right register Kenneth Graunke
2012-10-06 6:26 ` Paul Menzel
2012-10-07 15:51 ` Kenneth Graunke
2012-10-09 7:43 ` Mika Kuoppala [this message]
2012-10-09 9:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txu4ks4x.fsf@rosetta.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
--cc=oliver.mcfadden@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.