All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH uq/master] kvmvapic: Disable if there is insufficient memory
Date: Tue, 14 Aug 2012 13:40:58 +0200	[thread overview]
Message-ID: <87txw5itv9.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <502A32BB.2000607@siemens.com> (Jan Kiszka's message of "Tue, 14 Aug 2012 13:12:59 +0200")

Jan Kiszka <jan.kiszka@siemens.com> writes:

> We need at least 1M of RAM to map the option ROM. Otherwise, we will
> corrupt host memory or even crash.

Let's put a reproducer in the commit message, if it's not too much
trouble.  Here's mine:

    $ qemu-system-x86_64 -nodefaults --enable-kvm -vnc :0 -m 640k
    Segmentation fault (core dumped)

> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Tested-by: Markus Armbruster <armbru@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH uq/master] kvmvapic: Disable if there is insufficient memory
Date: Tue, 14 Aug 2012 13:40:58 +0200	[thread overview]
Message-ID: <87txw5itv9.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <502A32BB.2000607@siemens.com> (Jan Kiszka's message of "Tue, 14 Aug 2012 13:12:59 +0200")

Jan Kiszka <jan.kiszka@siemens.com> writes:

> We need at least 1M of RAM to map the option ROM. Otherwise, we will
> corrupt host memory or even crash.

Let's put a reproducer in the commit message, if it's not too much
trouble.  Here's mine:

    $ qemu-system-x86_64 -nodefaults --enable-kvm -vnc :0 -m 640k
    Segmentation fault (core dumped)

> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Tested-by: Markus Armbruster <armbru@redhat.com>

  reply	other threads:[~2012-08-14 11:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 11:12 [PATCH uq/master] kvmvapic: Disable if there is insufficient memory Jan Kiszka
2012-08-14 11:12 ` [Qemu-devel] " Jan Kiszka
2012-08-14 11:40 ` Markus Armbruster [this message]
2012-08-14 11:40   ` Markus Armbruster
2012-08-14 11:43   ` [PATCH v2 " Jan Kiszka
2012-08-14 11:43     ` [Qemu-devel] " Jan Kiszka
2012-08-14 19:01     ` Marcelo Tosatti
2012-08-14 19:01       ` [Qemu-devel] " Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txw5itv9.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.